Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.devel.mentors > #44066

Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime)

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Control: tags -1 moreinfo

On Tue, Sep 22, 2020 at 10:58:26AM +0200, Alec Leamas wrote:

Hi Alec,

To avoid confustion, I'm comparing the version in the archive (1.2.1-1.1) with
yours, in case you missed the NMU.

- d/changelog you need to include the changelog of the NMU in your
  changelog.
- d/copyright: Can you add the upstream contact?
  You probably also want to update the years on the debian section.
- d/control: you re-adding python-catkin-pkg as B-D. Is it needed?
  (asking, as #943082 says no)
- d/rules: in the dh_override_auto_configure: you don't need to repeat
  the buildsystem parameter.
- (not required for upload)
  not sure if you really need the 0007 patch; verbose builds should be
  enabled automatically. (If not, you probably want to pass
  -DCMAKE_VERBOSE_MAKEFILE=On the dh_override_auto_configure
  (patches patching CMakeLists.txt will break on every upstream release,
   in my experience. Or TL;DL: It's PITA).

For later (as this requires a trip though NEW), maybe you want to put
the doxygen documentation on a arch:all -doc package?

Only minor changes required ;-) Good job!

Cheers,
--
tobi

Back to linux.debian.devel.mentors | Previous | Next | Find similar | Unroll thread

Thread

Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime) Tobias Frost <tobi@debian.org> - 2020-09-22 12:00 +0200

csiph-web