Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1022245

Bug#966302: RFS: dukpy [ITP]

Show all headers | View raw

Hi Sao,

thanks a lot for your work on this package.

On Thu, Aug 20, 2020 at 11:16:27PM +0900, Sao I Kuan wrote:
> I'm looking for a sponsor for the package:
>   * dukpy (#966302)
> 
> The package is on:
>     https://salsa.debian.org/med-team/dukpy
> 
> The package is the last dependency of benten[1,2].
> 
> [1] https://github.com/rabix/benten
> [2] https://bugs.debian.org/963743
> 
> The package has 4 lintian-overrides, which is for ignoring the
> minified JavaScript source-is-missing.The package does have
> autopkgtest and passed well.
> 
> Please consider to review and sponsor this. Any kind of suggestions
> are appreciated.

Unfortunately that package is not that simple due to the included
JS.  For instance

   dukpy/jsmodules/typescriptServices.js

should be removed from package source and rather linked against

   /usr/share/nodejs/typescript/lib/typescriptServices.js

from package node-typescript which should be added to Depends (and may
be Build- / Test-Depends).  Also there are more copyright notices needed
for instance for react.js.  If I were you I would check the copyright
files of packages like

$ apt-file search react.js  | grep '/react.js$'
node-auto-bind: /usr/share/nodejs/auto-bind/react.js
node-babel-types: /usr/share/nodejs/babel-types/lib/react.js
node-babel-types: /usr/share/nodejs/babel-types/src/react.js
omnidb-common: /usr/lib/python3/dist-packages/OmniDB_app/static/OmniDB_app/js/explain/react.js
wordpress: /usr/share/wordpress/wp-includes/js/dist/vendor/react.js

I admit I'm a bit scared about all those code copies but well, this
might be a second order problem for the moment.  Please simply try

    grep -Ri copyright

to find possibly other files in the source tree to find missing
source paragraphs.

Sorry for the bad news that this package is not that simple.

Thanks for your work again anyway

      Andreas.

-- 
http://fam-tille.de

Back to linux.debian.bugs.dist | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Bug#966302: RFS: dukpy [ITP] Sao I Kuan <saoikuan@gmail.com> - 2020-08-20 16:30 +0200
  Bug#966302: RFS: dukpy [ITP] Andreas Tille <andreas@fam-tille.de> - 2020-08-20 22:50 +0200

csiph-web