Re: [PATCH] bpftool: Fix version string in recursive builds

From	Ben Hutchings <benh@debian.org>
Newsgroups	linux.debian.kernel
Subject	Re: [PATCH] bpftool: Fix version string in recursive builds
Date	2020-08-15 00:20 +0200
Message-ID	<ADQdk-7BM-3@gated-at.bofh.it> (permalink)
References	<ADvix-35c-1@gated-at.bofh.it> <ADQdk-7BM-5@gated-at.bofh.it>
Organization	Debian project

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, 2020-08-14 at 08:43 -0700, Yonghong Song wrote:
[...]
> I tried the following
> 
> --- a/tools/bpf/bpftool/Makefile
> +++ b/tools/bpf/bpftool/Makefile
> @@ -25,7 +25,7 @@ endif
> 
>   LIBBPF = $(LIBBPF_PATH)libbpf.a
> 
> -BPFTOOL_VERSION := $(shell make -rR --no-print-directory -sC ../../.. 
> kernelversion)
> +BPFTOOL_VERSION := $(shell MAKEFLAGS=w make -rR --no-print-directory 
> -sC ../../.. kernelversion)
> 
> -bash-4.4$ ./bpftool version
> ./bpftool v5.8.0
> 
> I set env variable MAKEFLAGS=w, and build bpftool it works fine too.
> Maybe I miss something or debian changed top level Makefile?

Yes, but we don't change MAKEFLAGS or any of the logic around quietness
or verbosity.

I assume there are other factors involved, as I've also been unable to
construct a simple reproducer.

Ben.

> I am testing against latest bpf tree.
> 
> >   
> >   $(LIBBPF): FORCE
> >   	$(if $(LIBBPF_OUTPUT),@mkdir -p $(LIBBPF_OUTPUT))
> > 
-- 
Ben Hutchings - Debian developer, member of kernel, installer and LTS teams

Back to linux.debian.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] bpftool: Fix version string in recursive builds Ben Hutchings <benh@debian.org> - 2020-08-14 02:00 +0200
  Re: [PATCH] bpftool: Fix version string in recursive builds Ben Hutchings <benh@debian.org> - 2020-08-15 00:20 +0200

csiph-web