Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > muc.lists.netbsd.source-changes > #156182 > unrolled thread
| Started by | Martin Husemann <martin@NetBSD.org> |
|---|---|
| First post | 2026-06-24 11:15 +0000 |
| Last post | 2026-06-25 10:41 +0900 |
| Articles | 2 — 2 participants |
Back to article view | Back to muc.lists.netbsd.source-changes
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: CVS commit: src/sys/net Martin Husemann <martin@NetBSD.org> - 2026-06-24 11:15 +0000
Re: CVS commit: src/sys/net Shoichi Yamaguchi <yamaguchi@netbsd.org> - 2026-06-25 10:41 +0900
| From | Martin Husemann <martin@NetBSD.org> |
|---|---|
| Date | 2026-06-24 11:15 +0000 |
| Subject | Re: CVS commit: src/sys/net |
| Message-ID | <aju8YvdnOSKBllxA@homeworld.netbsd.org> |
On Wed, Jun 24, 2026 at 06:56:04AM +0000, Shoichi YAMAGUCHI wrote:
> Module Name: src
> Committed By: yamaguchi
> Date: Wed Jun 24 06:56:04 UTC 2026
>
> Modified Files:
> src/sys/net: if_spppsubr.c
>
> Log Message:
> sppp: use atomic_loadstore(9) to read and write sp->pp_last_activity
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.292 -r1.293 src/sys/net/if_spppsubr.c
Sorry, but this breaks the build:
/work/src/sys/rump/net/lib/libnet/../../../../net/if_spppsubr.c: In function 'sp
pp_keepalive':
/work/src/sys/rump/net/lib/libnet/../../../../sys/atomic.h:427:9: note: in expansion of macro 'CTASSERT'
427 | CTASSERT(sizeof(*(p)) <= __ATOMIC_SIZE_MAX); \
| ^~~~~~~~
We do not have 64bit atomics on all architectures.
Does this have to be a 64bit value?
Martin
--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-admin@muc.de
[toc] | [next] | [standalone]
| From | Shoichi Yamaguchi <yamaguchi@netbsd.org> |
|---|---|
| Date | 2026-06-25 10:41 +0900 |
| Message-ID | <CAPnD6HpzkvFaLa4ZWmdhow9Q0Rj1T6x+FtAp_hrVfXspMP2aEg@mail.gmail.com> |
| In reply to | #156182 |
On Wed, Jun 24, 2026 at 8:15 PM Martin Husemann <martin@netbsd.org> wrote: > > On Wed, Jun 24, 2026 at 06:56:04AM +0000, Shoichi YAMAGUCHI wrote: > > Module Name: src > > Committed By: yamaguchi > > Date: Wed Jun 24 06:56:04 UTC 2026 > > > > Modified Files: > > src/sys/net: if_spppsubr.c > > > > Log Message: > > sppp: use atomic_loadstore(9) to read and write sp->pp_last_activity > > > > > > To generate a diff of this commit: > > cvs rdiff -u -r1.292 -r1.293 src/sys/net/if_spppsubr.c > > Sorry, but this breaks the build: > > /work/src/sys/rump/net/lib/libnet/../../../../net/if_spppsubr.c: In function 'sp > pp_keepalive': > /work/src/sys/rump/net/lib/libnet/../../../../sys/atomic.h:427:9: note: in expansion of macro 'CTASSERT' > 427 | CTASSERT(sizeof(*(p)) <= __ATOMIC_SIZE_MAX); \ > | ^~~~~~~~ > > We do not have 64bit atomics on all architectures. > > Does this have to be a 64bit value? > > Martin I apologize for my mistake and for not checking the build. Thank you so much for the fix, riastradh@. -- Yamaguchi -- Posted automagically by a mail2news gateway at muc.de e.V. Please direct questions, flames, donations, etc. to news-admin@muc.de
[toc] | [prev] | [standalone]
Back to top | Article view | muc.lists.netbsd.source-changes
csiph-web