Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1743175 > unrolled thread

[PATCH 0/3] mmc: meson-gx: fixes for v4.14

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] mmc: meson-gx: fixes for v4.14 Jerome Brunet <jbrunet@baylibre.com> - 2017-10-02 14:30 +0200
    [PATCH 2/3] mmc: meson-gx: fix rx phase reset Jerome Brunet <jbrunet@baylibre.com> - 2017-10-02 14:30 +0200
    Re: [PATCH 0/3] mmc: meson-gx: fixes for v4.14 Kevin Hilman <khilman@baylibre.com> - 2017-10-02 22:50 +0200

#1743175 — [PATCH 0/3] mmc: meson-gx: fixes for v4.14

This patchset fixes the issues reported by Heiner [0] with the odroid-c2.
In a nutshell, this series does the following:

* Make sure the mmc clock rate is not set higher than what is requested
* Reset the tuning values on mmc power cycle instead of POWER_ON
* Add tuning of the tx phase to the tuning function.

This fixes the problem seen on the odroid-c2, both for hs200 and hs400.
To check for regression, this series has also been tested on the gxl
libretech-cc

Ulf, could you please pick this as fixes for v4.14 ?

[0]: https://lkml.kernel.org/r/e2171288-84ef-82db-2efc-300935e6c062@gmail.com

Jerome Brunet (3):
  mmc: meson-gx: make sure the clock is rounded down
  mmc: meson-gx: fix rx phase reset
  mmc: meson-gx: include tx phase in the tuning process

 drivers/mmc/host/meson-gx-mmc.c | 26 ++++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)

-- 
2.13.5

[toc] | [next] | [standalone]

#1743177 — [PATCH 2/3] mmc: meson-gx: fix rx phase reset

Resetting the phase when POWER_ON is set the set_ios() call means that the
phase is reset almost every time the set_ios() is called, while the
expected behavior was to reset the phase on a power cycle.

This had gone unnoticed until now because in all mode (except hs400) the
tuning is done after the last to set_ios(). In such case, the tuning
result is used anyway.  In HS400, there are a few calls to set_ios() after
the tuning is done, overwriting the tuning result.

Resetting the phase on POWER_UP instead of POWER_ON solve the problem.

Fixes: d341ca88eead ("mmc: meson-gx: rework tuning function")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/mmc/host/meson-gx-mmc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 421c8719c202..08a55c2e96e1 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -745,6 +745,10 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 	case MMC_POWER_UP:
 		if (!IS_ERR(mmc->supply.vmmc))
 			mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, ios->vdd);
+
+		/* Reset rx phase */
+		clk_set_phase(host->rx_clk, 0);
+
 		break;
 
 	case MMC_POWER_ON:
@@ -758,8 +762,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 				host->vqmmc_enabled = true;
 		}
 
-		/* Reset rx phase */
-		clk_set_phase(host->rx_clk, 0);
 		break;
 	}
 
-- 
2.13.5

[toc] | [prev] | [next] | [standalone]

#1743302

Jerome Brunet <jbrunet@baylibre.com> writes:

> This patchset fixes the issues reported by Heiner [0] with the odroid-c2.
> In a nutshell, this series does the following:
>
> * Make sure the mmc clock rate is not set higher than what is requested
> * Reset the tuning values on mmc power cycle instead of POWER_ON
> * Add tuning of the tx phase to the tuning function.
>
> This fixes the problem seen on the odroid-c2, both for hs200 and hs400.
> To check for regression, this series has also been tested on the gxl
> libretech-cc
>
> Ulf, could you please pick this as fixes for v4.14 ?
>
> [0]: https://lkml.kernel.org/r/e2171288-84ef-82db-2efc-300935e6c062@gmail.com
>
> Jerome Brunet (3):
>   mmc: meson-gx: make sure the clock is rounded down
>   mmc: meson-gx: fix rx phase reset
>   mmc: meson-gx: include tx phase in the tuning process
>
>  drivers/mmc/host/meson-gx-mmc.c | 26 ++++++++++++++++++++++----
>  1 file changed, 22 insertions(+), 4 deletions(-)

Reviewed-by: Kevin Hilman <khilman@baylibre.com>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web