Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1742797 > unrolled thread

[PATCH 1/6] lightnvm: pblk: remove useless line

Started byRakesh Pandit <rakesh@tuxera.com>
First post2017-10-01 15:30 +0200
Last post2017-10-02 13:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 1/6] lightnvm: pblk: remove useless line Rakesh Pandit <rakesh@tuxera.com> - 2017-10-01 15:30 +0200
    Re: [PATCH 1/6] lightnvm: pblk: remove useless line Javier González <jg@lightnvm.io> - 2017-10-02 13:30 +0200

#1742797 — [PATCH 1/6] lightnvm: pblk: remove useless line

FromRakesh Pandit <rakesh@tuxera.com>
Date2017-10-01 15:30 +0200
Subject[PATCH 1/6] lightnvm: pblk: remove useless line
Message-ID<uvMtI-2Hh-13@gated-at.bofh.it>
Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
---
 drivers/lightnvm/pblk-core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index 1f8aa94..4ffd1d6 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -1053,7 +1053,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
 	/* Mark emeta metadata sectors as bad sectors. We need to consider bad
 	 * blocks to make sure that there are enough sectors to store emeta
 	 */
-	bit = lm->sec_per_line;
 	off = lm->sec_per_line - lm->emeta_sec[0];
 	bitmap_set(line->invalid_bitmap, off, lm->emeta_sec[0]);
 	while (nr_bb) {
-- 
2.7.4

[toc] | [next] | [standalone]


#1743129

FromJavier González <jg@lightnvm.io>
Date2017-10-02 13:30 +0200
Message-ID<uw758-6FT-13@gated-at.bofh.it>
In reply to#1742797

[Multipart message — attachments visible in raw view] — view raw

> On 1 Oct 2017, at 15.23, Rakesh Pandit <rakesh@tuxera.com> wrote:
> 
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> ---
> drivers/lightnvm/pblk-core.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index 1f8aa94..4ffd1d6 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -1053,7 +1053,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
> 	/* Mark emeta metadata sectors as bad sectors. We need to consider bad
> 	 * blocks to make sure that there are enough sectors to store emeta
> 	 */
> -	bit = lm->sec_per_line;
> 	off = lm->sec_per_line - lm->emeta_sec[0];
> 	bitmap_set(line->invalid_bitmap, off, lm->emeta_sec[0]);
> 	while (nr_bb) {
> --
> 2.7.4

LGTM

Reviewed-by: Javier González <javier@cnexlabs.com>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web