Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1742689 > unrolled thread
| Started by | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| First post | 2017-09-30 22:20 +0200 |
| Last post | 2017-09-30 22:20 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] staging: iio: ade7759: fix signed extension bug on shift of a u8 Jonathan Cameron <jic23@kernel.org> - 2017-09-30 22:20 +0200
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-09-30 22:20 +0200 |
| Subject | Re: [PATCH] staging: iio: ade7759: fix signed extension bug on shift of a u8 |
| Message-ID | <uvwoV-uH-1@gated-at.bofh.it> |
On Wed, 13 Sep 2017 18:02:02 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The current shift of st->rx[2] left shifts a u8 24 bits left,
> promotes the integer to a an int and then to a unsigned u64. If
> the top bit of st->rx[2] is set then we end up with all the upper
> bits being set to 1. Fix this by casting st->rx[2] to a u64 before
> the 24 bit left shift.
>
> Detected by CoverityScan CID#144940 ("Unintended sign extension")
>
> Fixes: 2919fa54ef64 ("staging: iio: meter: new driver for ADE7759 devices")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/staging/iio/meter/ade7759.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/iio/meter/ade7759.c
> index 1691760339da..02573c517d9d 100644
> --- a/drivers/staging/iio/meter/ade7759.c
> +++ b/drivers/staging/iio/meter/ade7759.c
> @@ -172,7 +172,7 @@ static int ade7759_spi_read_reg_40(struct device *dev,
> reg_address);
> goto error_ret;
> }
> - *val = ((u64)st->rx[1] << 32) | (st->rx[2] << 24) |
> + *val = ((u64)st->rx[1] << 32) | ((u64)st->rx[2] << 24) |
> (st->rx[3] << 16) | (st->rx[4] << 8) | st->rx[5];
>
> error_ret:
Back to top | Article view | linux.kernel
csiph-web