Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1742124 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-09-29 15:40 +0200 |
| Last post | 2017-10-01 05:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH][net-next] net: ipmr: make function ipmr_notifier_init static Colin King <colin.king@canonical.com> - 2017-09-29 15:40 +0200
Re: [PATCH][net-next] net: ipmr: make function ipmr_notifier_init static David Miller <davem@davemloft.net> - 2017-10-01 05:10 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-09-29 15:40 +0200 |
| Subject | [PATCH][net-next] net: ipmr: make function ipmr_notifier_init static |
| Message-ID | <uv3Gi-6KD-21@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The function ipmr_notifier_init is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
warning: symbol 'ipmr_notifier_init' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/ipv4/ipmr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
index 292a8e80bdfa..a844738b38bd 100644
--- a/net/ipv4/ipmr.c
+++ b/net/ipv4/ipmr.c
@@ -3224,7 +3224,7 @@ static const struct fib_notifier_ops ipmr_notifier_ops_template = {
.owner = THIS_MODULE,
};
-int __net_init ipmr_notifier_init(struct net *net)
+static int __net_init ipmr_notifier_init(struct net *net)
{
struct fib_notifier_ops *ops;
--
2.14.1
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-10-01 05:10 +0200 |
| Subject | Re: [PATCH][net-next] net: ipmr: make function ipmr_notifier_init static |
| Message-ID | <uvCNH-4V8-3@gated-at.bofh.it> |
| In reply to | #1742124 |
From: Colin King <colin.king@canonical.com> Date: Fri, 29 Sep 2017 14:34:22 +0100 > From: Colin Ian King <colin.king@canonical.com> > > The function ipmr_notifier_init is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > warning: symbol 'ipmr_notifier_init' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied, thank you.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web