Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1741571 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-09-28 15:50 +0200 |
| Last post | 2017-09-29 22:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH][drm-next] drm/radeon: make functions alloc_pasid and free_pasid static Colin King <colin.king@canonical.com> - 2017-09-28 15:50 +0200
Re: [PATCH][drm-next] drm/radeon: make functions alloc_pasid and free_pasid static Alex Deucher <alexdeucher@gmail.com> - 2017-09-29 22:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-09-28 15:50 +0200 |
| Subject | [PATCH][drm-next] drm/radeon: make functions alloc_pasid and free_pasid static |
| Message-ID | <uuHmq-1aC-19@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The functions alloc_pasid and free_pasid are local to the
source and do not need to be in global scope, so make them static.
Cleans up sparse warnings:
warning: symbol 'alloc_pasid' was not declared. Should it be static?
warning: symbol 'free_pasid' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/radeon/radeon_kfd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c
index a2ac8ac0930d..385b4d76956d 100644
--- a/drivers/gpu/drm/radeon/radeon_kfd.c
+++ b/drivers/gpu/drm/radeon/radeon_kfd.c
@@ -352,7 +352,7 @@ static uint32_t get_max_engine_clock_in_mhz(struct kgd_dev *kgd)
*/
static DEFINE_IDA(pasid_ida);
-int alloc_pasid(unsigned int bits)
+static int alloc_pasid(unsigned int bits)
{
int pasid = -EINVAL;
@@ -367,7 +367,7 @@ int alloc_pasid(unsigned int bits)
return pasid;
}
-void free_pasid(unsigned int pasid)
+static void free_pasid(unsigned int pasid)
{
ida_simple_remove(&pasid_ida, pasid);
}
--
2.14.1
[toc] | [next] | [standalone]
| From | Alex Deucher <alexdeucher@gmail.com> |
|---|---|
| Date | 2017-09-29 22:20 +0200 |
| Subject | Re: [PATCH][drm-next] drm/radeon: make functions alloc_pasid and free_pasid static |
| Message-ID | <uv9Vo-2wp-9@gated-at.bofh.it> |
| In reply to | #1741571 |
On Thu, Sep 28, 2017 at 9:46 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The functions alloc_pasid and free_pasid are local to the
> source and do not need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> warning: symbol 'alloc_pasid' was not declared. Should it be static?
> warning: symbol 'free_pasid' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied. thanks!
Alex
> ---
> drivers/gpu/drm/radeon/radeon_kfd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c
> index a2ac8ac0930d..385b4d76956d 100644
> --- a/drivers/gpu/drm/radeon/radeon_kfd.c
> +++ b/drivers/gpu/drm/radeon/radeon_kfd.c
> @@ -352,7 +352,7 @@ static uint32_t get_max_engine_clock_in_mhz(struct kgd_dev *kgd)
> */
> static DEFINE_IDA(pasid_ida);
>
> -int alloc_pasid(unsigned int bits)
> +static int alloc_pasid(unsigned int bits)
> {
> int pasid = -EINVAL;
>
> @@ -367,7 +367,7 @@ int alloc_pasid(unsigned int bits)
> return pasid;
> }
>
> -void free_pasid(unsigned int pasid)
> +static void free_pasid(unsigned int pasid)
> {
> ida_simple_remove(&pasid_ida, pasid);
> }
> --
> 2.14.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web