Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742253 > unrolled thread

Re: [PATCH] tpm: fix duplicate inline declaration specifier

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] tpm: fix duplicate inline declaration specifier Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-09-29 19:20 +0200
    Re: [PATCH] tpm: fix duplicate inline declaration specifier Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-09-30 02:50 +0200

#1742253 — Re: [PATCH] tpm: fix duplicate inline declaration specifier

On Tue, Sep 26, 2017 at 01:58:57PM +0000, Ruben Roy wrote:
> This commit fixes the duplicate inline declaration specifier in
> tpm2_rc_value which caused a warning
> 
> Signed-off-by: Ruben Roy <rubenroy2005@gmail.com>
> ---
>  drivers/char/tpm/tpm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
> index 04fbff2..f4d0272 100644
> --- a/drivers/char/tpm/tpm.h
> +++ b/drivers/char/tpm/tpm.h
> @@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
>  }
>  #endif
>  
> -static inline inline u32 tpm2_rc_value(u32 rc)
> +static inline u32 tpm2_rc_value(u32 rc)
>  {
>  	return (rc & BIT(7)) ? rc & 0xff : rc;
>  }
> -- 
> 1.8.3.1
> 

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

[toc] | [next] | [standalone]

#1742417

Thanks! This fixes a warning I was seeing with Clang:

drivers/char/tpm/tpm.h:560:15: warning: duplicate 'inline' declaration
specifier [-Wduplicate-decl-specifier]

On Fri, Sep 29, 2017 at 10:17 AM, Jarkko Sakkinen
<jarkko.sakkinen@linux.intel.com> wrote:
> On Tue, Sep 26, 2017 at 01:58:57PM +0000, Ruben Roy wrote:
>> This commit fixes the duplicate inline declaration specifier in
>> tpm2_rc_value which caused a warning
>>
>> Signed-off-by: Ruben Roy <rubenroy2005@gmail.com>
>> ---
>>  drivers/char/tpm/tpm.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
>> index 04fbff2..f4d0272 100644
>> --- a/drivers/char/tpm/tpm.h
>> +++ b/drivers/char/tpm/tpm.h
>> @@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
>>  }
>>  #endif
>>
>> -static inline inline u32 tpm2_rc_value(u32 rc)
>> +static inline u32 tpm2_rc_value(u32 rc)
>>  {
>>       return (rc & BIT(7)) ? rc & 0xff : rc;
>>  }
>> --
>> 1.8.3.1
>>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> /Jarkko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web