Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742086 > unrolled thread

[PATCH 0/3] Simplify panel bridge cleanup

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] Simplify panel bridge cleanup Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-09-29 15:00 +0200
    Re: [PATCH 0/3] Simplify panel bridge cleanup Philippe CORNU <philippe.cornu@st.com> - 2017-09-29 17:10 +0200
      Re: [PATCH 0/3] Simplify panel bridge cleanup Daniel Vetter <daniel@ffwll.ch> - 2017-10-02 10:00 +0200

#1742086 — [PATCH 0/3] Simplify panel bridge cleanup

The goal of this series is to simplify driver code when they need to clean up
a previously allocated panel bridge.
Few drivers have "is_panel_bridge" flag to be able to distinguish a
drm_panel_bridge from "simple" drm_bridge.
To remove this flag I propose to
- let drm_panel_bridge_remove() check if the bridge provided in parameter is
  really a drm_panel_bridge.
- add drm_of_panel_bridge_remove() to remove a bridge given DT port and
  endpoint
Finally that allow to remove drm_bridge structure and "is_panel_bridge" flag
from stm driver internal structure.

Benjamin Gaignard (3):
  drm/bridge: make drm_panel_bridge_remove more robust
  drm/drm_of: add drm_of_panel_bridge_remove function
  drm/stm: ltdc: remove bridge from driver internal structure

 drivers/gpu/drm/bridge/panel.c | 10 +++++++++-
 drivers/gpu/drm/drm_of.c       | 33 +++++++++++++++++++++++++++++++++
 drivers/gpu/drm/stm/ltdc.c     | 16 +++++-----------
 drivers/gpu/drm/stm/ltdc.h     |  2 --
 include/drm/drm_of.h           |  8 ++++++++
 5 files changed, 55 insertions(+), 14 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1742185

Hi Benjamin,
and many thanks for this cleanup patchset.

Reviewed-by: Philippe Cornu <philippe.cornu@st.com>
Tested-by: Philippe Cornu <philippe.cornu@st.com>

Philippe :-)

On 09/29/2017 02:59 PM, Benjamin Gaignard wrote:
> The goal of this series is to simplify driver code when they need to clean up
> a previously allocated panel bridge.
> Few drivers have "is_panel_bridge" flag to be able to distinguish a
> drm_panel_bridge from "simple" drm_bridge.
> To remove this flag I propose to
> - let drm_panel_bridge_remove() check if the bridge provided in parameter is
>    really a drm_panel_bridge.
> - add drm_of_panel_bridge_remove() to remove a bridge given DT port and
>    endpoint
> Finally that allow to remove drm_bridge structure and "is_panel_bridge" flag
> from stm driver internal structure.
> 
> Benjamin Gaignard (3):
>    drm/bridge: make drm_panel_bridge_remove more robust
>    drm/drm_of: add drm_of_panel_bridge_remove function
>    drm/stm: ltdc: remove bridge from driver internal structure
> 
>   drivers/gpu/drm/bridge/panel.c | 10 +++++++++-
>   drivers/gpu/drm/drm_of.c       | 33 +++++++++++++++++++++++++++++++++
>   drivers/gpu/drm/stm/ltdc.c     | 16 +++++-----------
>   drivers/gpu/drm/stm/ltdc.h     |  2 --
>   include/drm/drm_of.h           |  8 ++++++++
>   5 files changed, 55 insertions(+), 14 deletions(-)
> 

[toc] | [prev] | [next] | [standalone]

#1743003

On Fri, Sep 29, 2017 at 03:03:54PM +0000, Philippe CORNU wrote:
> Hi Benjamin,
> and many thanks for this cleanup patchset.
> 
> Reviewed-by: Philippe Cornu <philippe.cornu@st.com>
> Tested-by: Philippe Cornu <philippe.cornu@st.com>

Can you pls either convert vc4 and dw-mipi too, or add an entry to our
todo list in Documentation/gpu/todo.rst?

Thanks, Daniel

> 
> Philippe :-)
> 
> On 09/29/2017 02:59 PM, Benjamin Gaignard wrote:
> > The goal of this series is to simplify driver code when they need to clean up
> > a previously allocated panel bridge.
> > Few drivers have "is_panel_bridge" flag to be able to distinguish a
> > drm_panel_bridge from "simple" drm_bridge.
> > To remove this flag I propose to
> > - let drm_panel_bridge_remove() check if the bridge provided in parameter is
> >    really a drm_panel_bridge.
> > - add drm_of_panel_bridge_remove() to remove a bridge given DT port and
> >    endpoint
> > Finally that allow to remove drm_bridge structure and "is_panel_bridge" flag
> > from stm driver internal structure.
> > 
> > Benjamin Gaignard (3):
> >    drm/bridge: make drm_panel_bridge_remove more robust
> >    drm/drm_of: add drm_of_panel_bridge_remove function
> >    drm/stm: ltdc: remove bridge from driver internal structure
> > 
> >   drivers/gpu/drm/bridge/panel.c | 10 +++++++++-
> >   drivers/gpu/drm/drm_of.c       | 33 +++++++++++++++++++++++++++++++++
> >   drivers/gpu/drm/stm/ltdc.c     | 16 +++++-----------
> >   drivers/gpu/drm/stm/ltdc.h     |  2 --
> >   include/drm/drm_of.h           |  8 ++++++++
> >   5 files changed, 55 insertions(+), 14 deletions(-)
> > 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web