Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742142 > unrolled thread

RE: keyboard backlight max_brightness bug on Dell Latitude E6410

Started by"Gabriel M. Elder" <gabriel@tekgnowsys.com>
First post2017-09-29 16:10 +0200
Last post2017-10-02 15:20 +0200
Articles 7 — 4 participants

Back to article view | Back to linux.kernel

Contents

  RE: keyboard backlight max_brightness bug on Dell Latitude E6410 "Gabriel M. Elder" <gabriel@tekgnowsys.com> - 2017-09-29 16:10 +0200
    Re: keyboard backlight max_brightness bug on Dell Latitude E6410 Pali Rohár <pali.rohar@gmail.com> - 2017-09-29 16:20 +0200
      Re: keyboard backlight max_brightness bug on Dell Latitude E6410 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-09-29 17:30 +0200
        Re: keyboard backlight max_brightness bug on Dell Latitude E6410 Pali Rohár <pali.rohar@gmail.com> - 2017-10-02 14:00 +0200
          RE: keyboard backlight max_brightness bug on Dell Latitude E6410 <Mario.Limonciello@dell.com> - 2017-10-02 15:10 +0200
            Re: keyboard backlight max_brightness bug on Dell Latitude E6410 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-10-02 15:20 +0200
            Re: keyboard backlight max_brightness bug on Dell Latitude E6410 Pali Rohár <pali.rohar@gmail.com> - 2017-10-02 15:20 +0200

#1742142 — RE: keyboard backlight max_brightness bug on Dell Latitude E6410

From"Gabriel M. Elder" <gabriel@tekgnowsys.com>
Date2017-09-29 16:10 +0200
SubjectRE: keyboard backlight max_brightness bug on Dell Latitude E6410
Message-ID<uv49k-7bh-23@gated-at.bofh.it>
FYI, latest update and info relating to
https://bugzilla.kernel.org/show_bug.cgi?id=196913


--- a/drivers/platform/x86/dell-laptop.c	
+++ a/drivers/platform/x86/dell-laptop.c	
@@ -1217,7 +1217,7 @@ static int kbd_get_info(struct kbd_info *info)
 static unsigned int kbd_get_max_level(void)
 {
 	if (kbd_info.levels != 0)
-		return kbd_info.levels;
+		return kbd_info.levels - 1;
 	if (kbd_mode_levels_count > 0)
 		return kbd_mode_levels_count - 1;
 	return 0;


Finally had a chance to make this mod, compile and try it out. Based on
my testing, it seems to completely correct the problem.

Upon initially opening the power panel in gnome-control-center, the
keyboard brightness slider is all the way over to the right, where one
would expect it to be, as well as all of the brightness step levels.
Closing the lid, putting it to sleep and waking it back up does not have
the annoying keyboard backlight disabling side-effect that I previously
described.

- Gabriel


-------- Original Message --------
Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
E6410
From: Pali Rohár <pali.rohar@gmail.com>
Date: Thu, September 14, 2017 10:25 am
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>, Mario Limonciello
<Mario_Limonciello@Dell.com>
Cc: "Gabriel M. Elder" <gabriel@tekgnowsys.com>, Darren Hart
<dvhart@infradead.org>, andy@infradead.org,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>, "linux-kernel@vger.kernel.org"
<linux-kernel@vger.kernel.org>

On Thursday 14 September 2017 16:33:57 Gabriele Mazzotta wrote:
> 2017-09-14 15:54 GMT+02:00 Pali Rohár <pali.rohar@gmail.com>:
> > Adding Gabriele to thread, IIRC you have machine which uses
> > "supported keyboard light brightness levels"
> > Can you look at this bug, if your machine is affected by it too?
> 
> My keyboard has two brightness levels + off. The value of
> max_brightness is 2, as expected.

Ah :-(

So you have "Supported Keyboard light brightness levels : 2" and you
can se value 0, 1 or 2.

And Gabriel has "Supported Keyboard light brightness levels : 10" and
can set only values 0..9. But not 10.

Any idea how to solve this situation?

CCing Mario from Dell. Can you recheck what is wrong here? Or why
Dell Latitude E6410 behaves differently?

> Gabriele
> 
> Yes, my laptop uses "supported keyboard light brightness levels".
> >
> > Important parts in ouptput:
> >
> >> ... --info
> >> Supported Keyboard light brightness levels : 10
> >
> >> ... --get-status
> >> Current keyboard light level : 9
> >
> > Gabriel, can you play with this tool, which values can be set via
> > --set-level= parameter? Is 10 accepted? --get-status can be used to
> > check if value was accepted.
> >
> > On Thursday 14 September 2017 06:35:15 Gabriel M. Elder wrote:
> >>
> >> output from smbios-keyboard-ctl --info:
> >>
> >> Libsmbios version : 2.3.0
> >> smbios-keyboard-ctl version : 2.3.0
> >>
> >> Capabilities of KeyBoard Illumination on your system:
> >> -------------------------------------------------------------------
> >> Supported USER Selectable Modes :
> >> Always OFF
> >> Auto: ALS- and input-activity-based On; input-activity based Off
> >> Auto: Input-activity-based On; input-activity based Off
> >>
> >> Supported Keyboard illumination type : Backlight
> >>
> >> Supports Keyboard illumination on :
> >> Any Keystroke
> >> Touchpad activity
> >> Pointing stick
> >>
> >> Can configure Keyboard illumination timeout unit in :
> >> Seconds
> >> Minutes
> >> Hours
> >>
> >> Supported Keyboard light brightness levels : 10
> >>
> >> Maximum acceptable seconds timeout value : 255
> >>
> >> Maximum acceptable minutes timeout value : 255
> >>
> >> Maximum acceptable hours timeout value : 12
> >>
> >> Maximum acceptable days timeout value : 0
> >>
> >>
> >> output from smbios-keyboard-ctl --get-status:
> >>
> >> Helper function to print current status of keyboard illumination
> >>
> >> Current status of KeyBoard Illumination setting on your system:
> >> -------------------------------------------------------------------
> >>
> >> Configured mode state:
> >> Auto: Input-activity-based On; input-activity based Off
> >>
> >> Your Keyboard will illumination on:
> >> Any Keystroke
> >> Touchpad activity
> >> Pointing stick
> >>
> >> Keyboard illumination timeout has bee set at: 10 Seconds
> >>
> >> Current setting of ALS value that turns the light on or off: 18
> >> Current ALS Reading : 16
> >> Current keyboard light level : 9
> >>
> >>
> >> -------- Original Message --------
> >> Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
> >> E6410
> >> From: Pali Rohár <pali.rohar@gmail.com>
> >> Date: Thu, September 14, 2017 3:06 am
> >> To: "Gabriel M. Elder" <gabriel@tekgnowsys.com>
> >> Cc: dvhart@infradead.org, andy@infradead.org,
> >> platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
> >>
> >> On Monday 11 September 2017 23:25:27 Gabriel M. Elder wrote:
> >> > Hi all,
> >> > Hans de Goede, one of the upower maintainers, suggested I alert you all to this bug:
> >> >
> >> > https://bugs.freedesktop.org/show_bug.cgi?id=100041
> >> >
> >> > and the new one I filed via the kernel bugzilla:
> >> >
> >> > https://bugzilla.kernel.org/show_bug.cgi?id=196913
> >> > "keyboard backlight max_brightness value outside allowable range on Dell Latitude E6410 laptop"
> >> >
> >> > Please check it out at your earliest convenience.
> >> >
> >> > thanks,
> >> > - Gabriel</html>
> >>
> >> Hi Gabriel, please avoid sending such html emails to mailing list as it
> >> is hard to read them and also you have a very big chance that email
> >> would be eaten by spam filter or other developers would completely
> >> ignore it...
> >>
> >> To debug your problem, can you run smbios-keyboard-ctl tool from the
> >> libsmbios project? https://github.com/dell/libsmbios
> >>
> >> We would need output from --info parameter and also from --get-status.
> >>
> >
> > --
> > Pali Rohár
> > pali.rohar@gmail.com

-- 
Pali Rohár
pali.rohar@gmail.com

[toc] | [next] | [standalone]

#1742153

FromPali Rohár <pali.rohar@gmail.com>
Date2017-09-29 16:20 +0200
Message-ID<uv4j0-7eW-17@gated-at.bofh.it>
In reply to#1742142
Yes, that would fix problem for you and break other machines...

On Friday 29 September 2017 07:08:23 Gabriel M. Elder wrote:
> FYI, latest update and info relating to
> https://bugzilla.kernel.org/show_bug.cgi?id=196913
> 
> 
> --- a/drivers/platform/x86/dell-laptop.c	
> +++ a/drivers/platform/x86/dell-laptop.c	
> @@ -1217,7 +1217,7 @@ static int kbd_get_info(struct kbd_info *info)
>  static unsigned int kbd_get_max_level(void)
>  {
>  	if (kbd_info.levels != 0)
> -		return kbd_info.levels;
> +		return kbd_info.levels - 1;
>  	if (kbd_mode_levels_count > 0)
>  		return kbd_mode_levels_count - 1;
>  	return 0;
> 
> 
> Finally had a chance to make this mod, compile and try it out. Based on
> my testing, it seems to completely correct the problem.
> 
> Upon initially opening the power panel in gnome-control-center, the
> keyboard brightness slider is all the way over to the right, where one
> would expect it to be, as well as all of the brightness step levels.
> Closing the lid, putting it to sleep and waking it back up does not have
> the annoying keyboard backlight disabling side-effect that I previously
> described.
> 
> - Gabriel
> 
> 
> -------- Original Message --------
> Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
> E6410
> From: Pali Rohár <pali.rohar@gmail.com>
> Date: Thu, September 14, 2017 10:25 am
> To: Gabriele Mazzotta <gabriele.mzt@gmail.com>, Mario Limonciello
> <Mario_Limonciello@Dell.com>
> Cc: "Gabriel M. Elder" <gabriel@tekgnowsys.com>, Darren Hart
> <dvhart@infradead.org>, andy@infradead.org,
> "platform-driver-x86@vger.kernel.org"
> <platform-driver-x86@vger.kernel.org>, "linux-kernel@vger.kernel.org"
> <linux-kernel@vger.kernel.org>
> 
> On Thursday 14 September 2017 16:33:57 Gabriele Mazzotta wrote:
> > 2017-09-14 15:54 GMT+02:00 Pali Rohár <pali.rohar@gmail.com>:
> > > Adding Gabriele to thread, IIRC you have machine which uses
> > > "supported keyboard light brightness levels"
> > > Can you look at this bug, if your machine is affected by it too?
> > 
> > My keyboard has two brightness levels + off. The value of
> > max_brightness is 2, as expected.
> 
> Ah :-(
> 
> So you have "Supported Keyboard light brightness levels : 2" and you
> can se value 0, 1 or 2.
> 
> And Gabriel has "Supported Keyboard light brightness levels : 10" and
> can set only values 0..9. But not 10.
> 
> Any idea how to solve this situation?
> 
> CCing Mario from Dell. Can you recheck what is wrong here? Or why
> Dell Latitude E6410 behaves differently?
> 
> > Gabriele
> > 
> > Yes, my laptop uses "supported keyboard light brightness levels".
> > >
> > > Important parts in ouptput:
> > >
> > >> ... --info
> > >> Supported Keyboard light brightness levels : 10
> > >
> > >> ... --get-status
> > >> Current keyboard light level : 9
> > >
> > > Gabriel, can you play with this tool, which values can be set via
> > > --set-level= parameter? Is 10 accepted? --get-status can be used to
> > > check if value was accepted.
> > >
> > > On Thursday 14 September 2017 06:35:15 Gabriel M. Elder wrote:
> > >>
> > >> output from smbios-keyboard-ctl --info:
> > >>
> > >> Libsmbios version : 2.3.0
> > >> smbios-keyboard-ctl version : 2.3.0
> > >>
> > >> Capabilities of KeyBoard Illumination on your system:
> > >> -------------------------------------------------------------------
> > >> Supported USER Selectable Modes :
> > >> Always OFF
> > >> Auto: ALS- and input-activity-based On; input-activity based Off
> > >> Auto: Input-activity-based On; input-activity based Off
> > >>
> > >> Supported Keyboard illumination type : Backlight
> > >>
> > >> Supports Keyboard illumination on :
> > >> Any Keystroke
> > >> Touchpad activity
> > >> Pointing stick
> > >>
> > >> Can configure Keyboard illumination timeout unit in :
> > >> Seconds
> > >> Minutes
> > >> Hours
> > >>
> > >> Supported Keyboard light brightness levels : 10
> > >>
> > >> Maximum acceptable seconds timeout value : 255
> > >>
> > >> Maximum acceptable minutes timeout value : 255
> > >>
> > >> Maximum acceptable hours timeout value : 12
> > >>
> > >> Maximum acceptable days timeout value : 0
> > >>
> > >>
> > >> output from smbios-keyboard-ctl --get-status:
> > >>
> > >> Helper function to print current status of keyboard illumination
> > >>
> > >> Current status of KeyBoard Illumination setting on your system:
> > >> -------------------------------------------------------------------
> > >>
> > >> Configured mode state:
> > >> Auto: Input-activity-based On; input-activity based Off
> > >>
> > >> Your Keyboard will illumination on:
> > >> Any Keystroke
> > >> Touchpad activity
> > >> Pointing stick
> > >>
> > >> Keyboard illumination timeout has bee set at: 10 Seconds
> > >>
> > >> Current setting of ALS value that turns the light on or off: 18
> > >> Current ALS Reading : 16
> > >> Current keyboard light level : 9
> > >>
> > >>
> > >> -------- Original Message --------
> > >> Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
> > >> E6410
> > >> From: Pali Rohár <pali.rohar@gmail.com>
> > >> Date: Thu, September 14, 2017 3:06 am
> > >> To: "Gabriel M. Elder" <gabriel@tekgnowsys.com>
> > >> Cc: dvhart@infradead.org, andy@infradead.org,
> > >> platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
> > >>
> > >> On Monday 11 September 2017 23:25:27 Gabriel M. Elder wrote:
> > >> > Hi all,
> > >> > Hans de Goede, one of the upower maintainers, suggested I alert you all to this bug:
> > >> >
> > >> > https://bugs.freedesktop.org/show_bug.cgi?id=100041
> > >> >
> > >> > and the new one I filed via the kernel bugzilla:
> > >> >
> > >> > https://bugzilla.kernel.org/show_bug.cgi?id=196913
> > >> > "keyboard backlight max_brightness value outside allowable range on Dell Latitude E6410 laptop"
> > >> >
> > >> > Please check it out at your earliest convenience.
> > >> >
> > >> > thanks,
> > >> > - Gabriel</html>
> > >>
> > >> Hi Gabriel, please avoid sending such html emails to mailing list as it
> > >> is hard to read them and also you have a very big chance that email
> > >> would be eaten by spam filter or other developers would completely
> > >> ignore it...
> > >>
> > >> To debug your problem, can you run smbios-keyboard-ctl tool from the
> > >> libsmbios project? https://github.com/dell/libsmbios
> > >>
> > >> We would need output from --info parameter and also from --get-status.
> > >>
> > >
> > > --
> > > Pali Rohár
> > > pali.rohar@gmail.com
> 

-- 
Pali Rohár
pali.rohar@gmail.com

[toc] | [prev] | [next] | [standalone]

#1742201

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-09-29 17:30 +0200
Message-ID<uv5oK-7Wg-23@gated-at.bofh.it>
In reply to#1742153
On Fri, Sep 29, 2017 at 5:11 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> Yes, that would fix problem for you and break other machines...

I dunno what happened to you guys to use top-posting...

>> FYI, latest update and info relating to
>> https://bugzilla.kernel.org/show_bug.cgi?id=196913

Quick solution is to apply DMI to that.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1743144

FromPali Rohár <pali.rohar@gmail.com>
Date2017-10-02 14:00 +0200
Message-ID<uw7y9-6Pz-3@gated-at.bofh.it>
In reply to#1742201
On Friday 29 September 2017 18:19:59 Andy Shevchenko wrote:
> >> FYI, latest update and info relating to
> >> https://bugzilla.kernel.org/show_bug.cgi?id=196913
> 
> Quick solution is to apply DMI to that.

It is only the Dell Latitude E6410 affected?

Mario, do you have any information about that API from Dell?

-- 
Pali Rohár
pali.rohar@gmail.com

[toc] | [prev] | [next] | [standalone]

#1743203

From<Mario.Limonciello@dell.com>
Date2017-10-02 15:10 +0200
Message-ID<uw8DT-7GI-3@gated-at.bofh.it>
In reply to#1743144
> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@gmail.com]
> Sent: Monday, October 2, 2017 6:53 AM
> To: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Gabriel M. Elder <gabriel@tekgnowsys.com>; Gabriele Mazzotta
> <gabriele.mzt@gmail.com>; Limonciello, Mario <Mario_Limonciello@Dell.com>;
> Darren Hart <dvhart@infradead.org>; Andy Shevchenko <andy@infradead.org>;
> platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: keyboard backlight max_brightness bug on Dell Latitude E6410
> 
> On Friday 29 September 2017 18:19:59 Andy Shevchenko wrote:
> > >> FYI, latest update and info relating to
> > >> https://bugzilla.kernel.org/show_bug.cgi?id=196913
> >
> > Quick solution is to apply DMI to that.
> 
> It is only the Dell Latitude E6410 affected?
> 
> Mario, do you have any information about that API from Dell?
> 
> --
> Pali Rohár
> pali.rohar@gmail.com

Pali,

I believe this particular API shouldn't have changed over generations, so it's 
likely something that needs to be quirked for that generation.  
I haven't had a chance to check on this yet in detail though.
For now could you guys quirk this one and if I find out there was something
more systemic we can undo the quirk and do something more broad.

Thanks,

[toc] | [prev] | [next] | [standalone]

#1743215

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-10-02 15:20 +0200
Message-ID<uw8Nz-7JN-9@gated-at.bofh.it>
In reply to#1743203
On Mon, Oct 2, 2017 at 4:15 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Monday 02 October 2017 13:06:46 Mario.Limonciello@dell.com wrote:

> Ok! Gabriel, can you provide us your DMI information about your machine?
>
> They are included in following files:
> /sys/class/dmi/id/sys_vendor
> /sys/class/dmi/id/product_name
>
> Beware that they may contain whitespace characters and it is important.

I would usually suggest to run dmidecode and attach an output somewhere.

(Just my 2 cents :-) )

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1743216

FromPali Rohár <pali.rohar@gmail.com>
Date2017-10-02 15:20 +0200
Message-ID<uw8Nz-7JN-11@gated-at.bofh.it>
In reply to#1743203
On Monday 02 October 2017 13:06:46 Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Pali Rohár [mailto:pali.rohar@gmail.com]
> > Sent: Monday, October 2, 2017 6:53 AM
> > To: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Cc: Gabriel M. Elder <gabriel@tekgnowsys.com>; Gabriele Mazzotta
> > <gabriele.mzt@gmail.com>; Limonciello, Mario <Mario_Limonciello@Dell.com>;
> > Darren Hart <dvhart@infradead.org>; Andy Shevchenko <andy@infradead.org>;
> > platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: Re: keyboard backlight max_brightness bug on Dell Latitude E6410
> > 
> > On Friday 29 September 2017 18:19:59 Andy Shevchenko wrote:
> > > >> FYI, latest update and info relating to
> > > >> https://bugzilla.kernel.org/show_bug.cgi?id=196913
> > >
> > > Quick solution is to apply DMI to that.
> > 
> > It is only the Dell Latitude E6410 affected?
> > 
> > Mario, do you have any information about that API from Dell?
> > 
> > --
> > Pali Rohár
> > pali.rohar@gmail.com
> 
> Pali,
> 
> I believe this particular API shouldn't have changed over generations, so it's 
> likely something that needs to be quirked for that generation.  
> I haven't had a chance to check on this yet in detail though.
> For now could you guys quirk this one and if I find out there was something
> more systemic we can undo the quirk and do something more broad.
> 
> Thanks,

Ok! Gabriel, can you provide us your DMI information about your machine?

They are included in following files:
/sys/class/dmi/id/sys_vendor
/sys/class/dmi/id/product_name

Beware that they may contain whitespace characters and it is important.

-- 
Pali Rohár
pali.rohar@gmail.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web