Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1742163 > unrolled thread

[PATCH V2 for-next 4/8] RDMA/hns: Set mask for destination qp field of qp context assignment

Started by"Wei Hu (Xavier)" <xavier.huwei@huawei.com>
First post2017-09-29 16:50 +0200
Last post2017-09-29 18:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH V2 for-next 4/8] RDMA/hns: Set mask for destination qp field of qp context assignment "Wei Hu (Xavier)" <xavier.huwei@huawei.com> - 2017-09-29 16:50 +0200
    Re: [PATCH V2 for-next 4/8] RDMA/hns: Set mask for destination qp  field of qp context assignment Doug Ledford <dledford@redhat.com> - 2017-09-29 18:10 +0200

#1742163 — [PATCH V2 for-next 4/8] RDMA/hns: Set mask for destination qp field of qp context assignment

From"Wei Hu (Xavier)" <xavier.huwei@huawei.com>
Date2017-09-29 16:50 +0200
Subject[PATCH V2 for-next 4/8] RDMA/hns: Set mask for destination qp field of qp context assignment
Message-ID<uv4M2-7tm-17@gated-at.bofh.it>
From: Lijun Ou <oulijun@huawei.com>

When only set IB_QP_DEST_QPN flag for attr_mask, the operation of
assigning the dest_qp_num for dest_qp field of qp context is valid.

Signed-off-by: Lijun Ou <oulijun@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
Signed-off-by: Shaobo Xu <xushaobo2@huawei.com>
---
 drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
index 6f309f7..10d828c 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
@@ -2888,10 +2888,11 @@ static int hns_roce_v1_m_qp(struct ib_qp *ibqp, const struct ib_qp_attr *attr,
 			       QP_CONTEXT_QPC_BYTES_32_RESPONDER_RESOURCES_S,
 			       ilog2((unsigned int)attr->max_dest_rd_atomic));
 
-		roce_set_field(context->qpc_bytes_36,
-			       QP_CONTEXT_QPC_BYTES_36_DEST_QP_M,
-			       QP_CONTEXT_QPC_BYTES_36_DEST_QP_S,
-			       attr->dest_qp_num);
+		if (attr_mask & IB_QP_DEST_QPN)
+			roce_set_field(context->qpc_bytes_36,
+				       QP_CONTEXT_QPC_BYTES_36_DEST_QP_M,
+				       QP_CONTEXT_QPC_BYTES_36_DEST_QP_S,
+				       attr->dest_qp_num);
 
 		/* Configure GID index */
 		port_num = rdma_ah_get_port_num(&attr->ah_attr);
-- 
1.9.1

[toc] | [next] | [standalone]


#1742226 — Re: [PATCH V2 for-next 4/8] RDMA/hns: Set mask for destination qp field of qp context assignment

FromDoug Ledford <dledford@redhat.com>
Date2017-09-29 18:10 +0200
SubjectRe: [PATCH V2 for-next 4/8] RDMA/hns: Set mask for destination qp field of qp context assignment
Message-ID<uv61s-8pT-41@gated-at.bofh.it>
In reply to#1742163
On Fri, 2017-09-29 at 23:10 +0800, Wei Hu (Xavier) wrote:
> From: Lijun Ou <oulijun@huawei.com>
> 
> When only set IB_QP_DEST_QPN flag for attr_mask, the operation of
> assigning the dest_qp_num for dest_qp field of qp context is valid.

This commit message reads poorly.  I reworded it.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web