Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742176 > unrolled thread

[PATCH V2 for-next 0/8] Bug fixes & Code improvements in hip06 and hip08 RoCE driver

Back to article view | Back to linux.kernel

Contents

  [PATCH V2 for-next 0/8] Bug fixes & Code improvements in hip06 and hip08 RoCE driver "Wei Hu (Xavier)" <xavier.huwei@huawei.com> - 2017-09-29 16:50 +0200
    [PATCH V2 for-next 7/8] RDMA/hns: Remove unnecessarily calling unregister_inetaddr_notifier function "Wei Hu (Xavier)" <xavier.huwei@huawei.com> - 2017-09-29 16:50 +0200
    Re: [PATCH V2 for-next 0/8] Bug fixes & Code improvements in hip06  and hip08 RoCE driver Doug Ledford <dledford@redhat.com> - 2017-09-29 18:30 +0200

#1742176 — [PATCH V2 for-next 0/8] Bug fixes & Code improvements in hip06 and hip08 RoCE driver

This patch-set introduces some bug fixes and code improvements
for hip06 and hip08 RoCE driver. It includes a patch for fixing
the assign algorithm of qp_attr->max_rd_atomic and
qp_attr->max_dest_rd_atomic, three patches for static check errors,
one for setting attr mask, one for returning RoCE device ah_attr
type when querying qp, one for unregistering inet addr, and the
last one for command queue delay processing in hip08 driver.

Lijun Ou (6):
  RDMA/hns: Modify the value with rd&dest_rd of qp_attr
  RDMA/hns: Factor out the code for checking sdb status into a new
    function
  RDMA/hns: Set mask for destination qp field of qp context assignment
  RDMA/hns: Set rdma_ah_attr type for querying qp
  RDMA/hns: Remove unnecessarily calling unregister_inetaddr_notifier
    function
  RDMA/hns: Replace usleep_range with udelay when checking command
    status

Wei Hu (Xavier) (2):
  RDMA/hns: Add return statement when kzalloc return NULL in
    hns_roce_v1_recreate_lp_qp
  RDMA/hns: Add return statement when checking error in
    hns_roce_v1_mr_free_work_fn

 drivers/infiniband/hw/hns/hns_roce_device.h |   3 +-
 drivers/infiniband/hw/hns/hns_roce_hw_v1.c  | 131 +++++++++++++++++-----------
 drivers/infiniband/hw/hns/hns_roce_hw_v2.c  |   9 +-
 drivers/infiniband/hw/hns/hns_roce_main.c   |  18 ++--
 4 files changed, 96 insertions(+), 65 deletions(-)

-- 
1.9.1

[toc] | [next] | [standalone]

#1742178 — [PATCH V2 for-next 7/8] RDMA/hns: Remove unnecessarily calling unregister_inetaddr_notifier function

From: Lijun Ou <oulijun@huawei.com>

When the driver doesn't call register_inetaddr_notifier function, it need
not call unregister_inetaddr_notifier to unregister inet addr. This patch
fixes it.

Signed-off-by: Lijun Ou <oulijun@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
Signed-off-by: Shaobo Xu <xushaobo2@huawei.com>
---
 drivers/infiniband/hw/hns/hns_roce_device.h | 1 -
 drivers/infiniband/hw/hns/hns_roce_main.c   | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/infiniband/hw/hns/hns_roce_device.h b/drivers/infiniband/hw/hns/hns_roce_device.h
index 4d9d5d7..b314ac0 100644
--- a/drivers/infiniband/hw/hns/hns_roce_device.h
+++ b/drivers/infiniband/hw/hns/hns_roce_device.h
@@ -474,7 +474,6 @@ struct hns_roce_ib_iboe {
 	spinlock_t		lock;
 	struct net_device      *netdevs[HNS_ROCE_MAX_PORTS];
 	struct notifier_block	nb;
-	struct notifier_block	nb_inet;
 	u8			phy_port[HNS_ROCE_MAX_PORTS];
 };
 
diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c
index 6f2d572..3dcb2df 100644
--- a/drivers/infiniband/hw/hns/hns_roce_main.c
+++ b/drivers/infiniband/hw/hns/hns_roce_main.c
@@ -424,7 +424,6 @@ static void hns_roce_unregister_device(struct hns_roce_dev *hr_dev)
 {
 	struct hns_roce_ib_iboe *iboe = &hr_dev->iboe;
 
-	unregister_inetaddr_notifier(&iboe->nb_inet);
 	unregister_netdevice_notifier(&iboe->nb);
 	ib_unregister_device(&hr_dev->ib_dev);
 }
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1742233 — Re: [PATCH V2 for-next 0/8] Bug fixes & Code improvements in hip06 and hip08 RoCE driver

On Fri, 2017-09-29 at 23:10 +0800, Wei Hu (Xavier) wrote:
> This patch-set introduces some bug fixes and code improvements
> for hip06 and hip08 RoCE driver. It includes a patch for fixing
> the assign algorithm of qp_attr->max_rd_atomic and
> qp_attr->max_dest_rd_atomic, three patches for static check errors,
> one for setting attr mask, one for returning RoCE device ah_attr
> type when querying qp, one for unregistering inet addr, and the
> last one for command queue delay processing in hip08 driver.
> 
> Lijun Ou (6):
>   RDMA/hns: Modify the value with rd&dest_rd of qp_attr
>   RDMA/hns: Factor out the code for checking sdb status into a new
>     function
>   RDMA/hns: Set mask for destination qp field of qp context
> assignment
>   RDMA/hns: Set rdma_ah_attr type for querying qp
>   RDMA/hns: Remove unnecessarily calling unregister_inetaddr_notifier
>     function
>   RDMA/hns: Replace usleep_range with udelay when checking command
>     status
> 
> Wei Hu (Xavier) (2):
>   RDMA/hns: Add return statement when kzalloc return NULL in
>     hns_roce_v1_recreate_lp_qp
>   RDMA/hns: Add return statement when checking error in
>     hns_roce_v1_mr_free_work_fn
> 
>  drivers/infiniband/hw/hns/hns_roce_device.h |   3 +-
>  drivers/infiniband/hw/hns/hns_roce_hw_v1.c  | 131 +++++++++++++++++-
> ----------
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c  |   9 +-
>  drivers/infiniband/hw/hns/hns_roce_main.c   |  18 ++--
>  4 files changed, 96 insertions(+), 65 deletions(-)

Hi Wei,

I've taken this series into for-next.  However, a lot of the commit
subjects needed fixing up (and a few of the commit logs as well for
general readability).  Please don't use such long subjects as they
interrupt the output of git log --oneline when using the kernel
standard 12 digit hex output for commit hashes.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web