Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1742136 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-09-29 16:00 +0200 |
| Last post | 2017-09-29 17:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH][rdma-next] RDMA/hns: remove redundant assignment to variable j Colin King <colin.king@canonical.com> - 2017-09-29 16:00 +0200
Re: [PATCH][rdma-next] RDMA/hns: remove redundant assignment to variable j Doug Ledford <dledford@redhat.com> - 2017-09-29 17:30 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-09-29 16:00 +0200 |
| Subject | [PATCH][rdma-next] RDMA/hns: remove redundant assignment to variable j |
| Message-ID | <uv3ZF-6RY-17@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Variable j is being assigned to loop_j and then later being
assigned to a new value in for loops. The first initialization
is therefore redundant and can be removed.
Cleans up clang warning:
warning: Value stored to 'j' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/infiniband/hw/hns/hns_roce_mr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c
index 7e6ce76b32df..452136d98ad5 100644
--- a/drivers/infiniband/hw/hns/hns_roce_mr.c
+++ b/drivers/infiniband/hw/hns/hns_roce_mr.c
@@ -272,7 +272,6 @@ static void hns_roce_loop_free(struct hns_roce_dev *hr_dev,
mhop_num = hr_dev->caps.pbl_hop_num;
i = loop_i;
- j = loop_j;
if (mhop_num == 3 && err_loop_index == 2) {
for (; i >= 0; i--) {
dma_free_coherent(dev, pbl_bt_sz, mr->pbl_bt_l1[i],
--
2.14.1
[toc] | [next] | [standalone]
| From | Doug Ledford <dledford@redhat.com> |
|---|---|
| Date | 2017-09-29 17:30 +0200 |
| Subject | Re: [PATCH][rdma-next] RDMA/hns: remove redundant assignment to variable j |
| Message-ID | <uv5oJ-7Wg-3@gated-at.bofh.it> |
| In reply to | #1742136 |
On Fri, 2017-09-29 at 14:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable j is being assigned to loop_j and then later being
> assigned to a new value in for loops. The first initialization
> is therefore redundant and can be removed.
>
> Cleans up clang warning:
> warning: Value stored to 'j' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web