Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1741078 > unrolled thread

[PATCH] objtool: Skip unreachable warnings for GCC 4.4 and older

Started byJosh Poimboeuf <jpoimboe@redhat.com>
First post2017-09-28 00:40 +0200
Last post2017-09-28 07:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] objtool: Skip unreachable warnings for GCC 4.4 and older Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-28 00:40 +0200
    [tip:core/urgent] objtool: Skip unreachable warnings for GCC 4.4  and older tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2017-09-28 07:40 +0200

#1741078 — [PATCH] objtool: Skip unreachable warnings for GCC 4.4 and older

FromJosh Poimboeuf <jpoimboe@redhat.com>
Date2017-09-28 00:40 +0200
Subject[PATCH] objtool: Skip unreachable warnings for GCC 4.4 and older
Message-ID<uut9M-AW-19@gated-at.bofh.it>
The kbuild bot occasionally reports warnings like:

  drivers/scsi/pcmcia/aha152x_core.o: warning: objtool: seldo_run()+0x130: unreachable instruction

These warnings are always with GCC 4.4.  That version of GCC sometimes
places unreachable instructions after calls to noreturn functions.

The unreachable warnings aren't very important anyway.  Just ignore them
for old versions of GCC.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
 scripts/Makefile.build | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 2e3a10e79ca9..061d0c3a420a 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -265,6 +265,8 @@ objtool_args += --no-fp
 endif
 ifdef CONFIG_GCOV_KERNEL
 objtool_args += --no-unreachable
+else
+objtool_args += $(call cc-ifversion, -lt, 0405, --no-unreachable)
 endif
 
 # 'OBJECT_FILES_NON_STANDARD := y': skip objtool checking for a directory
-- 
2.13.5

[toc] | [next] | [standalone]


#1741205 — [tip:core/urgent] objtool: Skip unreachable warnings for GCC 4.4 and older

Fromtip-bot for Josh Poimboeuf <tipbot@zytor.com>
Date2017-09-28 07:40 +0200
Subject[tip:core/urgent] objtool: Skip unreachable warnings for GCC 4.4 and older
Message-ID<uuzIe-4Lq-21@gated-at.bofh.it>
In reply to#1741078
Commit-ID:  da541b20021c781f8b65492eeaee824e729599eb
Gitweb:     https://git.kernel.org/tip/da541b20021c781f8b65492eeaee824e729599eb
Author:     Josh Poimboeuf <jpoimboe@redhat.com>
AuthorDate: Wed, 27 Sep 2017 17:34:23 -0500
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 28 Sep 2017 07:23:02 +0200

objtool: Skip unreachable warnings for GCC 4.4 and older

The kbuild bot occasionally reports warnings like:

  drivers/scsi/pcmcia/aha152x_core.o: warning: objtool: seldo_run()+0x130: unreachable instruction

These warnings are always with GCC 4.4.  That version of GCC sometimes
places unreachable instructions after calls to noreturn functions.

The unreachable warnings aren't very important anyway.  Just ignore them
for old versions of GCC.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/bc89b807d965b98ec18a0bb94f96a594bd58f2f2.1506551639.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 scripts/Makefile.build | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 2e3a10e7..061d0c3 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -265,6 +265,8 @@ objtool_args += --no-fp
 endif
 ifdef CONFIG_GCOV_KERNEL
 objtool_args += --no-unreachable
+else
+objtool_args += $(call cc-ifversion, -lt, 0405, --no-unreachable)
 endif
 
 # 'OBJECT_FILES_NON_STANDARD := y': skip objtool checking for a directory

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web