Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1740974 > unrolled thread
| Started by | Andy Lutomirski <luto@kernel.org> |
|---|---|
| First post | 2017-09-27 21:50 +0200 |
| Last post | 2017-09-27 23:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 04/12] platform/x86: dell-smbios: Switch to a WMI-ACPI interface Andy Lutomirski <luto@kernel.org> - 2017-09-27 21:50 +0200
RE: [PATCH 04/12] platform/x86: dell-smbios: Switch to a WMI-ACPI interface <Mario.Limonciello@dell.com> - 2017-09-27 23:20 +0200
| From | Andy Lutomirski <luto@kernel.org> |
|---|---|
| Date | 2017-09-27 21:50 +0200 |
| Subject | Re: [PATCH 04/12] platform/x86: dell-smbios: Switch to a WMI-ACPI interface |
| Message-ID | <uuqvf-7kB-7@gated-at.bofh.it> |
On 09/21/2017 06:57 AM, Mario Limonciello wrote: > The driver currently uses an SMI interface which grants direct access > to physical memory to the platform via a pointer. > > Changing this to operate over WMI-ACPI will use an ACPI OperationRegion > for a buffer of data storage when platform calls are performed. > > This is a safer approach to use in kernel drivers as the platform will > only have access to that OperationRegion. > > As a result, this change removes the dependency on this driver on the > dcdbas kernel module. > > + status = wmi_evaluate_method(DELL_WMI_SMBIOS_GUID, > + 0, 1, &input, &output); It might be nice to add a wmidev_method_evaluate(struct wmi_device *wdev, ...) function to better aligh with the new world order. The only reason I didn't do it is that I didn't convert any drivers that wanted it.
[toc] | [next] | [standalone]
| From | <Mario.Limonciello@dell.com> |
|---|---|
| Date | 2017-09-27 23:20 +0200 |
| Message-ID | <uurUm-8kS-3@gated-at.bofh.it> |
| In reply to | #1740974 |
> -----Original Message----- > From: Andy Lutomirski [mailto:luto@kernel.org] > Sent: Wednesday, September 27, 2017 3:48 PM > To: Limonciello, Mario <Mario_Limonciello@Dell.com>; dvhart@infradead.org > Cc: LKML <linux-kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org; > quasisec@google.com; pali.rohar@gmail.com > Subject: Re: [PATCH 04/12] platform/x86: dell-smbios: Switch to a WMI-ACPI > interface > > On 09/21/2017 06:57 AM, Mario Limonciello wrote: > > The driver currently uses an SMI interface which grants direct access > > to physical memory to the platform via a pointer. > > > > Changing this to operate over WMI-ACPI will use an ACPI OperationRegion > > for a buffer of data storage when platform calls are performed. > > > > This is a safer approach to use in kernel drivers as the platform will > > only have access to that OperationRegion. > > > > As a result, this change removes the dependency on this driver on the > > dcdbas kernel module. > > > > > + status = wmi_evaluate_method(DELL_WMI_SMBIOS_GUID, > > + 0, 1, &input, &output); > > It might be nice to add a wmidev_method_evaluate(struct wmi_device > *wdev, ...) function to better aligh with the new world order. The only > reason I didn't do it is that I didn't convert any drivers that wanted it. Great idea. I'll apply that for my next patch revision. I'm not about to convert all the existing drivers, but once all existing drivers conceptualize using the bus, storing a wmi_device pointer internally,and using this the old wmi_evaluate_method can be dropped too.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web