Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1740694 > unrolled thread

Re: unneeded internal declaration

Started byPaolo Bonzini <pbonzini@redhat.com>
First post2017-09-27 15:00 +0200
Last post2017-09-27 15:00 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: unneeded internal declaration Paolo Bonzini <pbonzini@redhat.com> - 2017-09-27 15:00 +0200

#1740694 — Re: unneeded internal declaration

FromPaolo Bonzini <pbonzini@redhat.com>
Date2017-09-27 15:00 +0200
SubjectRe: unneeded internal declaration
Message-ID<uuk6v-2Hs-13@gated-at.bofh.it>
On 27/09/2017 14:39, Avi Ghosh wrote:
> Can someone remove me form this thread. I don’t know why I’m on it.

Because you are avi@redhat.com, which belonged to Avi Kivity before you.

In any case, no one can "remove you from this thread".  Everyone
involved would have to remember to remove you from each and every
message that is sent on this thread.  It's much simpler if you use the
"Ignore thread" or "Mute thread" functionality of your mail client.

Paolo

> On Mon, Sep 25, 2017 at 10:07 PM Nick Desaulniers
> <nick.desaulniers@gmail.com <mailto:nick.desaulniers@gmail.com>> wrote:
> 
>     today I noticed I was getting the warning:
> 
>     arch/x86/kvm/vmx.c:64:32: warning: variable 'vmx_cpu_id' is not needed
>     and will not be emitted [-Wunneeded-internal-declaration]
> 
>     seems like this was added in commit: e9bda3b3d0ce7 "KVM: VMX:
>     Auto-load on CPUs with VMX"
> 
>     seems like other call sites of the MODULE_DEVICE_TABLE typically get
>     added to an id_table of various driver structs.  Should that be the
>     case here, or would a `__unused` modifier be a way forward (if so,
>     please confirm, would be a good first bug for a friend)?
> 

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web