Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1740877 > unrolled thread
| Started by | Hoang Tran <tranviethoang.vn@gmail.com> |
|---|---|
| First post | 2017-09-27 18:40 +0200 |
| Last post | 2017-09-29 10:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH net-next] tcp: fix under-evaluated ssthresh in TCP Vegas Hoang Tran <tranviethoang.vn@gmail.com> - 2017-09-27 18:40 +0200
Re: [PATCH net-next] tcp: fix under-evaluated ssthresh in TCP Vegas David Miller <davem@davemloft.net> - 2017-09-29 10:20 +0200
| From | Hoang Tran <tranviethoang.vn@gmail.com> |
|---|---|
| Date | 2017-09-27 18:40 +0200 |
| Subject | [PATCH net-next] tcp: fix under-evaluated ssthresh in TCP Vegas |
| Message-ID | <uunxo-5yo-11@gated-at.bofh.it> |
With the commit 76174004a0f19785 (tcp: do not slow start when cwnd equals
ssthresh), the comparison to the reduced cwnd in tcp_vegas_ssthresh() would
under-evaluate the ssthresh.
Signed-off-by: Hoang Tran <hoang.tran@uclouvain.be>
---
net/ipv4/tcp_vegas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_vegas.c b/net/ipv4/tcp_vegas.c
index 218cfcc..ee113ff 100644
--- a/net/ipv4/tcp_vegas.c
+++ b/net/ipv4/tcp_vegas.c
@@ -158,7 +158,7 @@ EXPORT_SYMBOL_GPL(tcp_vegas_cwnd_event);
static inline u32 tcp_vegas_ssthresh(struct tcp_sock *tp)
{
- return min(tp->snd_ssthresh, tp->snd_cwnd-1);
+ return min(tp->snd_ssthresh, tp->snd_cwnd);
}
static void tcp_vegas_cong_avoid(struct sock *sk, u32 ack, u32 acked)
--
2.7.4
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-09-29 10:20 +0200 |
| Message-ID | <uuYGB-3GT-3@gated-at.bofh.it> |
| In reply to | #1740877 |
From: Hoang Tran <tranviethoang.vn@gmail.com> Date: Wed, 27 Sep 2017 18:30:58 +0200 > With the commit 76174004a0f19785 (tcp: do not slow start when cwnd equals > ssthresh), the comparison to the reduced cwnd in tcp_vegas_ssthresh() would > under-evaluate the ssthresh. > > Signed-off-by: Hoang Tran <hoang.tran@uclouvain.be> Applied, thank you.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web