Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1741228 > unrolled thread
| Started by | Ingo Molnar <mingo@kernel.org> |
|---|---|
| First post | 2017-09-28 09:30 +0200 |
| Last post | 2017-09-29 08:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH -tip v3 6/7] kprobes/x86: Remove disable_irq from ftrace-based/optimized kprobe Ingo Molnar <mingo@kernel.org> - 2017-09-28 09:30 +0200
Re: [PATCH -tip v3 6/7] kprobes/x86: Remove disable_irq from ftrace-based/optimized kprobe Masami Hiramatsu <mhiramat@kernel.org> - 2017-09-29 08:50 +0200
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2017-09-28 09:30 +0200 |
| Subject | Re: [PATCH -tip v3 6/7] kprobes/x86: Remove disable_irq from ftrace-based/optimized kprobe |
| Message-ID | <uuBqF-5Tq-3@gated-at.bofh.it> |
* Masami Hiramatsu <mhiramat@kernel.org> wrote: > Actually kprobes doesn't need to disable irq if it is > called from ftrace/jump trampoline code because > Documentation/kprobes.txt says > > ----- > Probe handlers are run with preemption disabled. Depending on the > architecture and optimization state, handlers may also run with > interrupts disabled (e.g., kretprobe handlers and optimized kprobe > handlers run without interrupt disabled on x86/x86-64). > ----- > > So let's remove irq disabling from those handlers. > - local_irq_save(flags); The title is talking about disable_irq(): kprobes/x86: Remove disable_irq from ftrace-based/optimized kprobe ... but the patch is actually using local_irq_save(), which is an entirely different thing! You probably wanted to say: kprobes/x86: Remove irq disabling from ftrace-based/optimized kprobes Also note the plural of 'kprobes' when we refer to them as a generic thing. I fixed the title, but _please_ read changelogs more carefully before sending them. Thanks, Ingo
[toc] | [next] | [standalone]
| From | Masami Hiramatsu <mhiramat@kernel.org> |
|---|---|
| Date | 2017-09-29 08:50 +0200 |
| Message-ID | <uuXhv-2Ft-5@gated-at.bofh.it> |
| In reply to | #1741228 |
On Thu, 28 Sep 2017 09:25:41 +0200 Ingo Molnar <mingo@kernel.org> wrote: > > * Masami Hiramatsu <mhiramat@kernel.org> wrote: > > > Actually kprobes doesn't need to disable irq if it is > > called from ftrace/jump trampoline code because > > Documentation/kprobes.txt says > > > > ----- > > Probe handlers are run with preemption disabled. Depending on the > > architecture and optimization state, handlers may also run with > > interrupts disabled (e.g., kretprobe handlers and optimized kprobe > > handlers run without interrupt disabled on x86/x86-64). > > ----- > > > > So let's remove irq disabling from those handlers. > > > - local_irq_save(flags); > > The title is talking about disable_irq(): > > kprobes/x86: Remove disable_irq from ftrace-based/optimized kprobe > > ... but the patch is actually using local_irq_save(), which is an entirely > different thing! You probably wanted to say: > > kprobes/x86: Remove irq disabling from ftrace-based/optimized kprobes Correct! That's my mistake. thanks! > > Also note the plural of 'kprobes' when we refer to them as a generic thing. > > I fixed the title, but _please_ read changelogs more carefully before sending > them. Thank you again, > > Thanks, > > Ingo -- Masami Hiramatsu <mhiramat@kernel.org>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web