Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1741909 > unrolled thread
| Started by | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| First post | 2017-09-29 05:30 +0200 |
| Last post | 2017-09-29 10:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/7] regulator: axp20x: Fix poly-phase bit offset for AXP803 DCDC5/6 Chen-Yu Tsai <wens@csie.org> - 2017-09-29 05:30 +0200
Re: [PATCH 1/7] regulator: axp20x: Fix poly-phase bit offset for AXP803 DCDC5/6 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-29 10:40 +0200
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-09-29 05:30 +0200 |
| Subject | [PATCH 1/7] regulator: axp20x: Fix poly-phase bit offset for AXP803 DCDC5/6 |
| Message-ID | <uuU9X-NR-11@gated-at.bofh.it> |
The bit offset used to check if DCDC5 and DCDC6 are tied together in
poly-phase output is wrong. It was checking against a reserved bit,
which is always false.
In reality, neither the reference design layout nor actually produced
boards tie these two buck regulators together. But we should still
fix it, just in case.
Fixes: 1dbe0ccb0631 ("regulator: axp20x-regulator: add support for AXP803")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Tested-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
drivers/regulator/axp20x-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index f18b36dd57dd..376a99b7cf5d 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -590,7 +590,7 @@ static bool axp20x_is_polyphase_slave(struct axp20x_dev *axp20x, int id)
case AXP803_DCDC3:
return !!(reg & BIT(6));
case AXP803_DCDC6:
- return !!(reg & BIT(7));
+ return !!(reg & BIT(5));
}
break;
--
2.14.2
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-09-29 10:40 +0200 |
| Subject | Re: [PATCH 1/7] regulator: axp20x: Fix poly-phase bit offset for AXP803 DCDC5/6 |
| Message-ID | <uuYZY-3Nm-23@gated-at.bofh.it> |
| In reply to | #1741909 |
[Multipart message — attachments visible in raw view] — view raw
On Fri, Sep 29, 2017 at 03:25:08AM +0000, Chen-Yu Tsai wrote:
> The bit offset used to check if DCDC5 and DCDC6 are tied together in
> poly-phase output is wrong. It was checking against a reserved bit,
> which is always false.
>
> In reality, neither the reference design layout nor actually produced
> boards tie these two buck regulators together. But we should still
> fix it, just in case.
>
> Fixes: 1dbe0ccb0631 ("regulator: axp20x-regulator: add support for AXP803")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> Tested-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web