Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1741631 > unrolled thread

Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add  other KSZ switch drivers. Pavel Machek <pavel@ucw.cz> - 2017-09-28 17:30 +0200

#1741631 — Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.

[Multipart message — attachments visible in raw view] — view raw

Hi!

> > >  drivers/net/dsa/microchip/Makefile     |    2 +-
> > >  drivers/net/dsa/microchip/ksz9477.c    | 1317
> > ++++++++++++++++++++++++++++++++
> > 
> > We already have ksz_9477_reg.h. So should this be ksz_9477.c for
> > consistency?
> 
> The product name is KSZ9477 and other switches are also like KSZ####,
> so I would prefer to have no separation between KSZ and the product
> number.  I think the file ksz_9477_reg.h was named that way because
> the other files were named ksz_common.c and ksz_spi.c.  If need to
> we can change the file name.

I don't care either way, but please make it consistent.

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web