Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1740933 > unrolled thread

Re: [PATCH] ARC: reset: remove the misleading v1 suffix all over

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] ARC: reset: remove the misleading v1 suffix all over Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-09-27 20:10 +0200
    Re: [PATCH] ARC: reset: remove the misleading v1 suffix all over Philipp Zabel <p.zabel@pengutronix.de> - 2017-09-28 10:30 +0200

#1740933 — Re: [PATCH] ARC: reset: remove the misleading v1 suffix all over

Hi Philipp,

On 09/14/2017 03:44 AM, Philipp Zabel wrote:
> On Mon, 2017-09-11 at 09:33 -0700, Vineet Gupta wrote:
>> On 09/11/2017 03:28 AM, Philipp Zabel wrote:
>>> Hi Vineet,
>>>
>>> [added Eugeniy to Cc]
>>>
>>> On Thu, 2017-08-31 at 11:06 -0700, Vineet Gupta wrote:
>>>> There is no plan yet to do a v2 board. And even if we were to do
>>>> it
>>>> only some IPs would actually change, so it be best to add suffixes
>>>> at
>>>> that point, not now !
>>>>
>>>> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>>>> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
>>>> ---
>>>> P.S. Philip, if you and Eugeniy are OK, can this be please
>>>> squashed
>>>> with his original patch since it has not yet been merged etc.
>>>
>>> This had been merged into arm-soc already, and by now is merged into
>>> mainline. We could try to queue this as a fix for 4.14.
>>
>> OK - do you want a respin ?
>>
>>>
>>> [...]
>>>> --- a/drivers/reset/Kconfig
>>>> +++ b/drivers/reset/Kconfig
>>>> @@ -34,11 +34,11 @@ config RESET_BERLIN
>>>>    	help
>>>>    	  This enables the reset controller driver for Marvell
>>>> Berlin
>>>> SoCs.
>>>>    
>>>> -config RESET_HSDK_V1
>>>> -	bool "HSDK v1 Reset Driver"
>>>> +config RESET_SNPS_HSDK
>>>
>>> I suggest to drop the _SNPS part, we don't do it for the other
>>> drivers
>>> either, and so far I'm not afraid of conflicts with other reset
>>> controllers that may be called HSDK.
>>
>> It was not so much about namespace conflict but calling out that this
>> is SNPS part !
>> But I'm fine with what you suggest, since the updated menu string does
>> have it.
> 
> Ok, thanks. No need for a respin, I can fix it up as I apply it.


How/when do you plan to get his merged. Perhaps I can work with a non-mutable 
branch from you to base my changes off of ?

Thx,
-Vineet

[toc] | [next] | [standalone]

#1741279

Hi Vineet,

On Wed, 2017-09-27 at 11:07 -0700, Vineet Gupta wrote:
[...]
> How/when do you plan to get his merged. Perhaps I can work with a non-
> mutable branch from you to base my changes off of ?

I have sent a pull request [1] for this stable tag:

git://git.pengutronix.de/git/pza/linux.git tags/reset-fixes-for-4.14

[1] https://patchwork.ozlabs.org/patch/817004/

regards
Philipp

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web