Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1741213 > unrolled thread

Script to do smart sparse diffs (was Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat)

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Script to do smart sparse diffs (was Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat) Michael Ellerman <mpe@ellerman.id.au> - 2017-09-28 08:20 +0200

#1741213 — Script to do smart sparse diffs (was Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat)

Christoph Hellwig <hch@infradead.org> writes:

> On Mon, Sep 25, 2017 at 06:37:28PM -0700, Linus Torvalds wrote:
>> Pulled and pushed out, but I'd like to note that sparse would have
>> caught this. Except we are so far away from being sparse-clean that
>> nobody runs it.
>
> I tend to run sparse over the nvme code before sending pull request
> every time.  But it's a fairly new codebase, so it it actually
> is clean.  I wish we'd just default to running sparse at some point
> so people have to clean their shit up, as it catches a lot of
> useful things.  But maybe for the default we want to tune it down
> a bit (e.g. don't warn about missing statics by default, skip
> the lock imbalance checks which while often useful also generate
> tons of false positives).

Daniel (++Cc) wrote a script a while back that can do a "smart" diff of
the sparse output from two builds. Roughly it sorts the output
(important when using make -j) and does some other munging to try and
give you a minimal diff across runs.

That allows you to check if a commit added new sparse warnings without
the build being clean at the beginning.

Anyway it's here if anyone wants to try it:

  https://github.com/daxtens/smart-sparse-diff


cheers

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web