Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1740271 > unrolled thread

[PATCH 0/3] libnvdimm: fix physical address disclosure

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] libnvdimm: fix physical address disclosure Dan Williams <dan.j.williams@intel.com> - 2017-09-27 01:10 +0200
    [PATCH 3/3] libnvdimm,  pfn: make 'resource' attribute only readable by root Dan Williams <dan.j.williams@intel.com> - 2017-09-27 01:10 +0200

#1740271 — [PATCH 0/3] libnvdimm: fix physical address disclosure

Physical address information should be restricted to root. This is
consistent with the policy of /proc/iomem and /sys/firmware/acpi/tables.

---

Dan Williams (3):
      libnvdimm, region : make 'resource' attribute only readable by root
      libnvdimm, namespace: make 'resource' attribute only readable by root
      libnvdimm, pfn: make 'resource' attribute only readable by root


 drivers/nvdimm/namespace_devs.c |    2 +-
 drivers/nvdimm/pfn_devs.c       |    8 ++++++++
 drivers/nvdimm/region_devs.c    |    8 ++++++--
 3 files changed, 15 insertions(+), 3 deletions(-)

[toc] | [next] | [standalone]

#1740273 — [PATCH 3/3] libnvdimm, pfn: make 'resource' attribute only readable by root

For the same reason that /proc/iomem returns 0's for non-root readers
and acpi tables are root-only, make the 'resource' attribute for pfn
devices only readable by root. Otherwise we disclose physical address
information.

Fixes: f6ed58c70d14 ("libnvdimm, pfn: 'resource'-address and 'size'...")
Cc: <stable@vger.kernel.org>
Reported-by: Dave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 drivers/nvdimm/pfn_devs.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c
index 9576c444f0ab..65cc171c721d 100644
--- a/drivers/nvdimm/pfn_devs.c
+++ b/drivers/nvdimm/pfn_devs.c
@@ -282,8 +282,16 @@ static struct attribute *nd_pfn_attributes[] = {
 	NULL,
 };
 
+static umode_t pfn_visible(struct kobject *kobj, struct attribute *a, int n)
+{
+	if (a == &dev_attr_resource.attr)
+		return 0400;
+	return a->mode;
+}
+
 struct attribute_group nd_pfn_attribute_group = {
 	.attrs = nd_pfn_attributes,
+	.is_visible = pfn_visible,
 };
 
 static const struct attribute_group *nd_pfn_attribute_groups[] = {

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web