Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1739383 > unrolled thread

[PATCH] PM / OPP: Move the OPP directory out of power/

Back to article view | Back to linux.kernel

Contents

  [PATCH] PM / OPP: Move the OPP directory out of power/ Viresh Kumar <viresh.kumar@linaro.org> - 2017-09-26 02:10 +0200
    Re: [PATCH] PM / OPP: Move the OPP directory out of power/ Sekhar Nori <nsekhar@ti.com> - 2017-09-26 07:20 +0200
      Re: [PATCH] PM / OPP: Move the OPP directory out of power/ Viresh Kumar <viresh.kumar@linaro.org> - 2017-09-27 00:10 +0200

#1739383 — [PATCH] PM / OPP: Move the OPP directory out of power/

The drivers/base/power/ directory is special and contains code related
to power management core like system suspend/resume, hibernation, etc.
It was fine to keep the OPP code inside it when we had just one file for
it, but it is growing now and already has a directory for itself.

Lets move it directly under drivers/ directory, just like cpufreq and
cpuidle.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/Makefile                       | 1 +
 drivers/base/power/Makefile            | 1 -
 drivers/{base/power => }/opp/Makefile  | 0
 drivers/{base/power => }/opp/core.c    | 0
 drivers/{base/power => }/opp/cpu.c     | 0
 drivers/{base/power => }/opp/debugfs.c | 0
 drivers/{base/power => }/opp/of.c      | 0
 drivers/{base/power => }/opp/opp.h     | 0
 8 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/{base/power => }/opp/Makefile (100%)
 rename drivers/{base/power => }/opp/core.c (100%)
 rename drivers/{base/power => }/opp/cpu.c (100%)
 rename drivers/{base/power => }/opp/debugfs.c (100%)
 rename drivers/{base/power => }/opp/of.c (100%)
 rename drivers/{base/power => }/opp/opp.h (100%)

diff --git a/drivers/Makefile b/drivers/Makefile
index d90fdc413648..dd718a3007e9 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -125,6 +125,7 @@ obj-$(CONFIG_ACCESSIBILITY)	+= accessibility/
 obj-$(CONFIG_ISDN)		+= isdn/
 obj-$(CONFIG_EDAC)		+= edac/
 obj-$(CONFIG_EISA)		+= eisa/
+obj-$(CONFIG_PM_OPP)		+= opp/
 obj-$(CONFIG_CPU_FREQ)		+= cpufreq/
 obj-$(CONFIG_CPU_IDLE)		+= cpuidle/
 obj-y				+= mmc/
diff --git a/drivers/base/power/Makefile b/drivers/base/power/Makefile
index 5998c53280f5..73a1cffc0a5f 100644
--- a/drivers/base/power/Makefile
+++ b/drivers/base/power/Makefile
@@ -1,7 +1,6 @@
 obj-$(CONFIG_PM)	+= sysfs.o generic_ops.o common.o qos.o runtime.o wakeirq.o
 obj-$(CONFIG_PM_SLEEP)	+= main.o wakeup.o
 obj-$(CONFIG_PM_TRACE_RTC)	+= trace.o
-obj-$(CONFIG_PM_OPP)	+= opp/
 obj-$(CONFIG_PM_GENERIC_DOMAINS)	+=  domain.o domain_governor.o
 obj-$(CONFIG_HAVE_CLK)	+= clock_ops.o
 
diff --git a/drivers/base/power/opp/Makefile b/drivers/opp/Makefile
similarity index 100%
rename from drivers/base/power/opp/Makefile
rename to drivers/opp/Makefile
diff --git a/drivers/base/power/opp/core.c b/drivers/opp/core.c
similarity index 100%
rename from drivers/base/power/opp/core.c
rename to drivers/opp/core.c
diff --git a/drivers/base/power/opp/cpu.c b/drivers/opp/cpu.c
similarity index 100%
rename from drivers/base/power/opp/cpu.c
rename to drivers/opp/cpu.c
diff --git a/drivers/base/power/opp/debugfs.c b/drivers/opp/debugfs.c
similarity index 100%
rename from drivers/base/power/opp/debugfs.c
rename to drivers/opp/debugfs.c
diff --git a/drivers/base/power/opp/of.c b/drivers/opp/of.c
similarity index 100%
rename from drivers/base/power/opp/of.c
rename to drivers/opp/of.c
diff --git a/drivers/base/power/opp/opp.h b/drivers/opp/opp.h
similarity index 100%
rename from drivers/base/power/opp/opp.h
rename to drivers/opp/opp.h
-- 
2.7.4

[toc] | [next] | [standalone]

#1739514

On Tuesday 26 September 2017 05:35 AM, Viresh Kumar wrote:
> The drivers/base/power/ directory is special and contains code related
> to power management core like system suspend/resume, hibernation, etc.
> It was fine to keep the OPP code inside it when we had just one file for
> it, but it is growing now and already has a directory for itself.
> 
> Lets move it directly under drivers/ directory, just like cpufreq and
> cpuidle.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/Makefile                       | 1 +
>  drivers/base/power/Makefile            | 1 -
>  drivers/{base/power => }/opp/Makefile  | 0
>  drivers/{base/power => }/opp/core.c    | 0
>  drivers/{base/power => }/opp/cpu.c     | 0
>  drivers/{base/power => }/opp/debugfs.c | 0
>  drivers/{base/power => }/opp/of.c      | 0
>  drivers/{base/power => }/opp/opp.h     | 0
>  8 files changed, 1 insertion(+), 1 deletion(-)
>  rename drivers/{base/power => }/opp/Makefile (100%)
>  rename drivers/{base/power => }/opp/core.c (100%)
>  rename drivers/{base/power => }/opp/cpu.c (100%)
>  rename drivers/{base/power => }/opp/debugfs.c (100%)
>  rename drivers/{base/power => }/opp/of.c (100%)
>  rename drivers/{base/power => }/opp/opp.h (100%)

MAINTAINERS needs update too. Also, shouldn't PM_OPP now find a home in
drivers/opp/Kconfig?

Thanks,
Sekhar

[toc] | [prev] | [next] | [standalone]

#1740245

On 25 September 2017 at 22:11, Sekhar Nori <nsekhar@ti.com> wrote:
> On Tuesday 26 September 2017 05:35 AM, Viresh Kumar wrote:

> MAINTAINERS needs update too.

Right and that's where it all started to begin with :)

> Also, shouldn't PM_OPP now find a home in
> drivers/opp/Kconfig?

Yeah, I wasn't sure if I should create a Kconfig to just keep that, but perhaps
that is the only sane thing we can do.

--
viresh

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web