Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1734166 > unrolled thread

[PATCH] mm: Fix typo in VM_MPX definition

Started by"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
First post2017-09-18 16:10 +0200
Last post2017-09-26 21:30 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] mm: Fix typo in VM_MPX definition "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-09-18 16:10 +0200
    Re: [PATCH] mm: Fix typo in VM_MPX definition Rik van Riel <riel@redhat.com> - 2017-09-18 16:40 +0200
    Re: [PATCH] mm: Fix typo in VM_MPX definition Kyle Huey <me@kylehuey.com> - 2017-09-26 21:30 +0200

#1734166 — [PATCH] mm: Fix typo in VM_MPX definition

From"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Date2017-09-18 16:10 +0200
Subject[PATCH] mm: Fix typo in VM_MPX definition
Message-ID<ur4Uh-7j9-13@gated-at.bofh.it>
There's typo in recent change of VM_MPX definition. We want it to be
VM_HIGH_ARCH_4, not VM_HIGH_ARCH_BIT_4.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Fixes: df3735c5b40f ("x86,mpx: make mpx depend on x86-64 to free up VMA flag")
Cc: Rik van Riel <riel@redhat.com>
Cc: Dave Hansen <dave.hansen@intel.com>
---
 include/linux/mm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index f8c10d336e42..065d99deb847 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -240,7 +240,7 @@ extern unsigned int kobjsize(const void *objp);
 
 #if defined(CONFIG_X86_INTEL_MPX)
 /* MPX specific bounds table or bounds directory */
-# define VM_MPX		VM_HIGH_ARCH_BIT_4
+# define VM_MPX		VM_HIGH_ARCH_4
 #else
 # define VM_MPX		VM_NONE
 #endif
-- 
2.14.1

[toc] | [next] | [standalone]


#1734190

FromRik van Riel <riel@redhat.com>
Date2017-09-18 16:40 +0200
Message-ID<ur5nk-7uE-19@gated-at.bofh.it>
In reply to#1734166
On Mon, 2017-09-18 at 17:02 +0300, Kirill A. Shutemov wrote:
> There's typo in recent change of VM_MPX definition. We want it to be
> VM_HIGH_ARCH_4, not VM_HIGH_ARCH_BIT_4.

Ugh, indeed! Good catch!

> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Fixes: df3735c5b40f ("x86,mpx: make mpx depend on x86-64 to free up
> VMA flag")
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Dave Hansen <dave.hansen@intel.com>

Reviewed-by: Rik van Riel <riel@redhat.com>

[toc] | [prev] | [next] | [standalone]


#1740151

FromKyle Huey <me@kylehuey.com>
Date2017-09-26 21:30 +0200
Message-ID<uu3Im-pY-15@gated-at.bofh.it>
In reply to#1734166
Could we get this patch into the next 4.14 rc too?  This "typo" causes a bunch
of sections in /proc/N/maps to be incorrectly labelled [mpx] which confuses rr.
We could probably work around if it we had to but doing this right is trivial.

Thanks,

- Kyle

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web