Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1740148 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-09-26 21:30 +0200 |
| Last post | 2017-09-28 04:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] scsi: libsas: remove unused variable sas_ha Colin King <colin.king@canonical.com> - 2017-09-26 21:30 +0200
Re: [PATCH] scsi: libsas: remove unused variable sas_ha John Garry <john.garry@huawei.com> - 2017-09-27 00:40 +0200
Re: [PATCH] scsi: libsas: remove unused variable sas_ha "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-09-28 04:00 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-09-26 21:30 +0200 |
| Subject | [PATCH] scsi: libsas: remove unused variable sas_ha |
| Message-ID | <uu3Il-pY-1@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Remove unused variable sas_ha to clean up build warning
"unused variable ‘sas_ha’ [-Wunused-variable]"
Fixes: 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 29d6cb39299c..9e2990268f00 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -1046,7 +1046,6 @@ static void hisi_sas_rescan_topology(struct hisi_hba *hisi_hba, u32 old_state,
static int hisi_sas_controller_reset(struct hisi_hba *hisi_hba)
{
- struct sas_ha_struct *sas_ha = &hisi_hba->sha;
struct device *dev = hisi_hba->dev;
struct Scsi_Host *shost = hisi_hba->shost;
u32 old_state, state;
--
2.14.1
[toc] | [next] | [standalone]
| From | John Garry <john.garry@huawei.com> |
|---|---|
| Date | 2017-09-27 00:40 +0200 |
| Message-ID | <uu6Gd-2hx-5@gated-at.bofh.it> |
| In reply to | #1740148 |
On 26/09/2017 20:17, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove unused variable sas_ha to clean up build warning
> "unused variable ‘sas_ha’ [-Wunused-variable]"
>
> Fixes: 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: John Garry <john.garry@huawei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 29d6cb39299c..9e2990268f00 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -1046,7 +1046,6 @@ static void hisi_sas_rescan_topology(struct hisi_hba *hisi_hba, u32 old_state,
>
> static int hisi_sas_controller_reset(struct hisi_hba *hisi_hba)
> {
> - struct sas_ha_struct *sas_ha = &hisi_hba->sha;
> struct device *dev = hisi_hba->dev;
> struct Scsi_Host *shost = hisi_hba->shost;
> u32 old_state, state;
>
[toc] | [prev] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2017-09-28 04:00 +0200 |
| Message-ID | <uuwhl-2rO-25@gated-at.bofh.it> |
| In reply to | #1740148 |
Colin, > Remove unused variable sas_ha to clean up build warning > "unused variable ‘sas_ha’ [-Wunused-variable]" Applied to 4.15/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web