Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1740073 > unrolled thread
| Started by | Mauro Carvalho Chehab <mchehab@s-opensource.com> |
|---|---|
| First post | 2017-09-26 20:10 +0200 |
| Last post | 2017-10-01 08:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 10/10] [RFC] w1_netlink.h: add support for nested structs Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2017-09-26 20:10 +0200
Re: [PATCH 10/10] [RFC] w1_netlink.h: add support for nested structs Evgeniy Polyakov <zbr@ioremap.net> - 2017-10-01 08:00 +0200
| From | Mauro Carvalho Chehab <mchehab@s-opensource.com> |
|---|---|
| Date | 2017-09-26 20:10 +0200 |
| Subject | [PATCH 10/10] [RFC] w1_netlink.h: add support for nested structs |
| Message-ID | <uu2sV-8cl-9@gated-at.bofh.it> |
Describe nested struct/union fields
NOTE: This is a pure test patch, meant to validate if the
parsing logic for nested structs is working properly.
I've no idea if the random text I added there is correct!
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
drivers/w1/w1_netlink.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/w1/w1_netlink.h b/drivers/w1/w1_netlink.h
index a36661cd1f05..e781d1109cd7 100644
--- a/drivers/w1/w1_netlink.h
+++ b/drivers/w1/w1_netlink.h
@@ -60,6 +60,10 @@ enum w1_netlink_message_types {
* @status: kernel feedback for success 0 or errno failure value
* @len: length of data following w1_netlink_msg
* @id: union holding master bus id (msg.id) and slave device id (id[8]).
+ * @id.id: Slave ID (8 bytes)
+ * @id.mst: master bus identification
+ * @id.mst.id: master bus ID
+ * @id.mst.res: master bus reserved
* @data: start address of any following data
*
* The base message structure for w1 messages over netlink.
--
2.13.5
[toc] | [next] | [standalone]
| From | Evgeniy Polyakov <zbr@ioremap.net> |
|---|---|
| Date | 2017-10-01 08:00 +0200 |
| Message-ID | <uvFsd-6vk-1@gated-at.bofh.it> |
| In reply to | #1740073 |
Hi
26.09.2017, 20:59, "Mauro Carvalho Chehab" <mchehab@s-opensource.com>:
> Describe nested struct/union fields
>
> NOTE: This is a pure test patch, meant to validate if the
> parsing logic for nested structs is working properly.
>
> I've no idea if the random text I added there is correct!
It looks correct, although I would switch master bus with bus master.
Feel free to add my acked-by.
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> ---
> drivers/w1/w1_netlink.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/w1/w1_netlink.h b/drivers/w1/w1_netlink.h
> index a36661cd1f05..e781d1109cd7 100644
> --- a/drivers/w1/w1_netlink.h
> +++ b/drivers/w1/w1_netlink.h
> @@ -60,6 +60,10 @@ enum w1_netlink_message_types {
> * @status: kernel feedback for success 0 or errno failure value
> * @len: length of data following w1_netlink_msg
> * @id: union holding master bus id (msg.id) and slave device id (id[8]).
> + * @id.id: Slave ID (8 bytes)
> + * @id.mst: master bus identification
> + * @id.mst.id: master bus ID
> + * @id.mst.res: master bus reserved
> * @data: start address of any following data
> *
> * The base message structure for w1 messages over netlink.
> --
> 2.13.5
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web