Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1740013 > unrolled thread

[PATCH 0/2] clk-mux: Adjustments for clk_hw_register_mux_table()

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] clk-mux: Adjustments for clk_hw_register_mux_table() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-26 18:30 +0200
    [PATCH 2/2] clk-mux: Improve a size determination in  clk_hw_register_mux_table() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-26 18:30 +0200

#1740013 — [PATCH 0/2] clk-mux: Adjustments for clk_hw_register_mux_table()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 26 Sep 2017 18:16:12 +0200

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
  Delete an error message for a failed memory allocation
  Improve a size determination

 drivers/clk/clk-mux.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

-- 
2.14.1

[toc] | [next] | [standalone]

#1740014 — [PATCH 2/2] clk-mux: Improve a size determination in clk_hw_register_mux_table()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 26 Sep 2017 17:30:06 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/clk/clk-mux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-mux.c b/drivers/clk/clk-mux.c
index 1746dbf2f7ea..39cabe157163 100644
--- a/drivers/clk/clk-mux.c
+++ b/drivers/clk/clk-mux.c
@@ -134,7 +134,7 @@ struct clk_hw *clk_hw_register_mux_table(struct device *dev, const char *name,
 	}
 
 	/* allocate the mux */
-	mux = kzalloc(sizeof(struct clk_mux), GFP_KERNEL);
+	mux = kzalloc(sizeof(*mux), GFP_KERNEL);
 	if (!mux)
 		return ERR_PTR(-ENOMEM);
 
-- 
2.14.1

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web