Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736629 > unrolled thread

[PATCH 1/1] wireless: broadcom: brcm80211: use setup_timer() helper

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/1] wireless: broadcom: brcm80211: use setup_timer() helper Allen Pais <allen.lkml@gmail.com> - 2017-09-21 14:50 +0200
    Re: [PATCH 1/1] wireless: broadcom: brcm80211: use setup_timer() helper Kalle Valo <kvalo@codeaurora.org> - 2017-09-21 17:00 +0200
    Re: [1/1] wireless: broadcom: brcm80211: use setup_timer() helper Kalle Valo <kvalo@codeaurora.org> - 2017-09-25 09:50 +0200
    Re: [1/1] wireless: broadcom: brcm80211: use setup_timer() helper Allen <allen.lkml@gmail.com> - 2017-09-25 10:00 +0200
      Re: [1/1] wireless: broadcom: brcm80211: use setup_timer() helper Kalle Valo <kvalo@codeaurora.org> - 2017-09-25 10:10 +0200
        Re: [1/1] wireless: broadcom: brcm80211: use setup_timer() helper Allen <allen.lkml@gmail.com> - 2017-09-25 10:30 +0200
    Re: [1/1] brcmfmac: use setup_timer() helper Kalle Valo <kvalo@codeaurora.org> - 2017-09-25 10:30 +0200

#1736629 — [PATCH 1/1] wireless: broadcom: brcm80211: use setup_timer() helper

    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index 613caca..5adce0e 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -4144,10 +4144,8 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev *sdiodev)
 	init_waitqueue_head(&bus->dcmd_resp_wait);
 
 	/* Set up the watchdog timer */
-	init_timer(&bus->timer);
-	bus->timer.data = (unsigned long)bus;
-	bus->timer.function = brcmf_sdio_watchdog;
-
+	setup_timer(&bus->timer, brcmf_sdio_watchdog,
+		    (unsigned long)bus);
 	/* Initialize watchdog thread */
 	init_completion(&bus->watchdog_wait);
 	bus->watchdog_tsk = kthread_run(brcmf_sdio_watchdog_thread,
-- 
2.7.4

[toc] | [next] | [standalone]

#1736736

Allen Pais <allen.lkml@gmail.com> writes:

>     Use setup_timer function instead of initializing timer with the
>     function and data fields.
>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>

The commit log is weirdly indented and no need to have "wireless:
broadcom:" in the title. I can fix both of those.

-- 
Kalle Valo

[toc] | [prev] | [next] | [standalone]

#1738798 — Re: [1/1] wireless: broadcom: brcm80211: use setup_timer() helper

Allen <allen.lkml@gmail.com> wrote:

> Use setup_timer function instead of initializing timer with the
>     function and data fields.
> 
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>

Also your name in patchwork is just "Allen", without your lastname. I can fix
it this time, but please register to patchwork to fix your name. (Annoyingly
patchwork takes the name from it's database, not from the "From:" header)

-- 
https://patchwork.kernel.org/patch/9963851/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

[toc] | [prev] | [next] | [standalone]

#1738802 — Re: [1/1] wireless: broadcom: brcm80211: use setup_timer() helper

>
> Also your name in patchwork is just "Allen", without your lastname. I can fix
> it this time, but please register to patchwork to fix your name. (Annoyingly
> patchwork takes the name from it's database, not from the "From:" header)

 Ah that's strange. I'll register again.

Thanks,
- Allen

> --
> https://patchwork.kernel.org/patch/9963851/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>

[toc] | [prev] | [next] | [standalone]

#1738808 — Re: [1/1] wireless: broadcom: brcm80211: use setup_timer() helper

Allen <allen.lkml@gmail.com> writes:

>>
>> Also your name in patchwork is just "Allen", without your lastname. I can fix
>> it this time, but please register to patchwork to fix your name. (Annoyingly
>> patchwork takes the name from it's database, not from the "From:" header)
>
>  Ah that's strange. I'll register again.

It's a frequent problem to have misconfigured name in patchwork. I guess
it happens as the first mail patchwork sees from you is the one stored
to the database. And if that mail has an incorrect name, that will be
used from that onwards. You have only onetime chance to fix it yourself
when you register to patchwork. After that only server admins can fix it
and you need to contact kernel.org helpdesk.

Apparently in recent versions of patchwork this should work better but
kernel.org hasn't updated it yet.

-- 
Kalle Valo

[toc] | [prev] | [next] | [standalone]

#1738822 — Re: [1/1] wireless: broadcom: brcm80211: use setup_timer() helper

>
> It's a frequent problem to have misconfigured name in patchwork. I guess
> it happens as the first mail patchwork sees from you is the one stored
> to the database. And if that mail has an incorrect name, that will be
> used from that onwards. You have only onetime chance to fix it yourself
> when you register to patchwork. After that only server admins can fix it
> and you need to contact kernel.org helpdesk.

  I have registered again and let's hope it picks the full name going forward.

> Apparently in recent versions of patchwork this should work better but
> kernel.org hasn't updated it yet.
>
I'll write to the admins, ensure it is right.

Thank you.

[toc] | [prev] | [next] | [standalone]

#1738823 — Re: [1/1] brcmfmac: use setup_timer() helper

Allen Pais <allen.lkml@gmail.com> wrote:

> Use setup_timer function instead of initializing timer with the
> function and data fields.
> 
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>

Patch applied to wireless-drivers-next.git, thanks.

30ac40763939 brcmfmac: use setup_timer() helper

-- 
https://patchwork.kernel.org/patch/9963851/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web