Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1738772 > unrolled thread

[PATCH] ANDROID: binder: pr_err() strings should end with newlines

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2017-09-25 09:00 +0200
Last post2017-09-25 09:10 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] ANDROID: binder: pr_err() strings should end with newlines Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-25 09:00 +0200
    Re: [PATCH] ANDROID: binder: pr_err() strings should end with  newlines Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-25 09:10 +0200
    Re: [PATCH] ANDROID: binder: pr_err() strings should end with  newlines Greg KH <gregkh@linuxfoundation.org> - 2017-09-25 09:10 +0200

#1738772 — [PATCH] ANDROID: binder: pr_err() strings should end with newlines

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-09-25 09:00 +0200
Subject[PATCH] ANDROID: binder: pr_err() strings should end with newlines
Message-ID<utvwZ-2Kk-1@gated-at.bofh.it>
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/android/binder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index d055b3f..044b1c2 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2192,7 +2192,7 @@ static void binder_transaction_buffer_release(struct binder_proc *proc,
 						     off_start,
 						     offp - off_start);
 			if (!parent) {
-				pr_err("transaction release %d bad parent offset",
+				pr_err("transaction release %d bad parent offset\n",
 				       debug_id);
 				continue;
 			}
-- 
1.9.1

[toc] | [next] | [standalone]


#1738775 — Re: [PATCH] ANDROID: binder: pr_err() strings should end with newlines

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-09-25 09:10 +0200
SubjectRe: [PATCH] ANDROID: binder: pr_err() strings should end with newlines
Message-ID<utvGG-33T-9@gated-at.bofh.it>
In reply to#1738772

On Monday 25 September 2017 12:31 PM, Greg KH wrote:
> On Mon, Sep 25, 2017 at 12:21:47PM +0530, Arvind Yadav wrote:
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
> I can't take patches without any changelog text, sorry.
As per your concern, I will update.
>
> greg k-h
~arvind

[toc] | [prev] | [next] | [standalone]


#1738776 — Re: [PATCH] ANDROID: binder: pr_err() strings should end with newlines

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-09-25 09:10 +0200
SubjectRe: [PATCH] ANDROID: binder: pr_err() strings should end with newlines
Message-ID<utvGG-33T-11@gated-at.bofh.it>
In reply to#1738772
On Mon, Sep 25, 2017 at 12:21:47PM +0530, Arvind Yadav wrote:
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---

I can't take patches without any changelog text, sorry.

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web