Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1735866 > unrolled thread

[PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire power directory

Back to article view | Back to linux.kernel

Contents

  [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire power directory Viresh Kumar <viresh.kumar@linaro.org> - 2017-09-20 18:00 +0200
    Re: [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire  power directory "Rafael J. Wysocki" <rafael@kernel.org> - 2017-09-25 00:50 +0200
      Re: [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire  power directory Viresh Kumar <viresh.kumar@linaro.org> - 2017-09-26 01:20 +0200
        Re: [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire  power directory "Rafael J. Wysocki" <rafael@kernel.org> - 2017-09-26 01:20 +0200

#1735866 — [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire power directory

The command:

 $ scripts/get_maintainer.pl -f drivers/base/power/opp/core.c

is incorrectly picking maintainers from Hibernation and Suspend to RAM
as well, simply because the entries in MAINTAINERS file contains the
entire power directory. Though the only concerning file is main.c
really. Mention the exact file name to fix it.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2281af4b41b6..59521c15c65e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6150,7 +6150,7 @@ L:	linux-pm@vger.kernel.org
 B:	https://bugzilla.kernel.org
 S:	Supported
 F:	arch/x86/power/
-F:	drivers/base/power/
+F:	drivers/base/power/main.c
 F:	kernel/power/
 F:	include/linux/suspend.h
 F:	include/linux/freezer.h
@@ -12809,7 +12809,7 @@ B:	https://bugzilla.kernel.org
 S:	Supported
 F:	Documentation/power/
 F:	arch/x86/kernel/acpi/
-F:	drivers/base/power/
+F:	drivers/base/power/main.c
 F:	kernel/power/
 F:	include/linux/suspend.h
 F:	include/linux/freezer.h
-- 
2.7.4

[toc] | [next] | [standalone]

#1738583 — Re: [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire power directory

On Wed, Sep 20, 2017 at 5:58 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> The command:
>
>  $ scripts/get_maintainer.pl -f drivers/base/power/opp/core.c
>
> is incorrectly picking maintainers from Hibernation and Suspend to RAM
> as well, simply because the entries in MAINTAINERS file contains the
> entire power directory. Though the only concerning file is main.c
> really.

No, it is not the only one.  The others are common.c, trace.c,
wakeup.c, wakeirq.c, sysfs.c, generic_ops.c and power.h (if I have not
overlooked any).

I'm not actually sure how to fix this issue other than by listing all
of the files in question directly in there.

Thanks,
Rafael

[toc] | [prev] | [next] | [standalone]

#1739337 — Re: [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire power directory

On 25-09-17, 00:44, Rafael J. Wysocki wrote:
> On Wed, Sep 20, 2017 at 5:58 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > The command:
> >
> >  $ scripts/get_maintainer.pl -f drivers/base/power/opp/core.c
> >
> > is incorrectly picking maintainers from Hibernation and Suspend to RAM
> > as well, simply because the entries in MAINTAINERS file contains the
> > entire power directory. Though the only concerning file is main.c
> > really.
> 
> No, it is not the only one.  The others are common.c, trace.c,
> wakeup.c, wakeirq.c, sysfs.c, generic_ops.c and power.h (if I have not
> overlooked any).
> 
> I'm not actually sure how to fix this issue other than by listing all
> of the files in question directly in there.

Should I just use *.c for now? Yeah, that will still cover lot more files, but
at least the directories, like OPP, are not going to show those maintainers.

Or I was actually thinking of moving the entire OPP directory out of
drivers/base/power, and move to drivers/opp, just like cpufreq and cpuidle. Will
that be okay?

-- 
viresh

[toc] | [prev] | [next] | [standalone]

#1739343 — Re: [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire power directory

On Tue, Sep 26, 2017 at 1:10 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 25-09-17, 00:44, Rafael J. Wysocki wrote:
>> On Wed, Sep 20, 2017 at 5:58 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> > The command:
>> >
>> >  $ scripts/get_maintainer.pl -f drivers/base/power/opp/core.c
>> >
>> > is incorrectly picking maintainers from Hibernation and Suspend to RAM
>> > as well, simply because the entries in MAINTAINERS file contains the
>> > entire power directory. Though the only concerning file is main.c
>> > really.
>>
>> No, it is not the only one.  The others are common.c, trace.c,
>> wakeup.c, wakeirq.c, sysfs.c, generic_ops.c and power.h (if I have not
>> overlooked any).
>>
>> I'm not actually sure how to fix this issue other than by listing all
>> of the files in question directly in there.
>
> Should I just use *.c for now? Yeah, that will still cover lot more files, but
> at least the directories, like OPP, are not going to show those maintainers.
>
> Or I was actually thinking of moving the entire OPP directory out of
> drivers/base/power, and move to drivers/opp, just like cpufreq and cpuidle. Will
> that be okay?

Yes, that should be fine.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web