Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1738251 > unrolled thread
| Started by | Christos Gkekas <chris.gekas@gmail.com> |
|---|---|
| First post | 2017-09-24 21:00 +0200 |
| Last post | 2017-09-24 21:20 +0200 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH] vxge: Fix rts_mac_en config parameter check Christos Gkekas <chris.gekas@gmail.com> - 2017-09-24 21:00 +0200
Re: [PATCH] vxge: Fix rts_mac_en config parameter check Christos Gkekas <chris.gekas@gmail.com> - 2017-09-24 21:20 +0200
| From | Christos Gkekas <chris.gekas@gmail.com> |
|---|---|
| Date | 2017-09-24 21:00 +0200 |
| Subject | [PATCH] vxge: Fix rts_mac_en config parameter check |
| Message-ID | <utkid-3NE-11@gated-at.bofh.it> |
Current checks return VXGE_HW_BADCFG_RTS_MAC_EN if rts_mac_en is not
equal to DISABLE *and* not equal to ENABLE. This condition is always
false and the check should change to *or* to properly verify the value.
Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
drivers/net/ethernet/neterion/vxge/vxge-config.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-config.c b/drivers/net/ethernet/neterion/vxge/vxge-config.c
index 6223930..c694f97 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-config.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-config.c
@@ -1286,8 +1286,8 @@ __vxge_hw_device_config_check(struct vxge_hw_device_config *new_config)
(new_config->intr_mode != VXGE_HW_INTR_MODE_DEF))
return VXGE_HW_BADCFG_INTR_MODE;
- if ((new_config->rts_mac_en != VXGE_HW_RTS_MAC_DISABLE) &&
- (new_config->rts_mac_en != VXGE_HW_RTS_MAC_ENABLE))
+ if (new_config->rts_mac_en != VXGE_HW_RTS_MAC_DISABLE ||
+ new_config->rts_mac_en != VXGE_HW_RTS_MAC_ENABLE)
return VXGE_HW_BADCFG_RTS_MAC_EN;
for (i = 0; i < VXGE_HW_MAX_VIRTUAL_PATHS; i++) {
--
2.7.4
[toc] | [next] | [standalone]
| From | Christos Gkekas <chris.gekas@gmail.com> |
|---|---|
| Date | 2017-09-24 21:20 +0200 |
| Message-ID | <utkBz-49N-3@gated-at.bofh.it> |
| In reply to | #1738251 |
On 24/09/17 19:50:21 +0100, Christos Gkekas wrote:
> Current checks return VXGE_HW_BADCFG_RTS_MAC_EN if rts_mac_en is not
> equal to DISABLE *and* not equal to ENABLE. This condition is always
> false and the check should change to *or* to properly verify the value.
>
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
> ---
> drivers/net/ethernet/neterion/vxge/vxge-config.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/neterion/vxge/vxge-config.c b/drivers/net/ethernet/neterion/vxge/vxge-config.c
> index 6223930..c694f97 100644
> --- a/drivers/net/ethernet/neterion/vxge/vxge-config.c
> +++ b/drivers/net/ethernet/neterion/vxge/vxge-config.c
> @@ -1286,8 +1286,8 @@ __vxge_hw_device_config_check(struct vxge_hw_device_config *new_config)
> (new_config->intr_mode != VXGE_HW_INTR_MODE_DEF))
> return VXGE_HW_BADCFG_INTR_MODE;
>
> - if ((new_config->rts_mac_en != VXGE_HW_RTS_MAC_DISABLE) &&
> - (new_config->rts_mac_en != VXGE_HW_RTS_MAC_ENABLE))
> + if (new_config->rts_mac_en != VXGE_HW_RTS_MAC_DISABLE ||
> + new_config->rts_mac_en != VXGE_HW_RTS_MAC_ENABLE)
> return VXGE_HW_BADCFG_RTS_MAC_EN;
>
> for (i = 0; i < VXGE_HW_MAX_VIRTUAL_PATHS; i++) {
> --
> 2.7.4
>
Please ignore the patch above, it was sent in error.
Thanks,
Chris
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web