Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1733035 > unrolled thread
| Started by | Mathieu Malaterre <malat@debian.org> |
|---|---|
| First post | 2017-09-15 21:20 +0200 |
| Last post | 2017-09-26 16:10 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 3/5] MIPS: jz4780: DTS: Probe the jz4740-watchdog driver from devicetree Mathieu Malaterre <malat@debian.org> - 2017-09-15 21:20 +0200
Re: [PATCH v2 3/5] MIPS: jz4780: DTS: Probe the jz4740-watchdog driver from devicetree PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> - 2017-09-26 15:20 +0200
Re: [PATCH v2 3/5] MIPS: jz4780: DTS: Probe the jz4740-watchdog driver from devicetree Mathieu Malaterre <malat@debian.org> - 2017-09-26 15:30 +0200
Re: [PATCH v2 3/5] MIPS: jz4780: DTS: Probe the jz4740-watchdog driver from devicetree PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> - 2017-09-26 16:10 +0200
| From | Mathieu Malaterre <malat@debian.org> |
|---|---|
| Date | 2017-09-15 21:20 +0200 |
| Subject | [PATCH v2 3/5] MIPS: jz4780: DTS: Probe the jz4740-watchdog driver from devicetree |
| Message-ID | <uq4jD-7gb-3@gated-at.bofh.it> |
The jz4740-watchdog driver supports both jz4740 & jz4780.
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
Changes in v2:
* make the node name generic (Paul Cercueil)
arch/mips/boot/dts/ingenic/jz4780.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
index 20e37d2d6008..76055bbc823a 100644
--- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
+++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
@@ -263,6 +263,11 @@
status = "disabled";
};
+ watchdog: watchdog@10002000 {
+ compatible = "ingenic,jz4780-watchdog";
+ reg = <0x10002000 0x100>;
+ };
+
nemc: nemc@13410000 {
compatible = "ingenic,jz4780-nemc";
reg = <0x13410000 0x10000>;
--
2.11.0
[toc] | [next] | [standalone]
| From | PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> |
|---|---|
| Date | 2017-09-26 15:20 +0200 |
| Subject | Re: [PATCH v2 3/5] MIPS: jz4780: DTS: Probe the jz4740-watchdog driver from devicetree |
| Message-ID | <utXWh-5gz-1@gated-at.bofh.it> |
| In reply to | #1733035 |
Hi Mathieu,
On 16 September 2017 at 00:48, Mathieu Malaterre <malat@debian.org> wrote:
> The jz4740-watchdog driver supports both jz4740 & jz4780.
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> Changes in v2:
> * make the node name generic (Paul Cercueil)
>
> arch/mips/boot/dts/ingenic/jz4780.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index 20e37d2d6008..76055bbc823a 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -263,6 +263,11 @@
> status = "disabled";
> };
>
> + watchdog: watchdog@10002000 {
> + compatible = "ingenic,jz4780-watchdog";
In drivers/watchdog/jz4740_wdt.c the compatible is declared as
"ingenic,jz4740-watchdog" while your change says
"ingenic,jz4780-watchdog". Can you modify that?
> + reg = <0x10002000 0x100>;
> + };
> +
The structures jz4740_wdt_device and jz4740_wdt_resources can be
removed form arch/mips/jz4740/platform.c as watchdog is declared in
device tree. For JZ4740 platform watchdog is not used so the variables
can be removed.
Do you mind adding watchdog entry to JZ4740 device tree? Currently
watchdog is not enabled for JZ4740 platform.
> nemc: nemc@13410000 {
> compatible = "ingenic,jz4780-nemc";
> reg = <0x13410000 0x10000>;
> --
> 2.11.0
>
Regards,
PrasannaKumar
[toc] | [prev] | [next] | [standalone]
| From | Mathieu Malaterre <malat@debian.org> |
|---|---|
| Date | 2017-09-26 15:30 +0200 |
| Subject | Re: [PATCH v2 3/5] MIPS: jz4780: DTS: Probe the jz4740-watchdog driver from devicetree |
| Message-ID | <utY5Y-5jU-17@gated-at.bofh.it> |
| In reply to | #1739874 |
Hi PrasannaKumar !
On Tue, Sep 26, 2017 at 3:17 PM, PrasannaKumar Muralidharan
<prasannatsmkumar@gmail.com> wrote:
> Hi Mathieu,
>
> On 16 September 2017 at 00:48, Mathieu Malaterre <malat@debian.org> wrote:
>> The jz4740-watchdog driver supports both jz4740 & jz4780.
>>
>> Signed-off-by: Mathieu Malaterre <malat@debian.org>
>> ---
>> Changes in v2:
>> * make the node name generic (Paul Cercueil)
>>
>> arch/mips/boot/dts/ingenic/jz4780.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>> index 20e37d2d6008..76055bbc823a 100644
>> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
>> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>> @@ -263,6 +263,11 @@
>> status = "disabled";
>> };
>>
>> + watchdog: watchdog@10002000 {
>> + compatible = "ingenic,jz4780-watchdog";
>
> In drivers/watchdog/jz4740_wdt.c the compatible is declared as
> "ingenic,jz4740-watchdog" while your change says
> "ingenic,jz4780-watchdog". Can you modify that?
Well in the full changeset, you'll find: [PATCH v2 4/5] watchdog:
jz4740: Add support for the watchdog in jz4780 SoC
https://lkml.org/lkml/2017/9/15/451
There has been some misunderstanding. I still believe I need a new
compatible string, even if currently the code is 100% identical.
>> + reg = <0x10002000 0x100>;
>> + };
>> +
>
> The structures jz4740_wdt_device and jz4740_wdt_resources can be
> removed form arch/mips/jz4740/platform.c as watchdog is declared in
> device tree. For JZ4740 platform watchdog is not used so the variables
> can be removed.
>
> Do you mind adding watchdog entry to JZ4740 device tree? Currently
> watchdog is not enabled for JZ4740 platform.
Will do once this series has been accepted. Thanks for the review !
>> nemc: nemc@13410000 {
>> compatible = "ingenic,jz4780-nemc";
>> reg = <0x13410000 0x10000>;
>> --
>> 2.11.0
>>
>
> Regards,
> PrasannaKumar
[toc] | [prev] | [next] | [standalone]
| From | PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> |
|---|---|
| Date | 2017-09-26 16:10 +0200 |
| Subject | Re: [PATCH v2 3/5] MIPS: jz4780: DTS: Probe the jz4740-watchdog driver from devicetree |
| Message-ID | <utYIF-5O1-1@gated-at.bofh.it> |
| In reply to | #1739888 |
On 26 September 2017 at 18:56, Mathieu Malaterre <malat@debian.org> wrote:
> Hi PrasannaKumar !
>
> On Tue, Sep 26, 2017 at 3:17 PM, PrasannaKumar Muralidharan
> <prasannatsmkumar@gmail.com> wrote:
>> Hi Mathieu,
>>
>> On 16 September 2017 at 00:48, Mathieu Malaterre <malat@debian.org> wrote:
>>> The jz4740-watchdog driver supports both jz4740 & jz4780.
>>>
>>> Signed-off-by: Mathieu Malaterre <malat@debian.org>
>>> ---
>>> Changes in v2:
>>> * make the node name generic (Paul Cercueil)
>>>
>>> arch/mips/boot/dts/ingenic/jz4780.dtsi | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> index 20e37d2d6008..76055bbc823a 100644
>>> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> @@ -263,6 +263,11 @@
>>> status = "disabled";
>>> };
>>>
>>> + watchdog: watchdog@10002000 {
>>> + compatible = "ingenic,jz4780-watchdog";
>>
>> In drivers/watchdog/jz4740_wdt.c the compatible is declared as
>> "ingenic,jz4740-watchdog" while your change says
>> "ingenic,jz4780-watchdog". Can you modify that?
>
> Well in the full changeset, you'll find: [PATCH v2 4/5] watchdog:
> jz4740: Add support for the watchdog in jz4780 SoC
>
> https://lkml.org/lkml/2017/9/15/451
>
> There has been some misunderstanding. I still believe I need a new
> compatible string, even if currently the code is 100% identical.
I missed that. Ignore this comment.
>
>>> + reg = <0x10002000 0x100>;
>>> + };
>>> +
>>
>> The structures jz4740_wdt_device and jz4740_wdt_resources can be
>> removed form arch/mips/jz4740/platform.c as watchdog is declared in
>> device tree. For JZ4740 platform watchdog is not used so the variables
>> can be removed.
>>
>> Do you mind adding watchdog entry to JZ4740 device tree? Currently
>> watchdog is not enabled for JZ4740 platform.
>
>
> Will do once this series has been accepted. Thanks for the review !
Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
>
>>> nemc: nemc@13410000 {
>>> compatible = "ingenic,jz4780-nemc";
>>> reg = <0x13410000 0x10000>;
>>> --
>>> 2.11.0
>>>
>>
>> Regards,
>> PrasannaKumar
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web