Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1739491 > unrolled thread

[PATCH] mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID

Started byMasahiro Yamada <yamada.masahiro@socionext.com>
First post2017-09-26 05:50 +0200
Last post2017-09-26 10:30 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-26 05:50 +0200
    Re: [PATCH] mtd: nand: wait for tWHR after NAND_CMD_STATUS /  NAND_CMD_READID Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-09-26 08:50 +0200
      Re: [PATCH] mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-26 10:20 +0200
        Re: [PATCH] mtd: nand: wait for tWHR after NAND_CMD_STATUS /  NAND_CMD_READID Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-09-26 10:30 +0200

#1739491 — [PATCH] mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2017-09-26 05:50 +0200
Subject[PATCH] mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID
Message-ID<utP2F-7zs-7@gated-at.bofh.it>
Read Status and Read ID require tWHR before reading the first data.
Insert a very short wait to make sure to meet the spec.

I have not seen any problem report for now, but nand_command() and
nand_command_lP() are generic hooks, so it makes sense to implement
fail-safe code here.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/mtd/nand/nand_base.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index b1cf32c..55c0ba5 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -742,9 +742,12 @@ static void nand_command(struct mtd_info *mtd, unsigned int command,
 	case NAND_CMD_ERASE1:
 	case NAND_CMD_ERASE2:
 	case NAND_CMD_SEQIN:
+	case NAND_CMD_SET_FEATURES:
+		return;
+
 	case NAND_CMD_STATUS:
 	case NAND_CMD_READID:
-	case NAND_CMD_SET_FEATURES:
+		ndelay(200);	/* tWHR */
 		return;
 
 	case NAND_CMD_RESET:
@@ -871,9 +874,12 @@ static void nand_command_lp(struct mtd_info *mtd, unsigned int command,
 	case NAND_CMD_ERASE1:
 	case NAND_CMD_ERASE2:
 	case NAND_CMD_SEQIN:
+	case NAND_CMD_SET_FEATURES:
+		return;
+
 	case NAND_CMD_STATUS:
 	case NAND_CMD_READID:
-	case NAND_CMD_SET_FEATURES:
+		ndelay(200);	/* tWHR */
 		return;
 
 	case NAND_CMD_RNDIN:
-- 
2.7.4

[toc] | [next] | [standalone]

#1739551 — Re: [PATCH] mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID

FromBoris Brezillon <boris.brezillon@free-electrons.com>
Date2017-09-26 08:50 +0200
SubjectRe: [PATCH] mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID
Message-ID<utRQR-150-9@gated-at.bofh.it>
In reply to#1739491
On Tue, 26 Sep 2017 12:39:24 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> Read Status and Read ID require tWHR before reading the first data.
> Insert a very short wait to make sure to meet the spec.
> 
> I have not seen any problem report for now, but nand_command() and
> nand_command_lP() are generic hooks, so it makes sense to implement
> fail-safe code here.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  drivers/mtd/nand/nand_base.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index b1cf32c..55c0ba5 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -742,9 +742,12 @@ static void nand_command(struct mtd_info *mtd, unsigned int command,
>  	case NAND_CMD_ERASE1:
>  	case NAND_CMD_ERASE2:
>  	case NAND_CMD_SEQIN:
> +	case NAND_CMD_SET_FEATURES:
> +		return;
> +
>  	case NAND_CMD_STATUS:
>  	case NAND_CMD_READID:
> -	case NAND_CMD_SET_FEATURES:
> +		ndelay(200);	/* tWHR */
>  		return;
>  
>  	case NAND_CMD_RESET:
> @@ -871,9 +874,12 @@ static void nand_command_lp(struct mtd_info *mtd, unsigned int command,
>  	case NAND_CMD_ERASE1:
>  	case NAND_CMD_ERASE2:
>  	case NAND_CMD_SEQIN:
> +	case NAND_CMD_SET_FEATURES:
> +		return;
> +
>  	case NAND_CMD_STATUS:
>  	case NAND_CMD_READID:
> -	case NAND_CMD_SET_FEATURES:
> +		ndelay(200);	/* tWHR */

Can you do something like nand_ccs_delay() [1] instead of
unconditionally adding this 200ns delay here? I'm not worried about the
overhead introduced by this ndelay(), but I don't want to risk
introducing a regression.
 

>  		return;
>  
>  	case NAND_CMD_RNDIN:

[1]http://elixir.free-electrons.com/linux/v4.14-rc2/source/drivers/mtd/nand/nand_base.c#L793

[toc] | [prev] | [next] | [standalone]

#1739663

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2017-09-26 10:20 +0200
Message-ID<utTfY-29X-21@gated-at.bofh.it>
In reply to#1739551
2017-09-26 15:43 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>:
> On Tue, 26 Sep 2017 12:39:24 +0900
> Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
>> Read Status and Read ID require tWHR before reading the first data.
>> Insert a very short wait to make sure to meet the spec.
>>
>> I have not seen any problem report for now, but nand_command() and
>> nand_command_lP() are generic hooks, so it makes sense to implement
>> fail-safe code here.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>


OK, will do.



BTW, I see unconditional wait for tWB a few lines below,
but it gives no performance regression because we will wait
much longer in nand_wait_ready().


     /*
      * Apply this short delay always to ensure that we do wait tWB in
      * any case on any machine.
      */
     ndelay(100);

     nand_wait_ready(mtd);




-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]

#1739666 — Re: [PATCH] mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID

FromBoris Brezillon <boris.brezillon@free-electrons.com>
Date2017-09-26 10:30 +0200
SubjectRe: [PATCH] mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID
Message-ID<utTpD-2dI-7@gated-at.bofh.it>
In reply to#1739663
On Tue, 26 Sep 2017 17:17:49 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> 2017-09-26 15:43 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>:
> > On Tue, 26 Sep 2017 12:39:24 +0900
> > Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> >  
> >> Read Status and Read ID require tWHR before reading the first data.
> >> Insert a very short wait to make sure to meet the spec.
> >>
> >> I have not seen any problem report for now, but nand_command() and
> >> nand_command_lP() are generic hooks, so it makes sense to implement
> >> fail-safe code here.
> >>
> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >> ---  
> >  
> 
> 
> OK, will do.
> 
> 
> 
> BTW, I see unconditional wait for tWB a few lines below,
> but it gives no performance regression because we will wait
> much longer in nand_wait_ready().

Yep, but this one is here for quite some time. Normally there should be
no problem with your ndelay(200), but I don't want to take the risk
and have someone complain that his NAND controller driver is broken
because of this extra delay ;-).

> 
> 
>      /*
>       * Apply this short delay always to ensure that we do wait tWB in
>       * any case on any machine.
>       */
>      ndelay(100);
> 
>      nand_wait_ready(mtd);
> 
> 
> 
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web