Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1739574 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-09-26 09:00 +0200 |
| Last post | 2017-09-27 16:30 +0200 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-26 09:00 +0200
Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines Yuval Shaia <yuval.shaia@oracle.com> - 2017-09-26 09:10 +0200
Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines Joe Perches <joe@perches.com> - 2017-09-26 17:10 +0200
Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines Joe Perches <joe@perches.com> - 2017-09-26 21:20 +0200
Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines Doug Ledford <dledford@redhat.com> - 2017-09-27 16:30 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-09-26 09:00 +0200 |
| Subject | [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines |
| Message-ID | <utS0y-18O-27@gated-at.bofh.it> |
pr_err() and mlx5_ib_dbg( messages should terminated with a new-line to
avoid other messages being concatenated.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/infiniband/hw/mlx5/mr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
index 0e2789d..92d643a 100644
--- a/drivers/infiniband/hw/mlx5/mr.c
+++ b/drivers/infiniband/hw/mlx5/mr.c
@@ -1229,13 +1229,13 @@ struct ib_mr *mlx5_ib_reg_user_mr(struct ib_pd *pd, u64 start, u64 length,
mr = alloc_mr_from_cache(pd, umem, virt_addr, length, ncont,
page_shift, order, access_flags);
if (PTR_ERR(mr) == -EAGAIN) {
- mlx5_ib_dbg(dev, "cache empty for order %d", order);
+ mlx5_ib_dbg(dev, "cache empty for order %d\n", order);
mr = NULL;
}
} else if (!MLX5_CAP_GEN(dev->mdev, umr_extended_translation_offset)) {
if (access_flags & IB_ACCESS_ON_DEMAND) {
err = -EINVAL;
- pr_err("Got MR registration for ODP MR > 512MB, not supported for Connect-IB");
+ pr_err("Got MR registration for ODP MR > 512MB, not supported for Connect-IB\n");
goto error;
}
use_umr = false;
--
1.9.1
[toc] | [next] | [standalone]
| From | Yuval Shaia <yuval.shaia@oracle.com> |
|---|---|
| Date | 2017-09-26 09:10 +0200 |
| Subject | Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines |
| Message-ID | <utSae-1rM-15@gated-at.bofh.it> |
| In reply to | #1739574 |
On Tue, Sep 26, 2017 at 12:20:01PM +0530, Arvind Yadav wrote:
> pr_err() and mlx5_ib_dbg( messages should terminated with a new-line to
> avoid other messages being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/infiniband/hw/mlx5/mr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
> index 0e2789d..92d643a 100644
> --- a/drivers/infiniband/hw/mlx5/mr.c
> +++ b/drivers/infiniband/hw/mlx5/mr.c
> @@ -1229,13 +1229,13 @@ struct ib_mr *mlx5_ib_reg_user_mr(struct ib_pd *pd, u64 start, u64 length,
> mr = alloc_mr_from_cache(pd, umem, virt_addr, length, ncont,
> page_shift, order, access_flags);
> if (PTR_ERR(mr) == -EAGAIN) {
> - mlx5_ib_dbg(dev, "cache empty for order %d", order);
> + mlx5_ib_dbg(dev, "cache empty for order %d\n", order);
> mr = NULL;
> }
> } else if (!MLX5_CAP_GEN(dev->mdev, umr_extended_translation_offset)) {
> if (access_flags & IB_ACCESS_ON_DEMAND) {
> err = -EINVAL;
> - pr_err("Got MR registration for ODP MR > 512MB, not supported for Connect-IB");
> + pr_err("Got MR registration for ODP MR > 512MB, not supported for Connect-IB\n");
> goto error;
> }
> use_umr = false;
> --
> 1.9.1
FWIW,
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-09-26 17:10 +0200 |
| Subject | Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines |
| Message-ID | <utZEL-6pY-43@gated-at.bofh.it> |
| In reply to | #1739574 |
On Tue, 2017-09-26 at 11:38 +0300, Leon Romanovsky wrote:
> On Tue, Sep 26, 2017 at 12:20:01PM +0530, Arvind Yadav wrote:
> > pr_err() and mlx5_ib_dbg( messages should terminated with a new-line to
> > avoid other messages being concatenated.
[]
> Did you see it is happening?
> It is not needed after 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing continuation lines")
Not completely true, and that commit message
itself is incorrect about how KERN_CONT was
ever required or not required.
After that commit, the dmesg output will
eventually be corrected with an appended newline
for sine line format strings without them, but
the printk subsystem has to wait for another
printk to occur before inserting that newline.
The commit message bit that says:
Things get much hairier when you have
multiple threads going on and user level
reading and writing logs too
is correct. That's the actual reason that
the proposed newline additions are reasonable.
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-09-26 21:20 +0200 |
| Subject | Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines |
| Message-ID | <uu3yG-my-15@gated-at.bofh.it> |
| In reply to | #1739963 |
On Tue, 2017-09-26 at 18:50 +0300, Leon Romanovsky wrote: > So how can I reproduce the different output before and after this change? Try lib/test_module.c with and without the newline on "Hello, World" on a quiescent system.
[toc] | [prev] | [next] | [standalone]
| From | Doug Ledford <dledford@redhat.com> |
|---|---|
| Date | 2017-09-27 16:30 +0200 |
| Subject | Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines |
| Message-ID | <uulvz-4kL-13@gated-at.bofh.it> |
| In reply to | #1740146 |
On Tue, 2017-09-26 at 12:11 -0700, Joe Perches wrote:
> On Tue, 2017-09-26 at 18:50 +0300, Leon Romanovsky wrote:
> > So how can I reproduce the different output before and after this
> > change?
>
> Try lib/test_module.c with and without the newline
> on "Hello, World" on a quiescent system.
I agree here. The newlines are still worthwhile as they remove any
unnecessary stalls in the printk output while the printk engine decides
whether or not you are going to do a KERN_CONT print next.
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web