Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1739576 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-09-26 09:00 +0200 |
| Last post | 2017-09-27 16:30 +0200 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] IB/ocrdma: pr_err() strings should end with newlines Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-26 09:00 +0200
Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines Yuval Shaia <yuval.shaia@oracle.com> - 2017-09-26 09:20 +0200
Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-26 09:40 +0200
Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines Joe Perches <joe@perches.com> - 2017-09-26 17:30 +0200
Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines Doug Ledford <dledford@redhat.com> - 2017-09-27 16:30 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-09-26 09:00 +0200 |
| Subject | [PATCH] IB/ocrdma: pr_err() strings should end with newlines |
| Message-ID | <utS0y-18O-31@gated-at.bofh.it> |
pr_err() messages should end with a new-line to avoid other messages
being concatenated.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
index 66056f9..e528d7a 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
@@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
if (reset) {
status = ocrdma_mbx_rdma_stats(dev, true);
if (status) {
- pr_err("Failed to reset stats = %d", status);
+ pr_err("Failed to reset stats = %d\n", status);
goto err;
}
}
--
1.9.1
[toc] | [next] | [standalone]
| From | Yuval Shaia <yuval.shaia@oracle.com> |
|---|---|
| Date | 2017-09-26 09:20 +0200 |
| Message-ID | <utSjV-1vB-9@gated-at.bofh.it> |
| In reply to | #1739576 |
On Tue, Sep 26, 2017 at 12:21:44PM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> index 66056f9..e528d7a 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> @@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
> if (reset) {
> status = ocrdma_mbx_rdma_stats(dev, true);
> if (status) {
> - pr_err("Failed to reset stats = %d", status);
> + pr_err("Failed to reset stats = %d\n", status);
> goto err;
> }
> }
While there, can you also fix line 1096 in ocrdma_hw.c?
(is it too naive to expect checkptahc to catch such errors?)
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-09-26 09:40 +0200 |
| Message-ID | <utSDg-1Ff-11@gated-at.bofh.it> |
| In reply to | #1739601 |
Hi Yuval,
On Tuesday 26 September 2017 12:49 PM, Yuval Shaia wrote:
> On Tue, Sep 26, 2017 at 12:21:44PM +0530, Arvind Yadav wrote:
>> pr_err() messages should end with a new-line to avoid other messages
>> being concatenated.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>> drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
>> index 66056f9..e528d7a 100644
>> --- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
>> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
>> @@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
>> if (reset) {
>> status = ocrdma_mbx_rdma_stats(dev, true);
>> if (status) {
>> - pr_err("Failed to reset stats = %d", status);
>> + pr_err("Failed to reset stats = %d\n", status);
>> goto err;
>> }
>> }
> While there, can you also fix line 1096 in ocrdma_hw.c?
>
> (is it too naive to expect checkptahc to catch such errors?)
As per your suggestion, I have done the changes.
>
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
~arvind
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-09-26 17:30 +0200 |
| Message-ID | <utZY5-6wo-5@gated-at.bofh.it> |
| In reply to | #1739601 |
On Tue, 2017-09-26 at 10:19 +0300, Yuval Shaia wrote:
> On Tue, Sep 26, 2017 at 12:21:44PM +0530, Arvind Yadav wrote:
> > pr_err() messages should end with a new-line to avoid other messages
> > being concatenated.
[]
> > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
[]
> > @@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
> > if (reset) {
> > status = ocrdma_mbx_rdma_stats(dev, true);
> > if (status) {
> > - pr_err("Failed to reset stats = %d", status);
> > + pr_err("Failed to reset stats = %d\n", status);
> > goto err;
> > }
> > }
>
> While there, can you also fix line 1096 in ocrdma_hw.c?
>
> (is it too naive to expect checkptahc to catch such errors?)
Yes. It is not reasonable.
There would be way too high a false positive rate
as checkpatch could not trace whether or not there
is a printk(KERN_CONT or pr_cont after that.
[toc] | [prev] | [next] | [standalone]
| From | Doug Ledford <dledford@redhat.com> |
|---|---|
| Date | 2017-09-27 16:30 +0200 |
| Message-ID | <uulvz-4kL-3@gated-at.bofh.it> |
| In reply to | #1739576 |
On Tue, 2017-09-26 at 12:21 +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web