Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1738863 > unrolled thread

[PATCH] cpufreq: powernow-k8: pr_err() strings should end with newlines

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2017-09-25 11:50 +0200
Last post2017-09-26 01:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] cpufreq: powernow-k8: pr_err() strings should end with newlines Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-25 11:50 +0200
    Re: [PATCH] cpufreq: powernow-k8: pr_err() strings should end with  newlines Viresh Kumar <viresh.kumar@linaro.org> - 2017-09-26 01:20 +0200

#1738863 — [PATCH] cpufreq: powernow-k8: pr_err() strings should end with newlines

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-09-25 11:50 +0200
Subject[PATCH] cpufreq: powernow-k8: pr_err() strings should end with newlines
Message-ID<utybw-4yR-1@gated-at.bofh.it>
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/cpufreq/powernow-k8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
index 062d714..b01e31d 100644
--- a/drivers/cpufreq/powernow-k8.c
+++ b/drivers/cpufreq/powernow-k8.c
@@ -1043,7 +1043,7 @@ static int powernowk8_cpu_init(struct cpufreq_policy *pol)
 
 	data = kzalloc(sizeof(*data), GFP_KERNEL);
 	if (!data) {
-		pr_err("unable to alloc powernow_k8_data");
+		pr_err("unable to alloc powernow_k8_data\n");
 		return -ENOMEM;
 	}
 
-- 
1.9.1

[toc] | [next] | [standalone]


#1739333 — Re: [PATCH] cpufreq: powernow-k8: pr_err() strings should end with newlines

FromViresh Kumar <viresh.kumar@linaro.org>
Date2017-09-26 01:20 +0200
SubjectRe: [PATCH] cpufreq: powernow-k8: pr_err() strings should end with newlines
Message-ID<utKPp-4Lc-11@gated-at.bofh.it>
In reply to#1738863
On 25-09-17, 15:10, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/cpufreq/powernow-k8.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
> index 062d714..b01e31d 100644
> --- a/drivers/cpufreq/powernow-k8.c
> +++ b/drivers/cpufreq/powernow-k8.c
> @@ -1043,7 +1043,7 @@ static int powernowk8_cpu_init(struct cpufreq_policy *pol)
>  
>  	data = kzalloc(sizeof(*data), GFP_KERNEL);
>  	if (!data) {
> -		pr_err("unable to alloc powernow_k8_data");
> +		pr_err("unable to alloc powernow_k8_data\n");
>  		return -ENOMEM;
>  	}

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web