Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1738055 > unrolled thread
| Started by | Shreeya Patel <shreeya.patel23498@gmail.com> |
|---|---|
| First post | 2017-09-23 20:20 +0200 |
| Last post | 2017-09-25 18:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Documentation: DT bindings: Add chip compatible string for audio codec. Shreeya Patel <shreeya.patel23498@gmail.com> - 2017-09-23 20:20 +0200
Re: [PATCH] Documentation: DT bindings: Add chip compatible string for audio codec. Mark Brown <broonie@kernel.org> - 2017-09-25 18:00 +0200
| From | Shreeya Patel <shreeya.patel23498@gmail.com> |
|---|---|
| Date | 2017-09-23 20:20 +0200 |
| Subject | [PATCH] Documentation: DT bindings: Add chip compatible string for audio codec. |
| Message-ID | <usXbX-6tZ-1@gated-at.bofh.it> |
This patch adds chip compatible string to remove the warnings
generated by checkpatch that -DT compatible string
"toshiba,apb-dummy-codec" appears un-documented.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
---
Documentation/devicetree/bindings/sound/sirf-audio-codec.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt b/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt
index 062f5ec..a61560b 100644
--- a/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt
+++ b/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt
@@ -3,6 +3,7 @@ SiRF internal audio CODEC
Required properties:
- compatible : "sirf,atlas6-audio-codec" or "sirf,prima2-audio-codec"
+ "toshiba,apb-dummy-codec"
- reg : the register address of the device.
@@ -11,7 +12,7 @@ Required properties:
Example:
audiocodec: audiocodec@b0040000 {
- compatible = "sirf,atlas6-audio-codec";
+ compatible = "sirf,atlas6-audio-codec", "toshiba,apb-dummy-codec";
reg = <0xb0040000 0x10000>;
clocks = <&clks 27>;
};
--
2.7.4
[toc] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-09-25 18:00 +0200 |
| Subject | Re: [PATCH] Documentation: DT bindings: Add chip compatible string for audio codec. |
| Message-ID | <utDXA-8oa-19@gated-at.bofh.it> |
| In reply to | #1738055 |
[Multipart message — attachments visible in raw view] — view raw
On Sat, Sep 23, 2017 at 11:45:23PM +0530, Shreeya Patel wrote: > This patch adds chip compatible string to remove the warnings > generated by checkpatch that -DT compatible string > "toshiba,apb-dummy-codec" appears un-documented. What is this device and why does it make sense to be covered with this compatible string? The -dummy-codec makes it seem like something that has no place in a DT at all. Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web