Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1738912 > unrolled thread

[PATCH] dax: pr_err() strings should end with newlines

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2017-09-25 12:50 +0200
Last post2017-09-25 17:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] dax: pr_err() strings should end with newlines Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-25 12:50 +0200
    Re: [PATCH] dax: pr_err() strings should end with newlines Dan Williams <dan.j.williams@intel.com> - 2017-09-25 17:50 +0200

#1738912 — [PATCH] dax: pr_err() strings should end with newlines

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-09-25 12:50 +0200
Subject[PATCH] dax: pr_err() strings should end with newlines
Message-ID<utz7z-5aK-5@gated-at.bofh.it>
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/dax/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/super.c b/drivers/dax/super.c
index 557b9370..30d8a5a 100644
--- a/drivers/dax/super.c
+++ b/drivers/dax/super.c
@@ -118,7 +118,7 @@ int __bdev_dax_supported(struct super_block *sb, int blocksize)
 	put_dax(dax_dev);
 
 	if (len < 1) {
-		pr_err("VFS (%s): error: dax access failed (%ld)",
+		pr_err("VFS (%s): error: dax access failed (%ld)\n",
 				sb->s_id, len);
 		return len < 0 ? len : -EIO;
 	}
-- 
1.9.1

[toc] | [next] | [standalone]


#1739133

FromDan Williams <dan.j.williams@intel.com>
Date2017-09-25 17:50 +0200
Message-ID<utDNU-8jd-25@gated-at.bofh.it>
In reply to#1738912
On Mon, Sep 25, 2017 at 3:41 AM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thanks, applied.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web