Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1738955 > unrolled thread
| Started by | Christoph Böhmwalder <christoph@boehmwalder.at> |
|---|---|
| First post | 2017-09-25 13:40 +0200 |
| Last post | 2017-09-25 14:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH RESEND] wireless: iwlwifi: fix minor code style issues Christoph Böhmwalder <christoph@boehmwalder.at> - 2017-09-25 13:40 +0200
Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues "Coelho, Luciano" <luciano.coelho@intel.com> - 2017-09-25 13:50 +0200
Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues Christoph Böhmwalder <christoph@boehmwalder.at> - 2017-09-25 14:00 +0200
| From | Christoph Böhmwalder <christoph@boehmwalder.at> |
|---|---|
| Date | 2017-09-25 13:40 +0200 |
| Subject | [PATCH RESEND] wireless: iwlwifi: fix minor code style issues |
| Message-ID | <utzTY-5KB-27@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder <christoph@boehmwalder.at> --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c index 99676d6c4713..ccdb247d68c5 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c @@ -832,7 +832,7 @@ static int iwl_parse_tlv_firmware(struct iwl_drv *drv, capa->standard_phy_calibration_size = le32_to_cpup((__le32 *)tlv_data); break; - case IWL_UCODE_TLV_SEC_RT: + case IWL_UCODE_TLV_SEC_RT: iwl_store_ucode_sec(pieces, tlv_data, IWL_UCODE_REGULAR, tlv_len); drv->fw.type = IWL_FW_MVM; @@ -864,7 +864,7 @@ static int iwl_parse_tlv_firmware(struct iwl_drv *drv, FW_PHY_CFG_RX_CHAIN) >> FW_PHY_CFG_RX_CHAIN_POS; break; - case IWL_UCODE_TLV_SECURE_SEC_RT: + case IWL_UCODE_TLV_SECURE_SEC_RT: iwl_store_ucode_sec(pieces, tlv_data, IWL_UCODE_REGULAR, tlv_len); drv->fw.type = IWL_FW_MVM; @@ -1335,7 +1335,8 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context) /* Runtime instructions and 2 copies of data: * 1) unmodified from disk - * 2) backup cache for save/restore during power-downs */ + * 2) backup cache for save/restore during power-downs + */ for (i = 0; i < IWL_UCODE_TYPE_MAX; i++) if (iwl_alloc_ucode(drv, pieces, i)) goto out_free_fw; -- 2.13.5
[toc] | [next] | [standalone]
| From | "Coelho, Luciano" <luciano.coelho@intel.com> |
|---|---|
| Date | 2017-09-25 13:50 +0200 |
| Message-ID | <utA3D-5Ol-1@gated-at.bofh.it> |
| In reply to | #1738955 |
On Mon, 2017-09-25 at 13:37 +0200, Christoph Böhmwalder wrote: > Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder <christoph@boehmwalder.at> --- Why are you already resending this? You sent the first email 2 days ago, you can't expect that a non-critical patch be merged in such a short time (especially during the weekend). -- Cheers, Luca
[toc] | [prev] | [next] | [standalone]
| From | Christoph Böhmwalder <christoph@boehmwalder.at> |
|---|---|
| Date | 2017-09-25 14:00 +0200 |
| Message-ID | <utAdj-5RX-9@gated-at.bofh.it> |
| In reply to | #1738956 |
[Multipart message — attachments visible in raw view] — view raw
> Why are you already resending this? Sorry, I guess I was too impatient. I also messed up the spelling in a "To:" line and forgot trivial@kernel.org the first time I sent it, so I figured I'd just fix it in a resend. I'll make sure to wait a little longer next time. -- Regards, Christoph
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web