Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1737585 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-09-22 17:40 +0200 |
| Last post | 2017-09-25 10:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] b43: make const arrays static, reduces object code size Colin King <colin.king@canonical.com> - 2017-09-22 17:40 +0200
Re: b43: make const arrays static, reduces object code size Kalle Valo <kvalo@codeaurora.org> - 2017-09-25 10:40 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-09-22 17:40 +0200 |
| Subject | [PATCH] b43: make const arrays static, reduces object code size |
| Message-ID | <usydA-7Kc-9@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Don't populate const arrays on the stack, instead make them static.
Makes the object code smaller by over 60 bytes:
Before:
text data bss dec hex filename
14816 1296 0 16112 3ef0 b43/phy_ht.o
After:
text data bss dec hex filename
14551 1496 0 16047 3eaf b43/phy_ht.o
(gcc 6.3.0, x86-64)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/broadcom/b43/phy_ht.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/broadcom/b43/phy_ht.c b/drivers/net/wireless/broadcom/b43/phy_ht.c
index 718c90e81696..c3158d085c2b 100644
--- a/drivers/net/wireless/broadcom/b43/phy_ht.c
+++ b/drivers/net/wireless/broadcom/b43/phy_ht.c
@@ -119,7 +119,7 @@ static void b43_radio_2059_rcal(struct b43_wldev *dev)
/* Calibrate the internal RC oscillator? */
static void b43_radio_2057_rccal(struct b43_wldev *dev)
{
- const u16 radio_values[3][2] = {
+ static const u16 radio_values[3][2] = {
{ 0x61, 0xE9 }, { 0x69, 0xD5 }, { 0x73, 0x99 },
};
int i;
@@ -154,7 +154,7 @@ static void b43_radio_2059_init_pre(struct b43_wldev *dev)
static void b43_radio_2059_init(struct b43_wldev *dev)
{
- const u16 routing[] = { R2059_C1, R2059_C2, R2059_C3 };
+ static const u16 routing[] = { R2059_C1, R2059_C2, R2059_C3 };
int i;
/* Prepare (reset?) radio */
@@ -263,7 +263,7 @@ static void b43_phy_ht_reset_cca(struct b43_wldev *dev)
static void b43_phy_ht_zero_extg(struct b43_wldev *dev)
{
u8 i, j;
- u16 base[] = { 0x40, 0x60, 0x80 };
+ static const u16 base[] = { 0x40, 0x60, 0x80 };
for (i = 0; i < ARRAY_SIZE(base); i++) {
for (j = 0; j < 4; j++)
--
2.14.1
[toc] | [next] | [standalone]
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2017-09-25 10:40 +0200 |
| Subject | Re: b43: make const arrays static, reduces object code size |
| Message-ID | <utx5M-3Sb-13@gated-at.bofh.it> |
| In reply to | #1737585 |
Colin Ian King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Don't populate const arrays on the stack, instead make them static. > Makes the object code smaller by over 60 bytes: > > Before: > text data bss dec hex filename > 14816 1296 0 16112 3ef0 b43/phy_ht.o > > After: > text data bss dec hex filename > 14551 1496 0 16047 3eaf b43/phy_ht.o > > (gcc 6.3.0, x86-64) > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Patch applied to wireless-drivers-next.git, thanks. 96cbe3d638e4 b43: make const arrays static, reduces object code size -- https://patchwork.kernel.org/patch/9966415/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web