Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1736327 > unrolled thread

[PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings

Started byChaotian Jing <chaotian.jing@mediatek.com>
First post2017-09-21 04:00 +0200
Last post2017-09-22 14:00 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings Chaotian Jing <chaotian.jing@mediatek.com> - 2017-09-21 04:00 +0200
    Re: [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for  Mediatek MMC bindings Linus Walleij <linus.walleij@linaro.org> - 2017-09-22 13:30 +0200
      Re: [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for  Mediatek MMC bindings Chaotian Jing <chaotian.jing@mediatek.com> - 2017-09-22 14:00 +0200

#1736327 — [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings

FromChaotian Jing <chaotian.jing@mediatek.com>
Date2017-09-21 04:00 +0200
Subject[PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings
Message-ID<urYWt-2C8-1@gated-at.bofh.it>
Change the comptiable for support of multi-platform
Add description for reg
Add description for source_cg
Add description for mediatek,latch-ck
Note that source_cg and mediatek,latch-ck are optional for some projects,
eg, MT2701 do not have source_cg, and MT2712 do not need
mediatek,latch-ck

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 Documentation/devicetree/bindings/mmc/mtk-sd.txt | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
index 4182ea3..405cd06 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
@@ -7,10 +7,15 @@ This file documents differences between the core properties in mmc.txt
 and the properties used by the msdc driver.
 
 Required properties:
-- compatible: Should be "mediatek,mt8173-mmc","mediatek,mt8135-mmc"
+- compatible: value should be either of the following.
+	"mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
+	"mediatek,mt8173-mmc": for mmc host ip compatible with mt8173
+	"mediatek,mt2701-mmc": for mmc host ip compatible with mt2701
+	"mediatek,mt2712-mmc": for mmc host ip compatible with mt2712
+- reg: physical base address of the controller and length
 - interrupts: Should contain MSDC interrupt number
-- clocks: MSDC source clock, HCLK
-- clock-names: "source", "hclk"
+- clocks: MSDC source clock, HCLK, source_cg
+- clock-names: "source", "hclk", "source_cg"
 - pinctrl-names: should be "default", "state_uhs"
 - pinctrl-0: should contain default/high speed pin ctrl
 - pinctrl-1: should contain uhs mode pin ctrl
@@ -30,6 +35,8 @@ Optional properties:
 - mediatek,hs400-cmd-resp-sel-rising:  HS400 command response sample selection
 				       If present,HS400 command responses are sampled on rising edges.
 				       If not present,HS400 command responses are sampled on falling edges.
+- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc
+		     error caused by stop clock(fifo full)
 
 Examples:
 mmc0: mmc@11230000 {
-- 
1.8.1.1.dirty

[toc] | [next] | [standalone]


#1737423 — Re: [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings

FromLinus Walleij <linus.walleij@linaro.org>
Date2017-09-22 13:30 +0200
SubjectRe: [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings
Message-ID<usujE-5v6-13@gated-at.bofh.it>
In reply to#1736327
On Thu, Sep 21, 2017 at 3:52 AM, Chaotian Jing
<chaotian.jing@mediatek.com> wrote:

> +- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc
> +                    error caused by stop clock(fifo full)

I think I wrote elsewhere: replace "projects" with "systems" or "SoCs".

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]


#1737431 — Re: [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings

FromChaotian Jing <chaotian.jing@mediatek.com>
Date2017-09-22 14:00 +0200
SubjectRe: [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings
Message-ID<usuMF-5Em-3@gated-at.bofh.it>
In reply to#1737423
On Fri, 2017-09-22 at 13:25 +0200, Linus Walleij wrote:
> On Thu, Sep 21, 2017 at 3:52 AM, Chaotian Jing
> <chaotian.jing@mediatek.com> wrote:
> 
> > +- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc
> > +                    error caused by stop clock(fifo full)
> 
> I think I wrote elsewhere: replace "projects" with "systems" or "SoCs".

Sorry about that, will change to SoCs at v3.
> 
> Yours,
> Linus Walleij

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web