Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1736373 > unrolled thread

[PATCH] sound: core: Fix structure definition for X32 ABI

Started byBaolin Wang <baolin.wang@linaro.org>
First post2017-09-21 08:10 +0200
Last post2017-09-22 11:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] sound: core: Fix structure definition for X32 ABI Baolin Wang <baolin.wang@linaro.org> - 2017-09-21 08:10 +0200
    Re: [PATCH] sound: core: Fix structure definition for X32 ABI Takashi Iwai <tiwai@suse.de> - 2017-09-22 11:30 +0200

#1736373 — [PATCH] sound: core: Fix structure definition for X32 ABI

FromBaolin Wang <baolin.wang@linaro.org>
Date2017-09-21 08:10 +0200
Subject[PATCH] sound: core: Fix structure definition for X32 ABI
Message-ID<us2Qp-5sH-11@gated-at.bofh.it>
X32 ABI uses the 64bit timespec in addition to 64bit alignment of 64bit
values. We have added compat ABI for these ioctls, but this patch adds
one missing padding into 'struct snd_pcm_mmap_status_x32' to fix
incompatibilities.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
 sound/core/pcm_compat.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/core/pcm_compat.c b/sound/core/pcm_compat.c
index 10f537f..29ab480 100644
--- a/sound/core/pcm_compat.c
+++ b/sound/core/pcm_compat.c
@@ -547,6 +547,7 @@ struct snd_pcm_mmap_status_x32 {
 	u32 pad2; /* alignment */
 	struct timespec tstamp;
 	s32 suspended_state;
+	s32 pad3;
 	struct timespec audio_tstamp;
 } __packed;
 
-- 
1.7.9.5

[toc] | [next] | [standalone]


#1737330

FromTakashi Iwai <tiwai@suse.de>
Date2017-09-22 11:30 +0200
Message-ID<ussrw-4nN-11@gated-at.bofh.it>
In reply to#1736373
On Thu, 21 Sep 2017 08:03:29 +0200,
Baolin Wang wrote:
> 
> X32 ABI uses the 64bit timespec in addition to 64bit alignment of 64bit
> values. We have added compat ABI for these ioctls, but this patch adds
> one missing padding into 'struct snd_pcm_mmap_status_x32' to fix
> incompatibilities.
> 
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>

Applied, thanks.


Takashi

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web