Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1736562 > unrolled thread
| Started by | Rakesh Pandit <rakesh@tuxera.com> |
|---|---|
| First post | 2017-09-21 13:30 +0200 |
| Last post | 2017-09-25 12:20 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device Rakesh Pandit <rakesh@tuxera.com> - 2017-09-21 13:30 +0200
Re: [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device Javier González <jg@lightnvm.io> - 2017-09-22 11:00 +0200
Re: [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device Rakesh Pandit <rakesh@tuxera.com> - 2017-09-22 11:50 +0200
Re: [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device Javier González <jg@lightnvm.io> - 2017-09-22 12:10 +0200
Re: [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device Matias Bjørling <mb@lightnvm.io> - 2017-09-25 12:20 +0200
| From | Rakesh Pandit <rakesh@tuxera.com> |
|---|---|
| Date | 2017-09-21 13:30 +0200 |
| Subject | [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device |
| Message-ID | <us7Q7-kv-39@gated-at.bofh.it> |
This usually happens if we are developing with qemu and ll2pmode has
default value. Even in that case message seems wrong.
Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
---
drivers/lightnvm/pblk-init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index 470ef04..c5c1337 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -913,7 +913,7 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk,
int ret;
if (dev->identity.dom & NVM_RSP_L2P) {
- pr_err("pblk: device-side L2P table not supported. (%x)\n",
+ pr_err("pblk: device-side L2P table supported. (%x)\n",
dev->identity.dom);
return ERR_PTR(-EINVAL);
}
--
2.5.0
[toc] | [next] | [standalone]
| From | Javier González <jg@lightnvm.io> |
|---|---|
| Date | 2017-09-22 11:00 +0200 |
| Message-ID | <usrYu-3Z9-25@gated-at.bofh.it> |
| In reply to | #1736562 |
[Multipart message — attachments visible in raw view] — view raw
> On 21 Sep 2017, at 13.26, Rakesh Pandit <rakesh@tuxera.com> wrote:
>
> This usually happens if we are developing with qemu and ll2pmode has
> default value. Even in that case message seems wrong.
>
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> ---
> drivers/lightnvm/pblk-init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
> index 470ef04..c5c1337 100644
> --- a/drivers/lightnvm/pblk-init.c
> +++ b/drivers/lightnvm/pblk-init.c
> @@ -913,7 +913,7 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk,
> int ret;
>
> if (dev->identity.dom & NVM_RSP_L2P) {
> - pr_err("pblk: device-side L2P table not supported. (%x)\n",
> + pr_err("pblk: device-side L2P table supported. (%x)\n",
> dev->identity.dom);
> return ERR_PTR(-EINVAL);
> }
> --
> 2.5.0
You're right. This is inherited from rrpc.
Can we instead write "pblk: full host-side L2P table not supported"?
People will not know about the hybrid device/host L2P as time goes by
and it will just be confusing. I'm not even sure this will be part of
the 2.0 spec, so it will probably go away with time...
Javier
[toc] | [prev] | [next] | [standalone]
| From | Rakesh Pandit <rakesh@tuxera.com> |
|---|---|
| Date | 2017-09-22 11:50 +0200 |
| Message-ID | <ussKS-4u6-21@gated-at.bofh.it> |
| In reply to | #1737295 |
On Fri, Sep 22, 2017 at 10:52:19AM +0200, Javier González wrote:
> > On 21 Sep 2017, at 13.26, Rakesh Pandit <rakesh@tuxera.com> wrote:
> >
> > This usually happens if we are developing with qemu and ll2pmode has
> > default value. Even in that case message seems wrong.
> >
> > Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> > ---
> > drivers/lightnvm/pblk-init.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
> > index 470ef04..c5c1337 100644
> > --- a/drivers/lightnvm/pblk-init.c
> > +++ b/drivers/lightnvm/pblk-init.c
> > @@ -913,7 +913,7 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk,
> > int ret;
> >
> > if (dev->identity.dom & NVM_RSP_L2P) {
> > - pr_err("pblk: device-side L2P table not supported. (%x)\n",
> > + pr_err("pblk: device-side L2P table supported. (%x)\n",
> > dev->identity.dom);
> > return ERR_PTR(-EINVAL);
> > }
> > --
> > 2.5.0
>
> You're right. This is inherited from rrpc.
>
> Can we instead write "pblk: full host-side L2P table not supported"?
> People will not know about the hybrid device/host L2P as time goes by
> and it will just be confusing. I'm not even sure this will be part of
> the 2.0 spec, so it will probably go away with time...
>
Sure. I was confused the first time. This is better.
It would be great if this is done while picking up. I can repost as
well if need be.
Thanks,
[toc] | [prev] | [next] | [standalone]
| From | Javier González <jg@lightnvm.io> |
|---|---|
| Date | 2017-09-22 12:10 +0200 |
| Message-ID | <ust4f-4Qp-35@gated-at.bofh.it> |
| In reply to | #1737347 |
[Multipart message — attachments visible in raw view] — view raw
Sure.
Matias: Can you fix this when picking it up?
Javier
> On 22 Sep 2017, at 11.44, Rakesh Pandit <rakesh@tuxera.com> wrote:
>
> On Fri, Sep 22, 2017 at 10:52:19AM +0200, Javier González wrote:
>>> On 21 Sep 2017, at 13.26, Rakesh Pandit <rakesh@tuxera.com> wrote:
>>>
>>> This usually happens if we are developing with qemu and ll2pmode has
>>> default value. Even in that case message seems wrong.
>>>
>>> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
>>> ---
>>> drivers/lightnvm/pblk-init.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
>>> index 470ef04..c5c1337 100644
>>> --- a/drivers/lightnvm/pblk-init.c
>>> +++ b/drivers/lightnvm/pblk-init.c
>>> @@ -913,7 +913,7 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk,
>>> int ret;
>>>
>>> if (dev->identity.dom & NVM_RSP_L2P) {
>>> - pr_err("pblk: device-side L2P table not supported. (%x)\n",
>>> + pr_err("pblk: device-side L2P table supported. (%x)\n",
>>> dev->identity.dom);
>>> return ERR_PTR(-EINVAL);
>>> }
>>> --
>>> 2.5.0
>>
>> You're right. This is inherited from rrpc.
>>
>> Can we instead write "pblk: full host-side L2P table not supported"?
>> People will not know about the hybrid device/host L2P as time goes by
>> and it will just be confusing. I'm not even sure this will be part of
>> the 2.0 spec, so it will probably go away with time...
>
> Sure. I was confused the first time. This is better.
>
> It would be great if this is done while picking up. I can repost as
> well if need be.
>
> Thanks,
[toc] | [prev] | [next] | [standalone]
| From | Matias Bjørling <mb@lightnvm.io> |
|---|---|
| Date | 2017-09-25 12:20 +0200 |
| Message-ID | <utyEy-4YG-15@gated-at.bofh.it> |
| In reply to | #1737295 |
On 09/22/2017 10:52 AM, Javier González wrote:
>> On 21 Sep 2017, at 13.26, Rakesh Pandit <rakesh@tuxera.com> wrote:
>>
>> This usually happens if we are developing with qemu and ll2pmode has
>> default value. Even in that case message seems wrong.
>>
>> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
>> ---
>> drivers/lightnvm/pblk-init.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
>> index 470ef04..c5c1337 100644
>> --- a/drivers/lightnvm/pblk-init.c
>> +++ b/drivers/lightnvm/pblk-init.c
>> @@ -913,7 +913,7 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk,
>> int ret;
>>
>> if (dev->identity.dom & NVM_RSP_L2P) {
>> - pr_err("pblk: device-side L2P table not supported. (%x)\n",
>> + pr_err("pblk: device-side L2P table supported. (%x)\n",
>> dev->identity.dom);
>> return ERR_PTR(-EINVAL);
>> }
>> --
>> 2.5.0
>
> You're right. This is inherited from rrpc.
>
> Can we instead write "pblk: full host-side L2P table not supported"?
> People will not know about the hybrid device/host L2P as time goes by
> and it will just be confusing. I'm not even sure this will be part of
> the 2.0 spec, so it will probably go away with time...
>
> Javier
>
Thanks, I picked it up.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web