Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736866 > unrolled thread

[PATCH 00/64] use setup_timer() helper function.

Started byAllen Pais <allen.lkml@gmail.com>
First post2017-09-21 19:10 +0200
Last post2017-09-22 08:30 +0200
Articles 20 on this page of 61 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/64] use setup_timer() helper function. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 24/64] drivers: net: enic: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 16/64] drivers: net: tg3: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 15/64] drivers: net: sundance: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 12/64] drivers: net: atp: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 03/64] drivers: net: pcnet32: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 29/64] drivers: net: smsc: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 30/64] drivers: net: qlogic: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 35/64] drivers: net: can: usb: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 27/64] drivers: net: atmel: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 06/64] drivers: net: bcm63xx: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 07/64] drivers: net: declance: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 11/64] drivers: net: rsi_91x: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 05/64] drivers : net: niu: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 38/64] drivers: net: ath6kl: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 17/64] drivers: net: sdla: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 25/64] drivers: net: bnx2: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 19/64] drivers: net: slip: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 10/64] drivers: net: appletalk: cops: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 14/64] drivers: net: ixgb: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 20/64] drivers: net: spider_net: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 36/64] drivers: net: can: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 22/64] drivers: net: natsemi: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 01/64] drivers: net: de4x: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 33/64] drivers: net: amd8111e: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 28/64] drivers: net: hippi: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 13/64] drivers: net: ns83820: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 04/64] drivers: net: brcm80211: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 02/64] drivers: net: b44: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 31/64] drivers: net: e1000e: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 26/64] drivers: net: xen-netback: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 37/64] drivers: net: arcnet: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
    [PATCH 55/64] drivers: net: hamradio: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 40/64] drivers: net: sis900: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 42/64] drivers: net: mlx5: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 58/64] drivers: net: packetengines: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 56/64] drivers: net: cpsw_ale: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 60/64] drivers: net: uli526x: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 62/64] drivers: net: cxgb: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 43/64] drivers: net: mlx4: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 59/64] drivers: net: i40evf: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 39/64] drivers: net: sun: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 54/64] drivers: net: hdlc_ppp: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 52/64] drivers: net: appletalk: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 46/64] drivers: net: dmfe: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 51/64] drivers: net: caif: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 64/64] drivers: net: lmc: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 57/64] drivers: net: stmmac: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 49/64] drivers: net: adi: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 63/64] drivers: net: bnx2x: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 50/64] drivers: net: can: sja1000: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 61/64] drivers: net: enic: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 53/64] drivers: net: dscc: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 41/64] drivers: net: packetengines: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
    [PATCH 44/64] drivers: net: pxa168: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:30 +0200
    [PATCH 48/64] drivers: net: amd: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:30 +0200
    [PATCH 45/64] drivers: net: fealnx: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:30 +0200
    [PATCH 47/64] drivers: net: bnxt: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:30 +0200
    [PATCH 08/64] drivers: net: am79c961: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:40 +0200
    Re: [PATCH 00/64] use setup_timer() helper function. David Miller <davem@davemloft.net> - 2017-09-21 20:40 +0200
      Re: [PATCH 00/64] use setup_timer() helper function. Allen <allen.lkml@gmail.com> - 2017-09-22 08:30 +0200

Page 3 of 4 — ← Prev page 1 2 [3] 4  Next page →

#1736911 — [PATCH 59/64] drivers: net: i40evf: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 59/64] drivers: net: i40evf: use setup_timer() helper.
Message-ID<usdiP-3Se-31@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/intel/i40evf/i40evf_main.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index 1825d95..c243f9d 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -2686,9 +2686,8 @@ static void i40evf_init_task(struct work_struct *work)
 		ether_addr_copy(netdev->perm_addr, adapter->hw.mac.addr);
 	}
 
-	init_timer(&adapter->watchdog_timer);
-	adapter->watchdog_timer.function = &i40evf_watchdog_timer;
-	adapter->watchdog_timer.data = (unsigned long)adapter;
+	setup_timer(&adapter->watchdog_timer, &i40evf_watchdog_timer,
+		    (unsigned long)adapter);
 	mod_timer(&adapter->watchdog_timer, jiffies + 1);
 
 	adapter->tx_desc_count = I40EVF_DEFAULT_TXD;
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736913 — [PATCH 39/64] drivers: net: sun: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 39/64] drivers: net: sun: use setup_timer() helper.
Message-ID<usdiP-3Se-35@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/sun/sungem.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c
index fa607d0..b75ab8f 100644
--- a/drivers/net/ethernet/sun/sungem.c
+++ b/drivers/net/ethernet/sun/sungem.c
@@ -2910,9 +2910,7 @@ static int gem_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	gp->msg_enable = DEFAULT_MSG;
 
-	init_timer(&gp->link_timer);
-	gp->link_timer.function = gem_link_timer;
-	gp->link_timer.data = (unsigned long) gp;
+	setup_timer(&gp->link_timer, gem_link_timer, (unsigned long)gp);
 
 	INIT_WORK(&gp->reset_task, gem_reset_task);
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736916 — [PATCH 54/64] drivers: net: hdlc_ppp: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 54/64] drivers: net: hdlc_ppp: use setup_timer() helper.
Message-ID<usdiP-3Se-37@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/wan/hdlc_ppp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c
index 0d2e00e..c7721c7 100644
--- a/drivers/net/wan/hdlc_ppp.c
+++ b/drivers/net/wan/hdlc_ppp.c
@@ -610,9 +610,7 @@ static void ppp_start(struct net_device *dev)
 	for (i = 0; i < IDX_COUNT; i++) {
 		struct proto *proto = &ppp->protos[i];
 		proto->dev = dev;
-		init_timer(&proto->timer);
-		proto->timer.function = ppp_timer;
-		proto->timer.data = (unsigned long)proto;
+		setup_timer(&proto->timer, ppp_timer, (unsigned long)proto);
 		proto->state = CLOSED;
 	}
 	ppp->protos[IDX_LCP].pid = PID_LCP;
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736917 — [PATCH 52/64] drivers: net: appletalk: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 52/64] drivers: net: appletalk: use setup_timer() helper.
Message-ID<usdiP-3Se-43@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/appletalk/ltpc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/appletalk/ltpc.c b/drivers/net/appletalk/ltpc.c
index ac755d2..e4aa374 100644
--- a/drivers/net/appletalk/ltpc.c
+++ b/drivers/net/appletalk/ltpc.c
@@ -1165,9 +1165,7 @@ struct net_device * __init ltpc_probe(void)
 		dev->irq = 0;
 		/* polled mode -- 20 times per second */
 		/* this is really, really slow... should it poll more often? */
-		init_timer(&ltpc_timer);
-		ltpc_timer.function=ltpc_poll;
-		ltpc_timer.data = (unsigned long) dev;
+		setup_timer(&ltpc_timer, ltpc_poll, (unsigned long)dev);
 
 		ltpc_timer.expires = jiffies + HZ/20;
 		add_timer(&ltpc_timer);
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736919 — [PATCH 46/64] drivers: net: dmfe: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 46/64] drivers: net: dmfe: use setup_timer() helper.
Message-ID<usdiP-3Se-41@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/dec/tulip/dmfe.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/dec/tulip/dmfe.c b/drivers/net/ethernet/dec/tulip/dmfe.c
index 07e10a4..6585f73 100644
--- a/drivers/net/ethernet/dec/tulip/dmfe.c
+++ b/drivers/net/ethernet/dec/tulip/dmfe.c
@@ -596,10 +596,8 @@ static int dmfe_open(struct net_device *dev)
 	netif_wake_queue(dev);
 
 	/* set and active a timer process */
-	init_timer(&db->timer);
+	setup_timer(&db->timer, dmfe_timer, (unsigned long)dev);
 	db->timer.expires = DMFE_TIMER_WUT + HZ * 2;
-	db->timer.data = (unsigned long)dev;
-	db->timer.function = dmfe_timer;
 	add_timer(&db->timer);
 
 	return 0;
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736921 — [PATCH 51/64] drivers: net: caif: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 51/64] drivers: net: caif: use setup_timer() helper.
Message-ID<usdiP-3Se-51@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/caif/caif_hsi.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/net/caif/caif_hsi.c b/drivers/net/caif/caif_hsi.c
index 438966b..fed75e7 100644
--- a/drivers/net/caif/caif_hsi.c
+++ b/drivers/net/caif/caif_hsi.c
@@ -1211,17 +1211,14 @@ static int cfhsi_open(struct net_device *ndev)
 	init_waitqueue_head(&cfhsi->flush_fifo_wait);
 
 	/* Setup the inactivity timer. */
-	init_timer(&cfhsi->inactivity_timer);
-	cfhsi->inactivity_timer.data = (unsigned long)cfhsi;
-	cfhsi->inactivity_timer.function = cfhsi_inactivity_tout;
+	setup_timer(&cfhsi->inactivity_timer, cfhsi_inactivity_tout,
+		    (unsigned long)cfhsi);
 	/* Setup the slowpath RX timer. */
-	init_timer(&cfhsi->rx_slowpath_timer);
-	cfhsi->rx_slowpath_timer.data = (unsigned long)cfhsi;
-	cfhsi->rx_slowpath_timer.function = cfhsi_rx_slowpath;
+	setup_timer(&cfhsi->rx_slowpath_timer, cfhsi_rx_slowpath,
+		    (unsigned long)cfhsi);
 	/* Setup the aggregation timer. */
-	init_timer(&cfhsi->aggregation_timer);
-	cfhsi->aggregation_timer.data = (unsigned long)cfhsi;
-	cfhsi->aggregation_timer.function = cfhsi_aggregation_tout;
+	setup_timer(&cfhsi->aggregation_timer, cfhsi_aggregation_tout,
+		    (unsigned long)cfhsi);
 
 	/* Activate HSI interface. */
 	res = cfhsi->ops->cfhsi_up(cfhsi->ops);
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736924 — [PATCH 64/64] drivers: net: lmc: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 64/64] drivers: net: lmc: use setup_timer() helper.
Message-ID<usdiQ-3Se-57@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/wan/lmc/lmc_main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
index 4698450..ae69d65 100644
--- a/drivers/net/wan/lmc/lmc_main.c
+++ b/drivers/net/wan/lmc/lmc_main.c
@@ -1084,10 +1084,8 @@ static int lmc_open(struct net_device *dev)
      * Setup a timer for the watchdog on probe, and start it running.
      * Since lmc_ok == 0, it will be a NOP for now.
      */
-    init_timer (&sc->timer);
+    setup_timer(&sc->timer, lmc_watchdog, (unsigned long)dev);
     sc->timer.expires = jiffies + HZ;
-    sc->timer.data = (unsigned long) dev;
-    sc->timer.function = lmc_watchdog;
     add_timer (&sc->timer);
 
     lmc_trace(dev, "lmc_open out");
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736925 — [PATCH 57/64] drivers: net: stmmac: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 57/64] drivers: net: stmmac: use setup_timer() helper.
Message-ID<usdiQ-3Se-59@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 1763e48..f41661a 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -2217,10 +2217,8 @@ static void stmmac_init_tx_coalesce(struct stmmac_priv *priv)
 {
 	priv->tx_coal_frames = STMMAC_TX_FRAMES;
 	priv->tx_coal_timer = STMMAC_COAL_TX_TIMER;
-	init_timer(&priv->txtimer);
+	setup_timer(&priv->txtimer, stmmac_tx_timer, (unsigned long)priv);
 	priv->txtimer.expires = STMMAC_COAL_TIMER(priv->tx_coal_timer);
-	priv->txtimer.data = (unsigned long)priv;
-	priv->txtimer.function = stmmac_tx_timer;
 	add_timer(&priv->txtimer);
 }
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736927 — [PATCH 49/64] drivers: net: adi: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 49/64] drivers: net: adi: use setup_timer() helper.
Message-ID<usdiP-3Se-53@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/adi/bfin_mac.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c
index a251de8..0658cde 100644
--- a/drivers/net/ethernet/adi/bfin_mac.c
+++ b/drivers/net/ethernet/adi/bfin_mac.c
@@ -1650,9 +1650,8 @@ static int bfin_mac_probe(struct platform_device *pdev)
 	ndev->netdev_ops = &bfin_mac_netdev_ops;
 	ndev->ethtool_ops = &bfin_mac_ethtool_ops;
 
-	init_timer(&lp->tx_reclaim_timer);
-	lp->tx_reclaim_timer.data = (unsigned long)lp;
-	lp->tx_reclaim_timer.function = tx_reclaim_skb_timeout;
+	setup_timer(&lp->tx_reclaim_timer, tx_reclaim_skb_timeout,
+		    (unsigned long)lp);
 
 	lp->flags = 0;
 	netif_napi_add(ndev, &lp->napi, bfin_mac_poll, CONFIG_BFIN_RX_DESC_NUM);
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736928 — [PATCH 63/64] drivers: net: bnx2x: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 63/64] drivers: net: bnx2x: use setup_timer() helper.
Message-ID<usdiQ-3Se-61@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index c12b4d3..54d15713 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -12414,10 +12414,8 @@ static int bnx2x_init_bp(struct bnx2x *bp)
 
 	bp->current_interval = CHIP_REV_IS_SLOW(bp) ? 5*HZ : HZ;
 
-	init_timer(&bp->timer);
+	setup_timer(&bp->timer, bnx2x_timer, (unsigned long)bp);
 	bp->timer.expires = jiffies + bp->current_interval;
-	bp->timer.data = (unsigned long) bp;
-	bp->timer.function = bnx2x_timer;
 
 	if (SHMEM2_HAS(bp, dcbx_lldp_params_offset) &&
 	    SHMEM2_HAS(bp, dcbx_lldp_dcbx_stat_offset) &&
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736930 — [PATCH 50/64] drivers: net: can: sja1000: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 50/64] drivers: net: can: sja1000: use setup_timer() helper.
Message-ID<usdiQ-3Se-63@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/can/sja1000/peak_pcmcia.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/can/sja1000/peak_pcmcia.c b/drivers/net/can/sja1000/peak_pcmcia.c
index dd56133..4b8758e 100644
--- a/drivers/net/can/sja1000/peak_pcmcia.c
+++ b/drivers/net/can/sja1000/peak_pcmcia.c
@@ -692,9 +692,7 @@ static int pcan_probe(struct pcmcia_device *pdev)
 	}
 
 	/* init the timer which controls the leds */
-	init_timer(&card->led_timer);
-	card->led_timer.function = pcan_led_timer;
-	card->led_timer.data = (unsigned long)card;
+	setup_timer(&card->led_timer, pcan_led_timer, (unsigned long)card);
 
 	/* request the given irq */
 	err = request_irq(pdev->irq, &pcan_isr, IRQF_SHARED, PCC_NAME, card);
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736931 — [PATCH 61/64] drivers: net: enic: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 61/64] drivers: net: enic: use setup_timer() helper.
Message-ID<usdiQ-3Se-67@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/cisco/enic/enic_clsf.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/cisco/enic/enic_clsf.h b/drivers/net/ethernet/cisco/enic/enic_clsf.h
index 6aa9f89..4bfbf25 100644
--- a/drivers/net/ethernet/cisco/enic/enic_clsf.h
+++ b/drivers/net/ethernet/cisco/enic/enic_clsf.h
@@ -19,9 +19,8 @@ void enic_flow_may_expire(unsigned long data);
 
 static inline void enic_rfs_timer_start(struct enic *enic)
 {
-	init_timer(&enic->rfs_h.rfs_may_expire);
-	enic->rfs_h.rfs_may_expire.function = enic_flow_may_expire;
-	enic->rfs_h.rfs_may_expire.data = (unsigned long)enic;
+	setup_timer(&enic->rfs_h.rfs_may_expire, enic_flow_may_expire,
+		    (unsigned long)enic);
 	mod_timer(&enic->rfs_h.rfs_may_expire, jiffies + HZ/4);
 }
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736934 — [PATCH 53/64] drivers: net: dscc: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 53/64] drivers: net: dscc: use setup_timer() helper.
Message-ID<usdiQ-3Se-75@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/wan/dscc4.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c
index a043fb1..64f1764 100644
--- a/drivers/net/wan/dscc4.c
+++ b/drivers/net/wan/dscc4.c
@@ -1127,10 +1127,8 @@ static int dscc4_open(struct net_device *dev)
 done:
 	netif_start_queue(dev);
 
-        init_timer(&dpriv->timer);
+	setup_timer(&dpriv->timer, dscc4_timer, (unsigned long)dev);
         dpriv->timer.expires = jiffies + 10*HZ;
-        dpriv->timer.data = (unsigned long)dev;
-	dpriv->timer.function = dscc4_timer;
         add_timer(&dpriv->timer);
 	netif_carrier_on(dev);
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736938 — [PATCH 41/64] drivers: net: packetengines: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:20 +0200
Subject[PATCH 41/64] drivers: net: packetengines: use setup_timer() helper.
Message-ID<usdiR-3Se-81@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/packetengines/yellowfin.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/packetengines/yellowfin.c b/drivers/net/ethernet/packetengines/yellowfin.c
index fa7770d..33c241f 100644
--- a/drivers/net/ethernet/packetengines/yellowfin.c
+++ b/drivers/net/ethernet/packetengines/yellowfin.c
@@ -632,10 +632,8 @@ static int yellowfin_open(struct net_device *dev)
 	}
 
 	/* Set the timer to check for link beat. */
-	init_timer(&yp->timer);
+	setup_timer(&yp->timer, yellowfin_timer, (unsigned long)dev);
 	yp->timer.expires = jiffies + 3*HZ;
-	yp->timer.data = (unsigned long)dev;
-	yp->timer.function = yellowfin_timer;				/* timer handler */
 	add_timer(&yp->timer);
 out:
 	return rc;
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736940 — [PATCH 44/64] drivers: net: pxa168: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:30 +0200
Subject[PATCH 44/64] drivers: net: pxa168: use setup_timer() helper.
Message-ID<usdst-3Vx-5@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/marvell/pxa168_eth.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c
index 9937249..91b1c15 100644
--- a/drivers/net/ethernet/marvell/pxa168_eth.c
+++ b/drivers/net/ethernet/marvell/pxa168_eth.c
@@ -1496,9 +1496,8 @@ static int pxa168_eth_probe(struct platform_device *pdev)
 	netif_napi_add(dev, &pep->napi, pxa168_rx_poll, pep->rx_ring_size);
 
 	memset(&pep->timeout, 0, sizeof(struct timer_list));
-	init_timer(&pep->timeout);
-	pep->timeout.function = rxq_refill_timer_wrapper;
-	pep->timeout.data = (unsigned long)pep;
+	setup_timer(&pep->timeout, rxq_refill_timer_wrapper,
+		    (unsigned long)pep);
 
 	pep->smi_bus = mdiobus_alloc();
 	if (!pep->smi_bus) {
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736954 — [PATCH 48/64] drivers: net: amd: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:30 +0200
Subject[PATCH 48/64] drivers: net: amd: use setup_timer() helper.
Message-ID<usdsu-3Vx-31@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/amd/a2065.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/amd/a2065.c b/drivers/net/ethernet/amd/a2065.c
index e22f976..998d30e 100644
--- a/drivers/net/ethernet/amd/a2065.c
+++ b/drivers/net/ethernet/amd/a2065.c
@@ -733,10 +733,9 @@ static int a2065_init_one(struct zorro_dev *z,
 	dev->watchdog_timeo = 5*HZ;
 	dev->dma = 0;
 
-	init_timer(&priv->multicast_timer);
-	priv->multicast_timer.data = (unsigned long) dev;
-	priv->multicast_timer.function =
-		(void (*)(unsigned long))lance_set_multicast;
+	setup_timer(&priv->multicast_timer,
+		    (void(*)(unsigned long))lance_set_multicast,
+		    (unsigned long)dev);
 
 	err = register_netdev(dev);
 	if (err) {
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736963 — [PATCH 45/64] drivers: net: fealnx: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:30 +0200
Subject[PATCH 45/64] drivers: net: fealnx: use setup_timer() helper.
Message-ID<usdsv-3Vx-55@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/fealnx.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/fealnx.c b/drivers/net/ethernet/fealnx.c
index e92859d..c898231 100644
--- a/drivers/net/ethernet/fealnx.c
+++ b/drivers/net/ethernet/fealnx.c
@@ -909,17 +909,13 @@ static int netdev_open(struct net_device *dev)
 		printk(KERN_DEBUG "%s: Done netdev_open().\n", dev->name);
 
 	/* Set the timer to check for link beat. */
-	init_timer(&np->timer);
+	setup_timer(&np->timer, netdev_timer, (unsigned long)dev);
 	np->timer.expires = RUN_AT(3 * HZ);
-	np->timer.data = (unsigned long) dev;
-	np->timer.function = netdev_timer;
 
 	/* timer handler */
 	add_timer(&np->timer);
 
-	init_timer(&np->reset_timer);
-	np->reset_timer.data = (unsigned long) dev;
-	np->reset_timer.function = reset_timer;
+	setup_timer(&np->reset_timer, reset_timer, (unsigned long)dev);
 	np->reset_timer_armed = 0;
 	return rc;
 }
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736964 — [PATCH 47/64] drivers: net: bnxt: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:30 +0200
Subject[PATCH 47/64] drivers: net: bnxt: use setup_timer() helper.
Message-ID<usdsv-3Vx-57@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index aacec8b..c25f5b5 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -7190,9 +7190,7 @@ static int bnxt_init_board(struct pci_dev *pdev, struct net_device *dev)
 
 	bp->stats_coal_ticks = BNXT_DEF_STATS_COAL_TICKS;
 
-	init_timer(&bp->timer);
-	bp->timer.data = (unsigned long)bp;
-	bp->timer.function = bnxt_timer;
+	setup_timer(&bp->timer, bnxt_timer, (unsigned long)bp);
 	bp->current_interval = BNXT_TIMER_INTERVAL;
 
 	clear_bit(BNXT_STATE_OPEN, &bp->state);
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1736974 — [PATCH 08/64] drivers: net: am79c961: use setup_timer() helper.

FromAllen Pais <allen.lkml@gmail.com>
Date2017-09-21 19:40 +0200
Subject[PATCH 08/64] drivers: net: am79c961: use setup_timer() helper.
Message-ID<usdCa-3YA-29@gated-at.bofh.it>
In reply to#1736866
    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/amd/am79c961a.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/amd/am79c961a.c b/drivers/net/ethernet/amd/am79c961a.c
index b11e910..0612dbe 100644
--- a/drivers/net/ethernet/amd/am79c961a.c
+++ b/drivers/net/ethernet/amd/am79c961a.c
@@ -728,9 +728,7 @@ static int am79c961_probe(struct platform_device *pdev)
 	am79c961_banner();
 
 	spin_lock_init(&priv->chip_lock);
-	init_timer(&priv->timer);
-	priv->timer.data = (unsigned long)dev;
-	priv->timer.function = am79c961_timer;
+	setup_timer(&priv->timer, am79c961_timer, (unsigned long)dev);
 
 	if (am79c961_hw_init(dev))
 		goto release;
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1737003

FromDavid Miller <davem@davemloft.net>
Date2017-09-21 20:40 +0200
Message-ID<useyd-4up-3@gated-at.bofh.it>
In reply to#1736866
From: Allen Pais <allen.lkml@gmail.com>
Date: Thu, 21 Sep 2017 22:34:21 +0530

>  This series uses setup_timer() helper function. The series
> addresses the files under drivers/net/*.

I've reviewed this series and will apply it to net-next.

But please send out smaller chunks next time, maybe 10-15
in a bunch?  64 patches at once makes it really hard for
reviewiers.

Thanks.

[toc] | [prev] | [next] | [standalone]

Page 3 of 4 — ← Prev page 1 2 [3] 4  Next page →

Back to top | Article view | linux.kernel

csiph-web