Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1731648 > unrolled thread
| Started by | "Baicar, Tyler" <tbaicar@codeaurora.org> |
|---|---|
| First post | 2017-09-13 16:50 +0200 |
| Last post | 2017-09-21 17:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH V3] acpi: apei: clear error status before acknowledging the error "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-09-13 16:50 +0200
Re: [PATCH V3] acpi: apei: clear error status before acknowledging the error Tyler Baicar <tbaicar@codeaurora.org> - 2017-09-21 17:30 +0200
| From | "Baicar, Tyler" <tbaicar@codeaurora.org> |
|---|---|
| Date | 2017-09-13 16:50 +0200 |
| Subject | Re: [PATCH V3] acpi: apei: clear error status before acknowledging the error |
| Message-ID | <uph9g-aN-13@gated-at.bofh.it> |
On 8/29/2017 2:16 AM, Borislav Petkov wrote: > On Mon, Aug 28, 2017 at 10:53:41AM -0600, Tyler Baicar wrote: >> Currently we acknowledge errors before clearing the error status. >> This could cause a new error to be populated by firmware in-between >> the error acknowledgment and the error status clearing which would >> cause the second error's status to be cleared without being handled. >> So, clear the error status before acknowledging the errors. >> >> Also, make sure to acknowledge the error if the error status read >> fails. >> >> V3: Seperate check for -ENOENT return value >> >> V2: Only send error ack if there was an error populated >> Remove curly braces that are no longer needed >> >> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org> >> --- >> drivers/acpi/apei/ghes.c | 16 +++++++++------- >> 1 file changed, 9 insertions(+), 7 deletions(-) > Reviewed-by: Borislav Petkov <bp@suse.de> Hello Rafael, Were you able to apply this patch? Thanks, Tyler -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
[toc] | [next] | [standalone]
| From | Tyler Baicar <tbaicar@codeaurora.org> |
|---|---|
| Date | 2017-09-21 17:30 +0200 |
| Message-ID | <usbAm-2Ne-15@gated-at.bofh.it> |
| In reply to | #1731648 |
On 9/13/2017 8:40 AM, Baicar, Tyler wrote: > On 8/29/2017 2:16 AM, Borislav Petkov wrote: >> On Mon, Aug 28, 2017 at 10:53:41AM -0600, Tyler Baicar wrote: >>> Currently we acknowledge errors before clearing the error status. >>> This could cause a new error to be populated by firmware in-between >>> the error acknowledgment and the error status clearing which would >>> cause the second error's status to be cleared without being handled. >>> So, clear the error status before acknowledging the errors. >>> >>> Also, make sure to acknowledge the error if the error status read >>> fails. >>> >>> V3: Seperate check for -ENOENT return value >>> >>> V2: Only send error ack if there was an error populated >>> Remove curly braces that are no longer needed >>> >>> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org> >>> --- >>> drivers/acpi/apei/ghes.c | 16 +++++++++------- >>> 1 file changed, 9 insertions(+), 7 deletions(-) >> Reviewed-by: Borislav Petkov <bp@suse.de> > Hello Rafael, > > Were you able to apply this patch? I haven't heard anything on this patch. It would be great to have it in 4.14 :) Thanks, Tyler
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web