Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1736010 > unrolled thread
| Started by | Wolfram Sang <wsa+renesas@sang-engineering.com> |
|---|---|
| First post | 2017-09-20 21:10 +0200 |
| Last post | 2017-09-21 16:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE Wolfram Sang <wsa+renesas@sang-engineering.com> - 2017-09-20 21:10 +0200
Re: [RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE Jonathan Cameron <Jonathan.Cameron@huawei.com> - 2017-09-21 16:20 +0200
Re: [RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE Wolfram Sang <wsa@the-dreams.de> - 2017-09-21 16:30 +0200
| From | Wolfram Sang <wsa+renesas@sang-engineering.com> |
|---|---|
| Date | 2017-09-20 21:10 +0200 |
| Subject | [RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE |
| Message-ID | <urSxH-79x-5@gated-at.bofh.it> |
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/i2c-dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index 6f638bbc922db4..bbc7aadb4c899d 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -280,6 +280,8 @@ static noinline int i2cdev_ioctl_rdwr(struct i2c_client *client, res = PTR_ERR(rdwr_pa[i].buf); break; } + /* memdup_user allocates with GFP_KERNEL, so DMA is ok */ + rdwr_pa[i].flags |= I2C_M_DMA_SAFE; /* * If the message length is received from the slave (similar -- 2.11.0
[toc] | [next] | [standalone]
| From | Jonathan Cameron <Jonathan.Cameron@huawei.com> |
|---|---|
| Date | 2017-09-21 16:20 +0200 |
| Message-ID | <usauC-25s-15@gated-at.bofh.it> |
| In reply to | #1736010 |
On Wed, 20 Sep 2017 20:59:56 +0200 Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Makes sense as do the other drivers. Feel free to add Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> to all of them (though they hardly took a lot of reviewing given how simple the patches were :) > --- > drivers/i2c/i2c-dev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c > index 6f638bbc922db4..bbc7aadb4c899d 100644 > --- a/drivers/i2c/i2c-dev.c > +++ b/drivers/i2c/i2c-dev.c > @@ -280,6 +280,8 @@ static noinline int i2cdev_ioctl_rdwr(struct i2c_client *client, > res = PTR_ERR(rdwr_pa[i].buf); > break; > } > + /* memdup_user allocates with GFP_KERNEL, so DMA is ok */ > + rdwr_pa[i].flags |= I2C_M_DMA_SAFE; > > /* > * If the message length is received from the slave (similar
[toc] | [prev] | [next] | [standalone]
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2017-09-21 16:30 +0200 |
| Message-ID | <usaEh-297-7@gated-at.bofh.it> |
| In reply to | #1736702 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Sep 21, 2017 at 03:17:44PM +0100, Jonathan Cameron wrote: > On Wed, 20 Sep 2017 20:59:56 +0200 > Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > Makes sense as do the other drivers. > > Feel free to add > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > to all of them (though they hardly took a lot of reviewing given how simple > the patches were :) Well, bugs can slip in everywhere, so thanks for the review!
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web