Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1737018 > unrolled thread

Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge

Started byMoritz Fischer <mdf@kernel.org>
First post2017-09-21 21:10 +0200
Last post2017-09-23 04:00 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for  fpga-bridge Moritz Fischer <mdf@kernel.org> - 2017-09-21 21:10 +0200
    Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge Alan Tull <atull@kernel.org> - 2017-09-21 22:00 +0200
      Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for  fpga-bridge Wu Hao <hao.wu@intel.com> - 2017-09-22 04:30 +0200
        Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge Alan Tull <atull@kernel.org> - 2017-09-23 04:00 +0200

#1737018 — Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge

FromMoritz Fischer <mdf@kernel.org>
Date2017-09-21 21:10 +0200
SubjectRe: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge
Message-ID<usf1g-4Ud-19@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Mon, Jun 26, 2017 at 09:51:59AM +0800, Wu Hao wrote:
> This patch removes OF dependency of fpga-bridge, it allows drivers
> to use fpga-bridge class without device tree support.
> 
> Signed-off-by: Wu Hao <hao.wu@intel.com>
> ---
>  drivers/fpga/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index ed600d5..c1d8f41 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -75,7 +75,6 @@ config FPGA_MGR_ZYNQ_FPGA
>  
>  config FPGA_BRIDGE
>  	tristate "FPGA Bridge Framework"
> -	depends on OF

Shouldn't that dependency be removed in the patch that removes the
dependency, or was the dependency never there in the first place?

>  	help
>  	  Say Y here if you want to support bridges connected between host
>  	  processors and FPGAs or between FPGAs.
> -- 
> 1.8.3.1
> 

Thanks,

Moritz

[toc] | [next] | [standalone]


#1737042 — Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge

FromAlan Tull <atull@kernel.org>
Date2017-09-21 22:00 +0200
SubjectRe: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge
Message-ID<usfNE-5au-13@gated-at.bofh.it>
In reply to#1737018
On Thu, Sep 21, 2017 at 2:11 PM, Moritz Fischer <mdf@kernel.org> wrote:

Hi Moritz,

> Hi,
>
> On Mon, Jun 26, 2017 at 09:51:59AM +0800, Wu Hao wrote:
>> This patch removes OF dependency of fpga-bridge, it allows drivers
>> to use fpga-bridge class without device tree support.
>>
>> Signed-off-by: Wu Hao <hao.wu@intel.com>
>> ---
>>  drivers/fpga/Kconfig | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
>> index ed600d5..c1d8f41 100644
>> --- a/drivers/fpga/Kconfig
>> +++ b/drivers/fpga/Kconfig
>> @@ -75,7 +75,6 @@ config FPGA_MGR_ZYNQ_FPGA
>>
>>  config FPGA_BRIDGE
>>       tristate "FPGA Bridge Framework"
>> -     depends on OF
>
> Shouldn't that dependency be removed in the patch that removes the
> dependency, or was the dependency never there in the first place?

It wasn't dependent on OF in the first place.

Thanks,
Alan

>
>>       help
>>         Say Y here if you want to support bridges connected between host
>>         processors and FPGAs or between FPGAs.
>> --
>> 1.8.3.1
>>
>
> Thanks,
>
> Moritz

[toc] | [prev] | [next] | [standalone]


#1737139

FromWu Hao <hao.wu@intel.com>
Date2017-09-22 04:30 +0200
Message-ID<uslT4-vd-9@gated-at.bofh.it>
In reply to#1737042
On Thu, Sep 21, 2017 at 02:50:07PM -0500, Alan Tull wrote:
> On Thu, Sep 21, 2017 at 2:11 PM, Moritz Fischer <mdf@kernel.org> wrote:
> 
> Hi Moritz,
> 
> > Hi,
> >
> > On Mon, Jun 26, 2017 at 09:51:59AM +0800, Wu Hao wrote:
> >> This patch removes OF dependency of fpga-bridge, it allows drivers
> >> to use fpga-bridge class without device tree support.
> >>
> >> Signed-off-by: Wu Hao <hao.wu@intel.com>
> >> ---
> >>  drivers/fpga/Kconfig | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> >> index ed600d5..c1d8f41 100644
> >> --- a/drivers/fpga/Kconfig
> >> +++ b/drivers/fpga/Kconfig
> >> @@ -75,7 +75,6 @@ config FPGA_MGR_ZYNQ_FPGA
> >>
> >>  config FPGA_BRIDGE
> >>       tristate "FPGA Bridge Framework"
> >> -     depends on OF
> >
> > Shouldn't that dependency be removed in the patch that removes the
> > dependency, or was the dependency never there in the first place?
> 
> It wasn't dependent on OF in the first place.

Hi Alan / Moritz

I see this change has been integrated into below patch from Alan.

[PATCH v4 15/18] fpga: region: move device tree support to of-fpga-region.c

so I think I can drop this patch in my next version patch set. : )

Thanks
Hao

> 
> Thanks,
> Alan
> 
> >
> >>       help
> >>         Say Y here if you want to support bridges connected between host
> >>         processors and FPGAs or between FPGAs.
> >> --
> >> 1.8.3.1
> >>
> >
> > Thanks,
> >
> > Moritz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]


#1737955 — Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge

FromAlan Tull <atull@kernel.org>
Date2017-09-23 04:00 +0200
SubjectRe: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge
Message-ID<usHTz-5by-1@gated-at.bofh.it>
In reply to#1737139
On Thu, Sep 21, 2017 at 9:15 PM, Wu Hao <hao.wu@intel.com> wrote:
> On Thu, Sep 21, 2017 at 02:50:07PM -0500, Alan Tull wrote:
>> On Thu, Sep 21, 2017 at 2:11 PM, Moritz Fischer <mdf@kernel.org> wrote:
>>
>> Hi Moritz,
>>
>> > Hi,
>> >
>> > On Mon, Jun 26, 2017 at 09:51:59AM +0800, Wu Hao wrote:
>> >> This patch removes OF dependency of fpga-bridge, it allows drivers
>> >> to use fpga-bridge class without device tree support.
>> >>
>> >> Signed-off-by: Wu Hao <hao.wu@intel.com>
>> >> ---
>> >>  drivers/fpga/Kconfig | 1 -
>> >>  1 file changed, 1 deletion(-)
>> >>
>> >> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
>> >> index ed600d5..c1d8f41 100644
>> >> --- a/drivers/fpga/Kconfig
>> >> +++ b/drivers/fpga/Kconfig
>> >> @@ -75,7 +75,6 @@ config FPGA_MGR_ZYNQ_FPGA
>> >>
>> >>  config FPGA_BRIDGE
>> >>       tristate "FPGA Bridge Framework"
>> >> -     depends on OF
>> >
>> > Shouldn't that dependency be removed in the patch that removes the
>> > dependency, or was the dependency never there in the first place?
>>
>> It wasn't dependent on OF in the first place.
>
> Hi Alan / Moritz
>
> I see this change has been integrated into below patch from Alan.
>
> [PATCH v4 15/18] fpga: region: move device tree support to of-fpga-region.c
>
> so I think I can drop this patch in my next version patch set. : )

Hi Hao,

Yes, I went ahead and pulled it into my patchset so you can drop it.

Thanks for the patch!

Alan

>
> Thanks
> Hao
>
>>
>> Thanks,
>> Alan
>>
>> >
>> >>       help
>> >>         Say Y here if you want to support bridges connected between host
>> >>         processors and FPGAs or between FPGAs.
>> >> --
>> >> 1.8.3.1
>> >>
>> >
>> > Thanks,
>> >
>> > Moritz
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web